From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f179.google.com (mail-wr0-f179.google.com [209.85.128.179]) by dpdk.org (Postfix) with ESMTP id 5A7471B1A9 for ; Tue, 13 Feb 2018 00:49:52 +0100 (CET) Received: by mail-wr0-f179.google.com with SMTP id o76so13796398wrb.7 for ; Mon, 12 Feb 2018 15:49:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=ioOUFnwsn6MqndS9v8HSlBLOTwvpJan+UZFouw5i4/I=; b=di0u8P8GldMQoB0kG6BIJhvHjJ/fMW7w4RF53T3EgahxeVm+xuqHKaLxK1rr5mPDfY AOME4eHLVtLQKfUkhu2YwOgrsF6aqnm1jehNhWPQRoXlgNc106yzq8sSGJ6urkLYrjcr 5Fp+TyKA/lqPr7cOAjxwaiwsT0UWEhuZD0VjYTg9XP0xFyF+O33lq10dwk2htCoY+S2q e+dnB0NHRGzssoOoPB2RBcs8BvlsNfsVCmGesXjDBOjcVcX5ib83AKAJ+8v9UBtHezgR 2RikbQ34l6MBKU6QnBQ5M50T17zI7y7UBjFu97TpCbWg1OHNmG7mgHORLv9peQTFLzAg sBuw== X-Gm-Message-State: APf1xPB1YX300ekD5hc9oWIwclE12usKMTzzjPXNCyFu02TgTsqqiKv5 g0UvzSThJrZ6/OWER6CHk6M= X-Google-Smtp-Source: AH8x2259hIpA3x2I3Eud9Nvcc4mkJl+/QZ8fT+8m06AiS/v/0OV0Q7/IVWrRUTEalFxvgpq13Www3g== X-Received: by 10.223.208.208 with SMTP id z16mr11902474wrh.46.1518479391898; Mon, 12 Feb 2018 15:49:51 -0800 (PST) Received: from localhost ([2a00:23c5:bef3:400:9531:588b:44ae:bec4]) by smtp.gmail.com with ESMTPSA id n23sm5938714wrn.3.2018.02.12.15.49.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Feb 2018 15:49:51 -0800 (PST) Message-ID: <1518479390.17920.36.camel@debian.org> From: Luca Boccassi To: Yongseok Koh Cc: "stable@dpdk.org" Date: Mon, 12 Feb 2018 23:49:50 +0000 In-Reply-To: References: <20180212182022.36466-1-yskoh@mellanox.com> <1518460310.17920.32.camel@debian.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix handling link status event X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Feb 2018 23:49:52 -0000 On Mon, 2018-02-12 at 23:39 +0000, Yongseok Koh wrote: > > On Feb 12, 2018, at 10:31 AM, Luca Boccassi > > wrote: > >=20 > > On Mon, 2018-02-12 at 10:20 -0800, Yongseok Koh wrote: > > > [ backported from upstream commit c7bf62255edf ] > > >=20 > > > Even though link of a port gets down, device still can receive > > > traffic. > > > That is the reason why mlx5_set_link_up/down() switches > > > rx/tx_pkt_burst(). > > > However, if link gets down by an external command (e.g. > > > ifconfig), it > > > isn't > > > effective. It is better to change burst functions when link > > > status > > > change > > > is detected. > > >=20 > > > Fixes: 62072098b54e ("mlx5: support setting link up or down") > > > Cc: stable@dpdk.org > > >=20 > > > Signed-off-by: Yongseok Koh > > > Acked-by: Nelio Laranjeiro > > > --- > > > =C2=A0drivers/net/mlx5/mlx5.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0|=C2=A0=C2=A0=C2=A01 - > > > =C2=A0drivers/net/mlx5/mlx5.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0|=C2=A0=C2=A0=C2=A01 + > > > =C2=A0drivers/net/mlx5/mlx5_ethdev.c=C2=A0=C2=A0| 118 > > > ++++++++++++++++++++++++++++++---------- > > > =C2=A0drivers/net/mlx5/mlx5_trigger.c |=C2=A0=C2=A023 ++------ > > > =C2=A04 files changed, 95 insertions(+), 48 deletions(-) > >=20 > > Hi, > >=20 > > 62072098b54e ("mlx5: support setting link up or down") is in 16.11, > > but > > this patch does not apply cleanly. Should it be backported to > > 16.11? If > > so, could you please take care of it? >=20 > Thank you for the email. > But, like I answered in the other email to you, you can drop this > patch > because there're some missing APIs in 16.11. And it isn't a critical > bug. >=20 > Yongseok Gah sorry - too many patches to remember, I should have checked the list before asking :-) --=20 Kind regards, Luca Boccassi