From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0086.outbound.protection.outlook.com [104.47.2.86]) by dpdk.org (Postfix) with ESMTP id 2E52F1B28B for ; Tue, 13 Feb 2018 09:13:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8/byhB7shuVn1Hzw2RRGwR6esW9Ak5R6kc4gqftlJFI=; b=oPQ4gLKXGzCJ2Zg1qYjcDo9e9mbhlOSqdW/IN7QH+HMaowtQum8kU9X4NN0mcVc5ndyI6THELV6zbQwsZFAKFQcwHRax96TCx6fuTfktY7u48Jfn77BluAzQqMKPS0gQUXYz/lBywCx/vmjpE3YwZjdy+DvAa4Mhp4IkuB0ygeQ= Received: from mellanox.com (37.142.13.130) by VI1PR0502MB3886.eurprd05.prod.outlook.com (2603:10a6:803:c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.485.10; Tue, 13 Feb 2018 08:13:07 +0000 From: Ophir Munk To: Ophir Munk Cc: stable@dpdk.org Date: Tue, 13 Feb 2018 08:12:58 +0000 Message-Id: <1518509578-12070-1-git-send-email-ophirmu@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: HE1PR06CA0146.eurprd06.prod.outlook.com (2603:10a6:7:16::33) To VI1PR0502MB3886.eurprd05.prod.outlook.com (2603:10a6:803:c::11) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 393896c5-24c4-48d3-4bc3-08d572b99d71 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:VI1PR0502MB3886; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0502MB3886; 3:cbLA/SwOLzrAg2uPz8W9E04e4aa78SX9CGbcvtfB2nvky2HI34KM2cuHOhO660a2cRX/ECICwPHyt82TfIcJIUvtdI80DdDhddOJ9HLTG5I8uhfjQ+oj7MxUybx50/tlb1CWtlPpZ/BiAV34mqBhzxwvU72+X9yuClGDTq4IS/t8rI3ce8b41Xfkp3rZk61T3vlTbeIVOAYVtCWXFhmlxphMtRaEi9zBY+Iew6NvNwnMABjtenJvnZY6znM3kXII; 25:RemDx+zaHn/XQ4HBgocRQW8iMfxobWIy/t7VkoMwJ/59d52WsJUjXUgr3edsfBBjb5X0DTmPACkr3BkpTdUqcZC5Jvnua1ZG0Ie1LiXh7w74c31QdF3eb93kVcsCxcO4bk32YsJ2HFxKjU+IAU6LNzo86x3rol5nGnQdwMn9kyeShQ/len2yDHi5ryg3bjBsxnqDNSZD7lUpm0FUhslcGU5z8quEVKqGf0G8AAVe9P8vll9H1p93p30OYGlKW9gLecZiq6fRS3lf6u5hdM4AvVQuqcmCzbMJyjoy41FGqX1S7ZgNejtYm+QFJRH5nZE4weBqiQvVZMP9PnuvQihBIg==; 31:9ay/b0NViOInaJ1+jkyuKeou29uQY4RFuBG5OJcBSqgdnEsczA3yld+4cS953jObvONMPVxToGuW4TZW8y4UkryCJ2ucdMYFRJGf3qHX2x8Dq2ZnHqFuv33DLLNCR3Gey5O/fIyomn/GJXisNlfk1C8iUmAeSaqPMZY3Hp3yEp4E9VOymfcOUnZ7pkOZN3SpB0L9e+u4ouRqsVs1YYRjG8H/QQ8JvBsTN3j99Lr2Z7M= X-MS-TrafficTypeDiagnostic: VI1PR0502MB3886: X-Microsoft-Exchange-Diagnostics: 1; VI1PR0502MB3886; 20:NUMG3W/xPvG/eifhzqe9v5f74+IZxvQlDHy2xkpFLcCmPhpXvRdlqNO9Dm5mnbj6NVEDShJUfGxNVs7Tsx5o1icZ7z+ftyZ7GeGvbnDf9hj22N+6cmVjnXESCYsnUIakBEZKrTZuJqlMl6D6j3ynUqNcfvYXLeMRKCgJJ8nhfVHCJXXjbQ8g2ispZDNdoIWdTxqUvKo8zRs4iK2wFt9d7I8XvsZ8s2yxe6FM3GekutLOv5J1m5GB2Cqjnw7L8XidsrRcRp9HFZIKUYYqye2VPg/RDUvK+3K9iP8FaMzx3gbzN5dAPbZS7lWtum1mi9D+Vu+wgJdqcn5ksqh3zWHd8bHVyy/7NRB2gsv2BRgdtuH7AMmj4tI3cEIuRbN2FOb7COBhZn1o7NIn1cJU32zbZkTtOTgRIrw/pr8Oy5u/+6s+zBI10gDuFA1gpAaFtMv2rz2be6RIrTF1WSWDtszNNuTPNMuGMzrYmHLTXgEQsQdh8pR5Z2lFJOeFbdTSAu6y; 4:Gi+RlI9kwlWupbpHXTKoQgLECXbK9927weJt4a8P/M3hU80QOVJ526AdtxHB9pXPZiMIiQTcUezoHReAY+QCxPhvTXt2rBXTB2XNj9J1x+0QKwlj+Vk/M4ASUxY/+NukqcyaxHxWyAJsPiXl5y9/aumjGnIkGtzjIqGevXNNQXTH5DEjZ/XJx3toBurZ9Yn0gbQh3hgW29tXW0lLBHV16YlbDmdd603te+Xeiv4hdw7+WJJcZ9yDBjn3rqCloq/4xIPzFrMJuWzi11rI8waMSQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231101)(2400082)(944501161)(6055026)(6041288)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(6072148)(201708071742011); SRVR:VI1PR0502MB3886; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0502MB3886; X-Forefront-PRVS: 0582641F53 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(346002)(39860400002)(39380400002)(366004)(376002)(199004)(189003)(6116002)(6862004)(5660300001)(7736002)(97736004)(2906002)(16586007)(305945005)(16526019)(68736007)(50466002)(316002)(51416003)(7049001)(6346003)(478600001)(66066001)(4326008)(47776003)(26005)(386003)(52116002)(25786009)(7696005)(53936002)(8676002)(6200100001)(55016002)(50226002)(21086003)(6666003)(106356001)(37006003)(81166006)(33026002)(86362001)(3846002)(8936002)(48376002)(81156014)(4720700003)(105586002)(36756003)(575784001)(69596002)(168613001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0502MB3886; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0502MB3886; 23:i1rTcLxVher8oqwtCZF3mg2Opp+f0/Dp1sE7N4C?= =?us-ascii?Q?2bNKSjHNt+4Qs9Gh4E/z41PbASImgtZu4YRlaSaFh2U+myLtINyZyElvC6DW?= =?us-ascii?Q?D/4ziFbL3wSXb0h8sCig5oGnz9YRMCb6cGANIgXFXyjEyPosHKSAW9SO/1CL?= =?us-ascii?Q?CIB8lH08LeiYcKXkLyCuQFqB92f/wp6hUNdqGLlGosIc7li8UD0DP1dUWGFY?= =?us-ascii?Q?d/1dfEDoQXp/yRez7wEUZNC0CPRV12daucC5/OZJmKqKCCBymbDoy+oEquE+?= =?us-ascii?Q?1KWXJK2QR7KnrKJmA2p5g9UX1ge43vMres3E66e4qHc+kYWDn5YGmFbTOdho?= =?us-ascii?Q?OFG+bJIcsWWcP+6IzKdOQL6WJaRooRs0j8qFtNlrdPJKS0GFPrFdW4D4Da0D?= =?us-ascii?Q?OuGAUdByp1K7qJ6TAr+8AeHwQtFAXcwoLHqzGAVz+a7AzOCzVabaeMXXXnNn?= =?us-ascii?Q?/tfphStLx33Ju+p81KBvCdI7gS1p/E/vnTNnWj8v+1neJD/MS5O7u0PHiK3y?= =?us-ascii?Q?oClV/VDdg4fAosiwpBxGcyJqrit9NGFixWHdaCOcEOy1ddbQ0IWpg+46Xkwy?= =?us-ascii?Q?CT3ER/wbAQjwrDFcqaOV5CoVbUkr3S9FEAd8LHxTMa5ZDtU5DsSE1fvutS96?= =?us-ascii?Q?/1zQs2zdHjO+M5fZGVJTvJqiSA6drDFyFCq0d8s1PjQjgOC2Ac5CcetfA19l?= =?us-ascii?Q?k7fm1zXsX2wjXZW7enksc2oOwWLY83dX+P/9sM4TBkQaBhU8EKcdY/wj4Weh?= =?us-ascii?Q?KO/IQFxQG1FVWPalE96yyRPQj6oMBDYITWj+ozKsNHTqYanJBNEIk3qGN7ly?= =?us-ascii?Q?MBaXaxMdh5fluIEkbiuEcRg87hbQ7ftaNpx2MDXkxyycRXVjl2BgwoyrOS+Q?= =?us-ascii?Q?iGAIVBSgzduMhjb2B0PEZ81CByo8lM1hD/xynSEWtfzhlszspoXNTphI3VHT?= =?us-ascii?Q?GZSkI4JFM7Zv07DLZ7xnVQ8l+M9Yt2Cddm1f3y39sfTfI5Ulj5ZJpHDnGL1l?= =?us-ascii?Q?QGd5KkDOyVGEFmNa1hRm0rx2zMXN44UU4NPKOPanxUsBExsbYDaOQxXrvSxj?= =?us-ascii?Q?6lMDDRRi8mpUCN7DIdX2xmq8nNvzUP3GU/uy3MMvFJXi/lkEWV07zJPp0IJv?= =?us-ascii?Q?GK7bJFP6jcauk7YWarZSyeJsnQ78NX6GK8I9vgB3lYjfrcP9VSM8V0yLaVsP?= =?us-ascii?Q?rkRq1ITp8kaIa+22tbR4wc8L9SuninAWWmiNtH01AJoG6QP4+mf9eyq/nPeM?= =?us-ascii?Q?IavxUAs7N9ssOXOXBcZE=3D?= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0502MB3886; 6:deKxgN+ZX2H5df8k+H/eRFmkhY16yp4Dwcuz32SzxOB4DYOLyYXc9JUfsXY5u83O0ktw4z7IqQhDlfjw5BT5n1Llwe2OlreIq6PuzrtFs55tfulufxMNEcdY+V64xjqtJZipFya0ovw4HZcGcOiH05p2tSZvI03sVOcO2R74W0Apy9wmKgZ9sP44HdGESA20Wx4ljOxtYLOrjScT+ktcc746Ffzh9yRZgFQp2EvkxBpr5jDV1vARDgYbI3Y/rf3WPUqjQ8mfTCh7+X7HCzxVnXXAffDtqo82Ng7QaToo47oqMdRkIi7+dOqldPZ1t6xqD7sh9ooip4L8bIQomTfk0Ny6JkLF3equuAl/DFc+uXk=; 5:SqTmTWZzBIO1ug3/86HgpDXQ0Ox/+eWlr5G+5yn8/gdGRKkfWJVZH+RFGCLEpTUzHK8b5EYq+FJ793c3S2z3bqvdc6s9ik/p9Boagg7J3NdtNleTUOn7hRftdQ6qP1gUuEK12o2K8GPCkq6W0HnJMUf6pDFM+1LbN/Tpg6dpX/A=; 24:fF//cb71XrMtmoUr9S4qxB6UFHPPHaCBaNU0bbu5S0NDGfbd9jLyxKo9WLc6it1XHL4hFDOxge5e3MnCMJLUUaqd31B0VoDTZwVAww8wqG4=; 7:DW2RHL2y1hPGZoFUdlE5/IFXhESACXaE8z/6mpK+52w83TRiCfMccyd/idLiyJbHf8AkURCpJm9zj6HwLIrOnqGRKMS7dR93xlCrATm6BCm861PKjf5LAD/gf5fQLEUWdmvnWU7lK3/688UlquYXRjS5EWvBmXzaMM9z5vd9yRBJokN9yFxigswqph8kd15X4WI05oB2udtGpD6GlMvKqgIWMjNE0L2QcZk5eHaR0kYrJnRralDBnXrL/yiVjc6b SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2018 08:13:07.1569 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 393896c5-24c4-48d3-4bc3-08d572b99d71 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0502MB3886 Subject: [dpdk-stable] [PATCH v2] net/tap: add CRC stripping capability X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 08:13:09 -0000 CRC stripping is executed in the kernel outside of TAP PMD scope. There is no prevention that the TAP PMD will report on Rx CRC stripping capability. In the corrupted code, TAP PMD did not report on this capability. The fix enables TAP PMD to report that Rx CRC stripping is supported. Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") Cc: stable@dpdk.org Signed-off-by: Ophir Munk --- v2: updated commit message drivers/net/tap/rte_eth_tap.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 9d39384..f09db0e 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -261,7 +261,8 @@ tap_rx_offload_get_port_capa(void) return DEV_RX_OFFLOAD_SCATTER | DEV_RX_OFFLOAD_IPV4_CKSUM | DEV_RX_OFFLOAD_UDP_CKSUM | - DEV_RX_OFFLOAD_TCP_CKSUM; + DEV_RX_OFFLOAD_TCP_CKSUM | + DEV_RX_OFFLOAD_CRC_STRIP; } static uint64_t @@ -270,7 +271,8 @@ tap_rx_offload_get_queue_capa(void) return DEV_RX_OFFLOAD_SCATTER | DEV_RX_OFFLOAD_IPV4_CKSUM | DEV_RX_OFFLOAD_UDP_CKSUM | - DEV_RX_OFFLOAD_TCP_CKSUM; + DEV_RX_OFFLOAD_TCP_CKSUM | + DEV_RX_OFFLOAD_CRC_STRIP; } static bool -- 2.7.4