patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Harry van Haaren <harry.van.haaren@intel.com>
To: stable@dpdk.org
Cc: yliu@fridaylinux.org, harry.van.haaren@intel.com,
	vipin.varghese@intel.com
Subject: [dpdk-stable] [PATCH 2/4] app/pdump: fix the memory leak by rte_service_init
Date: Tue, 13 Feb 2018 16:05:42 +0000	[thread overview]
Message-ID: <1518537944-125482-3-git-send-email-harry.van.haaren@intel.com> (raw)
In-Reply-To: <1518537944-125482-1-git-send-email-harry.van.haaren@intel.com>

From: Vipin Varghese <vipin.varghese@intel.com>

When pdump is run multiple times against any primary application,
it consumes huge page memory by rte_service_init. This is not freed
at exit of application.

Invoking rte_service_finalize to free memory and prevent memory leak.

Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
---
 app/pdump/main.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/app/pdump/main.c b/app/pdump/main.c
index 66272f5..6f71c69 100644
--- a/app/pdump/main.c
+++ b/app/pdump/main.c
@@ -54,6 +54,7 @@
 #include <rte_mempool.h>
 #include <rte_ring.h>
 #include <rte_pdump.h>
+#include <rte_service.h>
 
 #define CMD_LINE_OPT_PDUMP "pdump"
 #define PDUMP_PORT_ARG "port"
@@ -911,5 +912,7 @@ main(int argc, char **argv)
 	/* dump debug stats */
 	print_pdump_stats();
 
+	rte_service_finalize();
+
 	return 0;
 }
-- 
2.7.4

  parent reply	other threads:[~2018-02-13 16:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-13 16:05 [dpdk-stable] [PATCH backport 0/4] service finalize and co Harry van Haaren
2018-02-13 16:05 ` [dpdk-stable] [PATCH 1/4] service: fix memory leak with new function Harry van Haaren
2018-02-13 16:05 ` Harry van Haaren [this message]
2018-02-13 16:05 ` [dpdk-stable] [PATCH 3/4] app/procinfo: fix memory leak by rte_service_init Harry van Haaren
2018-02-13 16:05 ` [dpdk-stable] [PATCH 4/4] doc/release notes: add note to 17.11 on cleanup Harry van Haaren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1518537944-125482-3-git-send-email-harry.van.haaren@intel.com \
    --to=harry.van.haaren@intel.com \
    --cc=stable@dpdk.org \
    --cc=vipin.varghese@intel.com \
    --cc=yliu@fridaylinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).