From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 0057A4C97 for ; Mon, 26 Feb 2018 12:00:02 +0100 (CET) Received: by mail-wr0-f193.google.com with SMTP id w77so20680293wrc.6 for ; Mon, 26 Feb 2018 03:00:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=G3YDNPHTjMhz8zTINO1W84fjMq6Hzz12NpRd8Xtmd8s=; b=GwFMs1WFuvbE0z7aY3bih5rtQZC0GQO37o7MGsp3tWMP+VJrOcJdHnP2MtZdBYPV+d OtBcPi8lx543JvTDraFxv5MRCw6ScKsCkMdRavYPOxE4nXfOgtbvBgEdm8l0qTK1nM9x ZG5Ot72gWlvHPn41Jd8uV3fBDij84TNwcGN27WFTPK0X7CMs3ivpAKhXs+ctEnoiiCLD 6gmWvOAVbLH53gNDeGSa1iC3+bg673p8wiMwAlJeXMS1L5RWQAMfv4aSCl08A07pHfQN UQNDn4h30W24aDumufNnqxSwo10JMgUhAZYMhv728kwnT5V4GOviIV3V4vSFUbJfwiT8 gq4w== X-Gm-Message-State: APf1xPDgocfCsXgxW7MeFKELyeeZpucRpzzMUaejBkOBomvxXF5OSWIh 6k3/B9mDIxL5Y6WrF1DiMxYDBaTG X-Google-Smtp-Source: AH8x22436NXyzC34kd7Ow4OjpnoN5uU5PSzWhJSYUyDpSFwW2vQ/ON9tC1ahTGXY3c/eNPNJ+rkM9w== X-Received: by 10.223.183.74 with SMTP id n10mr8761353wre.124.1519642802640; Mon, 26 Feb 2018 03:00:02 -0800 (PST) Received: from localhost ([2a00:23c5:be85:1400:6930:196b:56ac:33db]) by smtp.gmail.com with ESMTPSA id t141sm12216338wmd.34.2018.02.26.03.00.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Feb 2018 03:00:02 -0800 (PST) Message-ID: <1519642801.22753.21.camel@debian.org> From: Luca Boccassi To: Rasesh Mody , stable@dpdk.org Cc: Harish Patil Date: Mon, 26 Feb 2018 11:00:01 +0000 In-Reply-To: <1519622173-14087-1-git-send-email-rasesh.mody@cavium.com> References: <1519622173-14087-1-git-send-email-rasesh.mody@cavium.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 1/2] net/qede: fix MTU set and max Rx pkt len usage X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Feb 2018 11:00:03 -0000 On Sun, 2018-02-25 at 21:16 -0800, Rasesh Mody wrote: > [ backported from upstream commit > 9e334305178fd3715c17088632544bf58e5836a9 ] > [ backported from upstream commit > 1ef4c3a5c1f76b810620b76d82a31ce33a83d3fe ] > [ backported from upstream commit > f6033f2497e7d01d8c6f0d691e2f86937597aa35 ] >=20 > This patch fixes issues related to MTU set and max_rx_pkt_len usage. > =C2=A0- Adjust MTU during device configuration when jumbo is enabled >=20 > =C2=A0- In qede_set_mtu(): > =C2=A0=C2=A0=C2=A0Return not supported for VF as currently we do not supp= ort it. >=20 > =C2=A0=C2=A0=C2=A0Add check for RXQ allocation before calculating RX buff= er size > =C2=A0=C2=A0=C2=A0if not allocated defer RX buffer size calculation till = RXQ setup. >=20 > =C2=A0=C2=A0=C2=A0Add check for before performing device start/stop. >=20 > =C2=A0- Use max_rx_pkt_len appropriately >=20 > =C2=A0- Change QEDE_ETH_OVERHEAD macro to adjust driver specifics >=20 > =C2=A0-=C2=A0=C2=A0The driver can handle dynamic MTU change without needi= ng the port > to be > =C2=A0=C2=A0=C2=A0=C2=A0stopped explicitly by the application. However, t= here is > currently no > =C2=A0=C2=A0=C2=A0=C2=A0check to prevent I/Os from happening on a differe= nt thread while > the > =C2=A0=C2=A0=C2=A0=C2=A0port is going thru' reset internally. This patch = fixes this issue > by > =C2=A0=C2=A0=C2=A0=C2=A0assigning RX/TX burst functions to a dummy functi= on and also > reconfigure > =C2=A0=C2=A0=C2=A0=C2=A0RX bufsize for each rx queue based on the new MTU= value. >=20 > =C2=A0- Fix minimum RX buffer size to 1024B >=20 > =C2=A0- Force enable scatter/gather mode if given RX buf size is lesser > than MTU >=20 > =C2=A0- Adjust RX buffer size to cache-line size with overhead included >=20 > Fixes: bec0228816c0 ("net/qede: support scatter gather") > Fixes: 2ea6f76aff40 ("qede: add core driver") >=20 > Signed-off-by: Harish Patil > Signed-off-by: Rasesh Mody > --- Thanks, series applied and pushed to dpdk-stable/16.11. --=20 Kind regards, Luca Boccassi