From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0054.outbound.protection.outlook.com [104.47.1.54]) by dpdk.org (Postfix) with ESMTP id CDCD34C81 for ; Wed, 28 Feb 2018 17:47:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vIq1DucdqzvY9nLia1OsoVBtt1sjYm2fo2gQueHdOWs=; b=CU2Jyg5BwUuyrwbSBvc0tgBjVydxJ6JnC0tegtIPwPbS/Rrs+QDU2m20cAhfKTQtME5nIEsk1moQTEtWaZnJ2kB0/s16k0XMmbzgLXqZ6JugtXfPGJPHlV7eD+dvS7LfnCv00UGZPT7Qr10gRRxqIYKO3j3dwlhi/7e2ovieq68= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; Received: from mellanox.com (37.142.13.130) by VI1PR0502MB3887.eurprd05.prod.outlook.com (2603:10a6:803:c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.527.21; Wed, 28 Feb 2018 16:47:03 +0000 From: Ophir Munk To: Ophir Munk Cc: stable@dpdk.org Date: Wed, 28 Feb 2018 16:46:55 +0000 Message-Id: <1519836415-11827-1-git-send-email-ophirmu@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1P194CA0017.EURP194.PROD.OUTLOOK.COM (2603:10a6:800:be::27) To VI1PR0502MB3887.eurprd05.prod.outlook.com (2603:10a6:803:c::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 1c98dec6-eaf6-4c12-954e-08d57ecae562 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:VI1PR0502MB3887; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0502MB3887; 3:SSHi6WTbYefk7Vtmo7HVBnwrZ3Q6gJK8P9yHEsg/0GWE4ipyWvJIGiZOR253pMYAkkfcABSsqK54D+seLcrNCDWHVgS/ybweNxTRKkCmnaRk9IJolAJI7f5hKtlWrMSEd+yy7qlxqi2Gwxo2i3T9FlKaYHPI4Foowb8FJ1VNIvfm2v+Sm3tIfUSOheBI4hKqPqeUI3H1NNyLIgad3JwVNHZ3NMnRCSL+A8uFpNJ9uLhYybMZ20X99J6kZN+trsIF; 25:GmdzSE01oXCWJqVm6sGVSaFkXfxNJ21iM83eByZfadNFKFYn5QfFOFQfdM9d4CMS3HxbjcgBNkEYUX874va64/gt5AduhRZPXrWhNF+anjjq/hegDs8GONxeonMOxII2MpD4GgTlcl+foW4j5a9WncW379IdTAu7duAPwpprrv3SGi1XG+5sImv2sS9pLUrKqW8FHnljVxshQeoTGKJho9WDL4bmO8+epKhXK7IaLfa0Kspo53a74of69rLnmuiUYSdyMRIUYBBLHHslns0WZGpa74+2YU72aQvyRXnhlrAl4GLRuh+LFr80uuL0qox7Um85virSRPYggghXoTQvhQ==; 31:wuTK06Hqa32CO2Box0BeBjVKoqABCGOKkslph+yiMzQEOveGK1XhqOmMxzICT8etla/D8L3fNx80eCnlyyjyk3Ra3uTeNQI6cw+sLj3s8JcdUERY2zQSSJHw0EyuWIkglXMoWkKGKwEojfhIrALqQKrHwk5FE1qAoNOaWpqUyUoeW3P7V1PzciPDaNCljRAhlan6qCOmBZ85JNBk1yz6g8Cj+9VU1rb0svbaUZseerA= X-MS-TrafficTypeDiagnostic: VI1PR0502MB3887: X-Microsoft-Exchange-Diagnostics: 1; VI1PR0502MB3887; 20:5Ygu65zF3vKQGkU4I3CBUx5DDSuC5Z9pLnRw2aR9z20EeL9rG4lVlBhuc8yQ25qDvbWhgTceRMzQc9pgtwwkjokvr3h2A8N2coJNQYNCqKEbs2e3W0UhVtAxtlj0Bjx5CKcco+hv8/BqFJSPtZuIReu2isDlGkVj5LBa2tnCOn5ElTeUeWRq+8HQKsaMJvU35SBpvZvuk8u7+Gdvpa94vISu0jjOMZhjS1nlrZoen70U6Ane1op2wHNHPLuCXv2Tf/4DeftcBrVvmFIkz2AfmMZhiUW4+bkLZQYNDG+FHTcr1XWJNqrrGWyMb+Jrv9j26p45A8vKnF/9tFvrsLbCsMMZX2R2pyOUi0n2gf3D8Y0b1oi7ME6r0OB4y8/z8NdPw3F7mrC6fe3f9GRNzupDf05hjhg81vqS6TpOF9/zMwqHR9IglZcqh5HmqJAuQl0iy1vCM7jD2j2Olt8BHWrWZC3OqIoe9FDil373EnCsAo9ZPoPVvramB0Pcf7wrwOhp; 4:ka3XSTEHK9CMFkmk7gEqzQbus4FMWFMpoKxJwxRTw8cD/7uuI1ChTyrb9djU38ed4q+GeHVO6AytNnxGvpnazna3Q+hGw6tuZWlgbgeSowJzuuq/FelA+VdXdLNhKIsdUtEGOrpA33pvkudbHxbaCML3GIkAx3NgxZI9mZi0JGhzHWaTDybT9Sze4CWgkfnM8USJ2BBarAF+/+ZMcGOP0FgTLol5fmf6DVYrVbeAUbJYT/4PuI9fG3U325ut+Fxd6iO1fApXYImlu7de/du6tQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(5005006)(8121501046)(10201501046)(3231220)(944501161)(93006095)(93001095)(3002001)(6055026)(6041288)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:VI1PR0502MB3887; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0502MB3887; X-Forefront-PRVS: 0597911EE1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(346002)(39860400002)(376002)(396003)(39380400002)(189003)(199004)(69596002)(55016002)(53936002)(7049001)(66066001)(305945005)(5660300001)(21086003)(47776003)(106356001)(478600001)(105586002)(316002)(36756003)(4720700003)(6666003)(33026002)(16526019)(86362001)(6116002)(26005)(8936002)(7736002)(386003)(16586007)(7696005)(6862004)(37006003)(2906002)(4326008)(52116002)(3846002)(6200100001)(51416003)(25786009)(81156014)(50466002)(97736004)(68736007)(81166006)(8676002)(50226002)(48376002)(59450400001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0502MB3887; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0502MB3887; 23:xkegl9mbbeF3EMOzBSJn39twX/OReLYZfCfI0dU?= =?us-ascii?Q?oR6a0uU6OiqEPEknB1SYnz1ys0QFWUtbVv8uA+vYfX28UjLh2vuIkJtqSRAd?= =?us-ascii?Q?bMd3WJIuPb/6EYkeC2qKjB0yLIjqFm2b0dL6pUJt+DRi27ujqF2UDlnRSL8O?= =?us-ascii?Q?PAWugdBZo4/r0aYq1JArMS0ORLaX89EQgQFHOrngKPdfRxbpAgjIhkfTCecy?= =?us-ascii?Q?WIb/pvDGKpECYHq167brbFhmEMaVRGaScQDE3XNZRkbEcRPt3OIA5IMY2z1z?= =?us-ascii?Q?yIB//HU89AdSK+6EQRRtjugoHm/tfs8NxYtmTzh1zWAv5wrz3zaWUXlKyNlz?= =?us-ascii?Q?oCv5pL3trhdsVhMY0Ajs9WsPf5MSX9h9ftKkafTpfdzI+ntGcsfSMTGFIBle?= =?us-ascii?Q?NBrNDoZUCT4YlTPMn/rq9g76XVhKk8ERnOR9G3maEa74bSxh5MgRMeHTwKwf?= =?us-ascii?Q?43aCN6GhjBhF2A3yt1svHGSprXswKtG8GWAYlaAbRj766B0YlrtE9Dx+e1Is?= =?us-ascii?Q?tguc0aZrADj68V+mo24aZLKtXbZqsMQ+can2MOX9YivvPGvTD5638R5+w9J2?= =?us-ascii?Q?xQwmXHpXOnKx+JBYvbiwcl2rZ86RsU/d0mIeix2mJECAjAmbnkw0fjehOWXE?= =?us-ascii?Q?I09xiExDYZ71DCFIDkWy3jbNvNrVuxBHKZqa7KSLuBoP1bnzrp0jV48G1C1m?= =?us-ascii?Q?oJtz+iElCzlLETNnptwoKVJTwIHUcHw0AdnzaEM/8isXqrHmhslwTXiYDt2o?= =?us-ascii?Q?DQgEA4gfo5U1sZtzI9MOWqquz0hKJsQ9Ur/BUIVpT6mA5w5VRn8wRbtgzXzC?= =?us-ascii?Q?1FF7IPAjhgNXWsQz/pDR+d23rBUlsKzLAFpyIppljPAq1UJODcGB6EWBEm21?= =?us-ascii?Q?Tz92FMpsguceov/hggtRBCwk5Nq2wF5IAkgR/k2ppb1YecMbocTlgJ/mwEtx?= =?us-ascii?Q?duCQw2xJtWWE87JYjy835paJpdYZ/LVYvjB/5m5/8grRVg56PuFuzsb0H7lT?= =?us-ascii?Q?uaLpLUj8o8E61XsEIvwsIA7xJQTo4HTBSeAvbsH4ZQDHfoG9KnrKaPF27zdd?= =?us-ascii?Q?H/rfVy0+CTbk7sPHTWShMx6gkcVr0Vl8JZ3WVnyN1lycHcua21KV/udN9/g+?= =?us-ascii?Q?iLlb6/KirMciFoZaAM5quE7eNnc23RXki1sdPR/ZnRtaK08Ff2C7XuL1usmf?= =?us-ascii?Q?YHuBfG7bZmMS21yWq1Hg2ffLtY99Qn0KeHqsp?= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0502MB3887; 6:tQvo1ackjMHvAiSgyMV6EeQoCTU41DzuUKDCyrDkpbOFwzHgglv8e59BgHPU+mBq33KEfXmJc+sxKNna+HHx18BVRgac7jU0RBtmTQZuJleJ/tV7rx7SsFyZ4iyg+sr/zI4pPsWwOF5XxbOCOiAD1GOV9ZOlI7NfYNx4W//3woORkosFM/E2AbZT/RJdvJcmeElIH4Dr8+YmDbxJaR8OdB8YHF8g+svtlQsY5O+KbPfozE1wmVk5iWdhmrN5MD4yCLymAsyLRdalocDHt3GdlGteJcIiqVwwgx2HqpLbEJ3kJ+nTWqVD4rtf84r1dr+4B82l4BJWAclkFCCBMNjQO2vzCJN3yHqg+MrOuZIVd78=; 5:F8SX2w01uKpYbCxI8k5DZpkoTECTkqYb8hXSEqBrpIkS6Nmk5Ok9wAK7mRwnD05sGxRrO3w8dKIY+3kU4a2a4/W4ag50/I4u18aQPf1fOLjJkQqvdKpGwpFL5jlk97mHNRzSvMrX41KNh/5tW2EbZMFZ0QKETc6CZhmb6QQDDsM=; 24:o7lbhMngC+sQHxFp/7EqDc3tVD5HfNPwQYqmGu9z02sNDk/Jq6vEZdTz8VZl2BgN7EFkUsK4p13PTeSqzg1vb2YwK+ISRG3lLRz0zKhDY34=; 7:jiv7Pcp8e2akQPSFElBWnhTiMCt48p+WRT09vmkMVqk/igY3Vvpw64htYUM9QUFCZszFS2GJ4q5FwK6UZKAlnr6Z+sFzhU1MbqJuvcAec0YXUFEqqRH1IWs7TBA1msYUk+etS7mXdkIx2dM7yq0xOfm1NcZHmLFGawtweTGo3EF+SuvujyyG9qJee5A8n8hDA/9/8BMM7TXdys87fiHVWgHlPsLifzAisquD1xds5F3aba79wdtepvszDMfGbwIB SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2018 16:47:03.5354 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1c98dec6-eaf6-4c12-954e-08d57ecae562 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0502MB3887 Subject: [dpdk-stable] [PATCH v1] net/mlx4: fix 'show port info all' during detach X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Feb 2018 16:47:05 -0000 The following scenario causes a crash in function mlx4_get_ifname 1. On testpmd startup mlx4 device is probed and started 2. mlx4 sriov is disabled. As a result an RMV event is sent to testpmd which closes the device and nullify the priv struct members. 3. Running 'show port info all' in testpmd results in segmentation fault because of accessing NULL pointer priv->ctx The fix is to return with an error from mlx4_get_ifname() if priv->ctx member is NULL. Fixes: 61cbdd419478 ("net/mlx4: separate device control functions") Cc: stable@dpdk.org Signed-off-by: Ophir Munk --- drivers/net/mlx4/mlx4_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/mlx4/mlx4_ethdev.c b/drivers/net/mlx4/mlx4_ethdev.c index 3bc6927..cca5223 100644 --- a/drivers/net/mlx4/mlx4_ethdev.c +++ b/drivers/net/mlx4/mlx4_ethdev.c @@ -67,6 +67,9 @@ mlx4_get_ifname(const struct priv *priv, char (*ifname)[IF_NAMESIZE]) char match[IF_NAMESIZE] = ""; { + if (priv->ctx == NULL) + return -ENOENT; + MKSTR(path, "%s/device/net", priv->ctx->device->ibdev_path); dir = opendir(path); -- 2.7.4