* [dpdk-stable] [PATCH] crypto/mrvl: add missing library dependencies
@ 2018-03-21 9:44 Tomasz Duszynski
2018-03-26 8:57 ` [dpdk-stable] [dpdk-dev] " De Lara Guarch, Pablo
0 siblings, 1 reply; 2+ messages in thread
From: Tomasz Duszynski @ 2018-03-21 9:44 UTC (permalink / raw)
To: dev
Cc: dima, nsamsono, jck, jianbo.liu, pablo.de.lara.guarch, stable,
Tomasz Duszynski
While trying to do a shared build one will get linkage error
since a couple of library dependencies are missing from a makefile.
At some point there was a batch update of all PMDs but mrvl crypto was
missed back then.
Necessary makefile changes were introduced in
commit cbc12b0a96f5 ("mk: do not generate LDLIBS from directory dependencies")
Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
---
drivers/crypto/mrvl/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/crypto/mrvl/Makefile b/drivers/crypto/mrvl/Makefile
index bc5c227..9870f02 100644
--- a/drivers/crypto/mrvl/Makefile
+++ b/drivers/crypto/mrvl/Makefile
@@ -58,6 +58,8 @@ EXPORT_MAP := rte_pmd_mrvl_version.map
# external library dependencies
LDLIBS += -L$(LIBMUSDK_PATH)/lib -lmusdk
+LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool
+LDLIBS += -lrte_cryptodev
LDLIBS += -lrte_bus_vdev
# library source files
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] crypto/mrvl: add missing library dependencies
2018-03-21 9:44 [dpdk-stable] [PATCH] crypto/mrvl: add missing library dependencies Tomasz Duszynski
@ 2018-03-26 8:57 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 2+ messages in thread
From: De Lara Guarch, Pablo @ 2018-03-26 8:57 UTC (permalink / raw)
To: Tomasz Duszynski, dev; +Cc: dima, nsamsono, jck, jianbo.liu, stable
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski
> Sent: Wednesday, March 21, 2018 9:45 AM
> To: dev@dpdk.org
> Cc: dima@marvell.com; nsamsono@marvell.com; jck@semihalf.com;
> jianbo.liu@arm.com; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; stable@dpdk.org; Tomasz Duszynski
> <tdu@semihalf.com>
> Subject: [dpdk-dev] [PATCH] crypto/mrvl: add missing library dependencies
>
> While trying to do a shared build one will get linkage error since a couple of
> library dependencies are missing from a makefile.
>
> At some point there was a batch update of all PMDs but mrvl crypto was
> missed back then.
>
> Necessary makefile changes were introduced in commit cbc12b0a96f5
> ("mk: do not generate LDLIBS from directory dependencies")
>
> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-26 8:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-21 9:44 [dpdk-stable] [PATCH] crypto/mrvl: add missing library dependencies Tomasz Duszynski
2018-03-26 8:57 ` [dpdk-stable] [dpdk-dev] " De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).