From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0044.outbound.protection.outlook.com [104.47.2.44]) by dpdk.org (Postfix) with ESMTP id E695A1B89F for ; Tue, 10 Apr 2018 09:19:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=tPyUwLANMOXJqzKzpCQGsMR5fHcwpHYPcEB245+CS1o=; b=YAUAh/q/daAjLps/2yVTblqtOrQcdoSPA9ScE7CPldW48ivj9qK/dn0oQY1tZtRT2KFRxbnx3XRzDiyXh0H7QA0Rxrb/IuB46bBK8cloRYVRN3rVSvgFMNoJmy8ol+ncM2cqE+wGUcw0yraykNhyVQIzNi+vtzys9kRNyUDnH3c= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; Received: from mellanox.com (37.142.13.130) by VI1PR0501MB2320.eurprd05.prod.outlook.com (2603:10a6:800:2c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.653.12; Tue, 10 Apr 2018 07:19:52 +0000 From: Ophir Munk To: Ophir Munk Cc: stable@dpdk.org Date: Tue, 10 Apr 2018 07:19:41 +0000 Message-Id: <1523344781-8819-1-git-send-email-ophirmu@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: HE1PR0202CA0018.eurprd02.prod.outlook.com (2603:10a6:3:8c::28) To VI1PR0501MB2320.eurprd05.prod.outlook.com (2603:10a6:800:2c::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ec011615-bf0b-473c-a707-08d59eb3742b X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(48565401081)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2320; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2320; 3:EQWm4XnK3IqRgGurXutK8o/9leV5cOqGs9E9yV8NLJ1oJquDnJcASXShMtR6/8ZUUcPgOYuGm7Yq7Fi53GeYaIi+M3P2zQOumdJ+A2doJQXW/CVKWOgt9tCf/qyprSxNbEY4lOYqTp14/7OfGPc5HNHn0WtFlQTocXJsJ2oBdIslIcaaLFCd+gUCqDAyRGlwwj68qwG+aul6+i5GfWDAmNGoOsUYvjYt92FkiLKRJlEM8cWTClQKaI6Q+CRcE7xO; 25:gN/S3IET0iDv1vd+PraqxmicXVAGAPptcrqGsja/OeAcWQ+1ZIQAgURRAscRgjSqQKWCFpBJGewijRQDcWFnruy0JlTFk6SicDbQ/WmdwNH9hROOwsaL8u5wvP2DLAG3LlLkcAu6tBs7HfrxDRRd8ZBvzRAVeQz3Qucn9T7K9bNCuQwdgzU3h1mP3kg3gy3CRzjaYfqfMOItgwSXl+7wuUmei6sRFaWn2jiNYjuZQM8eOCzB4EXLjBHyfUC06CKZ/sI2htuLhdNXgFsaZZafdBc2suYsIjIBQP6hubmgluG43ME57JsiO3QyhzwpDRChabR2ORejB2kg3IFpryQFww==; 31:KjC7M/EcINp2bkjxufc9k0xHCCaMr1yX1u0U+T/DvHyWmb3hLB91V7uPZjEZrTIoRVtx45rmMSbHVnKcM2jBYYQZRHa9HkNiEZMtmhBLFPbUv1UhH3AnVBk4MqxLcfohSamKY9mPecFoV5+PvcAx8AfieeCu6IJw9AYdDxaeui/PQbvL+IGP/RNOIWCGiNTJkeypBDvxDjZvLbSoOZY2DCRcThzyBwyYtjoy2qUTmGg= X-MS-TrafficTypeDiagnostic: VI1PR0501MB2320: X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2320; 20:BCCma2/Ol+mGR1Gd0yiA/BVFAmZgi26lYOhc6SlJA7b953EAwl6JpLrgBA+zoK1pDkLJGm6LIWVhjkGfa14v4Di7cv/L6k+KhcvPcFCdlYij1JjkQ+UH0XfFxqu07/80d7uCdssZrbtmjntEZBhhgUSSl55XdXU3SGDiQjh/3xgolrdsQRuzNA5VuJr4cN/UygNVEdN/uVfURRDtgmocF/dtcwrHYUy3129Xt5sD404vZXaH9B/AFngL9nHbrUpWEnIsTfV5xacIQ7FJJYurfWF65MZHCw+EfObGDR2TVi7dXz8ZkNHN+tS5wdXOzrlWnZyCvARCRxp5OENrkEAiWRbxIeqpNextCHokAf6g1QVJAWSlr7KcVWd9/EvahCkvEE1SQw+6E+nKcQF7iu3RhGPWzBmhDAyY8KzVQ0YNZy0aCdsMqKREYo5sLKUSyIyOUP/7qSoxbnZVyPQKW7fMZKT/kPhqCelqO220+4j6qZKJfO792qZScKJsiup2lBf8; 4:EFA/zmc6erXZ4F1VFrshlPfwbEUMLRwAZaBF9mFzgibiGUjTJTJc9rRZoMDdR2XJya9gKIKq0TC+pKF1vIv7vat3+MUAt85QN8EOKxoP3XTn4Siu1u//aff2eYsqjjx0LpTLugiMSmbZx3W0Z1NDNqFZzt4zr7paM/1+upCBxavCMAOCQ2AFhsxKIUeUTvwokgabuWuzfQ2arS+iv0kGI7IJI+7tcRYFp9svuunRL/tXMm6kpu4GkFtFaQIwUF+owWMJJNDWtsehx8N9PXESxQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(3231221)(944501327)(52105095)(10201501046)(6055026)(6041310)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:VI1PR0501MB2320; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2320; X-Forefront-PRVS: 0638FD5066 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(346002)(366004)(396003)(39860400002)(39380400002)(189003)(199004)(66066001)(55016002)(4326008)(4720700003)(50466002)(47776003)(48376002)(8936002)(81156014)(81166006)(106356001)(478600001)(26005)(21086003)(5660300001)(52116002)(69596002)(316002)(37006003)(6200100001)(6666003)(476003)(6862004)(305945005)(51416003)(7736002)(16586007)(2906002)(7696005)(486006)(36756003)(68736007)(386003)(25786009)(2616005)(105586002)(50226002)(956004)(33026002)(6116002)(3846002)(8676002)(7049001)(53936002)(16526019)(86362001)(97736004); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2320; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0501MB2320; 23:/rdAlX4rCierG44ObPZzBgPi87fwRFEV6L7TeYz?= =?us-ascii?Q?4HyWEdRy3OuLqpre4R/2ptwq2uHHyqqzc+494JV13qlmImAG0Qko+rwEd4Of?= =?us-ascii?Q?fQYMDvH3mZTv3idQ/H7QnU2ji/xrdE6lmAcvRk7Zs1igqzOEvFDI5vHLNzjU?= =?us-ascii?Q?7kBA9cwHt561tnk/J5vjsRmlr3mWvrWrNBgpQrScNW8xKAxM6yosT7nY7X5K?= =?us-ascii?Q?fS0WoNp0VPR6904LkBJhGABWQ66T/r2fPzfu8Q0OPbFtupaqlo1z0RtoQNlG?= =?us-ascii?Q?sdFgqQsEvkmtDygWcURC+GZsYnaQpEuqk9mw4QkQToVGNJ0VAvyGXIRHnviu?= =?us-ascii?Q?LPiN1YQkmjEQ4R9U5FKwYevFgO5aM/l3kDda64MmJvW3aUBDXV20r3Cq4tZG?= =?us-ascii?Q?mqy4v20LU39CxWslUTucaycKb/cSyXURK4OPUUHTLkUFsgOECnBUyuN9FWMf?= =?us-ascii?Q?gDePzIeOqjjxqN+7tXIHGTMBxY/R591vgHNWMUB/g0/jPLYz+54C8nXFyYZb?= =?us-ascii?Q?v9TkVxiRlJcTdAZgGND9inMwvP6lnBwCVUl83VsSaNOOGQ5Pcsqgi+HvpDeq?= =?us-ascii?Q?h5aWRqUAexlm2FKOkeDtdxicS4i593foW+qYfctqTfdNssGZ9+uSeC3YUzov?= =?us-ascii?Q?kGzh5izXvEhcPoztd++fQ8YghiPhOhLCfRdMEatXOZ/anTsxQKF72kpTLQmB?= =?us-ascii?Q?J2RCzHJMQXqwbL4uaXdGK2hAaxpwKHUi63cTBy7FTlmP3MwRUHYV/Am8rRH9?= =?us-ascii?Q?tEGLlFtwxWs1MpbwE4jRNvkwTvsXAZntSzWFMbrl7Okcs1LrZOwz3Dtud7qi?= =?us-ascii?Q?46ubiLu25Dp3JaTYA0notoZpVDvOBjepzVdZ14/SEIhujkRoMSLedwpXq44m?= =?us-ascii?Q?Li0JuDFSEY3jCv6CkX+KAvR9QbFiCLi+IeghVFED474QoMi/12ROK8ib/vEG?= =?us-ascii?Q?7RKMBJEAAlMKlwi8I+N4dkcqqVLh2hBWQy+fCVD55BuMKbZcf30AVHw1NZKb?= =?us-ascii?Q?dXUuZ8Dzg/kKIdD9FP+aH/kcOwWLRajPJWVX4a8WDQ5su5j8qGhh/oJXo2Oj?= =?us-ascii?Q?1FOMTwAr48kAVutbEYUeRY8xDvR4TSeDKUxKMllnCUGS+uYpwLn+phdm7It8?= =?us-ascii?Q?Lvh3igNWYb25fD6jl/EQkvhXWa2Gh1Dcfd+FH1NsjGGWkFn8g/LvUdOoOQy1?= =?us-ascii?Q?MKLoeXTBgwpE29/2b5zK/fyj8b24eMRqhnWQF3VGXHxEynOpvH2psBGaeeqj?= =?us-ascii?Q?fSORWPP528qc2MW/PPCU=3D?= X-Microsoft-Antispam-Message-Info: iieCTknkDHObvTpjBi46VNC67QiK8LZjiJpDHK86j0IeGYIuUBbHRRLFRi/2ZqM0qN2lZM4eqN272FsHyCFmWTOC3sWyzcYN7TgoJLkDmXRnOYS24hU6zfBf5yfHHAYCzmbaYDNkmqbw06IK3xvUO2QhsC+xNyhhkSQlEujO5rqV1v9eFCgQkorcqnjIm9T8 X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2320; 6:9brmXPPvemYG22e+VGO05wARId48sjU55CpqZpFbclhDojV28dnuCQhEhSkyFyhUXI1/g1mZaN31/8QVCLGzfYN147N6a8LlNJlyLpWNRNtFmsoiMM0ofmSiP2HLxR6yeAwBmPh7MSKeH8R3VZ9a73dxOaBTAROpoWkhJFIiDSxsYJoZXxuGAD7Jfog+BbQCTzF2Jp3oKhhjJ5ELHd3/et3ZXWhCa3eMe3jNy+CGK+OFj+lwCF5rCP73P+UXxg9/Lk527VaGpZJ+e5WGpV6lb2g1pjnbZH77h3p8v+VFsWrjHTxumPQX5qAiyn1wfBvVtkwxKhkFkQ/XcWxRRN3HcUsLq/qK+LLbwpKuJhxz+BZgxTh2V5YhBPBuGN5lGgEQfEx2wUl+YTXXoHNLCyqoHONPzg5610zM86YBBRzgNpTIdUAKeadwHSodgNHBPrJAvnFLRnSbsg+MM38AtbFaJA==; 5:BYmu6DPs+8xi8xaOvHdoT6hUTM0qdmmBS64XspXIa70V8x5odf2Jhacedn81FmEVFFThQhKEukSizqI6VihewHS7a+AREcaNa18Nq8JoWyy7VPFExGzZ7ZZWqTj8O8/5FUJiu+KNWn7uzhn+W5X9EM+yH0C1qn8zJKG1GzkwYgM=; 24:1mZDbiYL7sDw+VGc0/lCNi199zhuv9Q3HCthhAWWKeXAv3D9ds6SjScJ7OYN7AeVr0zZHnXXdml+Rj/TI0iSAjyBy4UEY+NE2ov+MS3TTOc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2320; 7:ESjnOUF+GjPQHY9FnnUe1HvGAZo9xGzUJ/lG+P5GR23wY4BH2gMDQ7Mg9Ar1cRuwwigBXLD6DH64hSkN28efQylsw6tY5OKOCFlSPavUSL/MuiqrvjVjeIsMcqVE7sAVeuXxaw5YatP1dnjlE/4l/ep8+qIHABKRGyIKI00+y31UcJK33IU7jFfrr1ch3AcvFzSryPq26if60nbS20LwDhRFazp513lERNtmObc12rgdT7rhDd7hg1KfRQai2G+k X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2018 07:19:52.1270 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ec011615-bf0b-473c-a707-08d59eb3742b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2320 Subject: [dpdk-stable] [PATCH v1] net/vdev_netvsc: fix creating short name devices X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 07:19:54 -0000 Prior to this commit the vdev_netvsc PMD was creating tap and failsafe devices with long names, such as "net_tap_net_vdev_netvsc0" or "net_failsafe_net_vdev_netvsc0". Long names containing more than 32 characters may be rejected by some APIs (e.g. membuf pool creation). This commits fixes this issue by creating tap and failsafe devices with short names such as "tap_net_vsc0" or "net_failsafe_vsc0". Fixes: e7dc5d7becc5 ("net/vdev_netvsc: implement core functionality") Cc: stable@dpdk.org Signed-off-by: Ophir Munk --- drivers/net/vdev_netvsc/vdev_netvsc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c index db0080a..bb2f78d 100644 --- a/drivers/net/vdev_netvsc/vdev_netvsc.c +++ b/drivers/net/vdev_netvsc/vdev_netvsc.c @@ -614,13 +614,13 @@ vdev_netvsc_netvsc_probe(const struct if_nameindex *iface, name, ctx->id); if (ret == -1 || (size_t)ret >= sizeof(ctx->name)) ++i; - ret = snprintf(ctx->devname, sizeof(ctx->devname), "net_failsafe_%s", - ctx->name); + ret = snprintf(ctx->devname, sizeof(ctx->devname), "net_failsafe_vsc%u", + ctx->id); if (ret == -1 || (size_t)ret >= sizeof(ctx->devname)) ++i; ret = snprintf(ctx->devargs, sizeof(ctx->devargs), - "fd(%d),dev(net_tap_%s,remote=%s)", - ctx->pipe[0], ctx->name, ctx->if_name); + "fd(%d),dev(net_tap_vsc%u,remote=%s)", + ctx->pipe[0], ctx->id, ctx->if_name); if (ret == -1 || (size_t)ret >= sizeof(ctx->devargs)) ++i; if (i) { -- 2.7.4