From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10043.outbound.protection.outlook.com [40.107.1.43]) by dpdk.org (Postfix) with ESMTP id 9DFB52B9C for ; Sun, 22 Apr 2018 16:15:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=zSRLOnZsPstHdnw44IEew0NBVXbvScYDpCE99QPxKBE=; b=N43CI3BDhGYy22LqRcZbZQUSIJB/075oBav6PAIyCaJhv5Q2b4QqodyRQKWOrTeBToo+Q3G/EqicOmTMV7JbTTEiHTbKI0pjkmUdhta3AmWapNv1avtkFy2hMTC38laMCQweaqq/Vfjx0HkpfunUr7G2mis6COvpbRVwhGO1OyA= Authentication-Results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; Received: from mellanox.com (37.142.13.130) by HE1PR0501MB2314.eurprd05.prod.outlook.com (2603:10a6:3:27::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.675.14; Sun, 22 Apr 2018 14:15:43 +0000 From: Ophir Munk To: Ophir Munk Cc: stable@dpdk.org Date: Sun, 22 Apr 2018 14:15:34 +0000 Message-Id: <1524406534-28876-1-git-send-email-ophirmu@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: PR2P264CA0019.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::31) To HE1PR0501MB2314.eurprd05.prod.outlook.com (2603:10a6:3:27::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2314; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2314; 3:wFi8z2qcGeOU+JcY4in7crr+9KJigcmg5pQR6E+XGoizF1HwdobJNV8CtTzUuV8SJNvPjWLLAsfkcUhxwkL4/x/bCliyNW6dgijzZ+tUsKWkBIklT2Acet8tCi+o6e0Ikq/gjOtABmm+fPzs1rBIN1D8/wcOA+tx0o7zKmZkgPX+L6xiHyKVaepqUZ4bOUc42BJyoYs4y9ir1QiGplbZTFmNk7nMHS0lTVHedcJ4A9pIEuO0Uyj3OUojjgCboryv; 25:KJ3yYOiYp3MpoY7hAc9a5TIOevcCE9cV/N0fBdCJCTVMxu3oZtFd1IRKr7OhE1zBbVRTR376eKiFFZQSlCoBnZEsDOfs9Bfjwc7E3Qup1TO3fag7f46JWudExPm5iTMQwt7Rqy/78JrL05bMzoSXT1lc/oc4zUOZhWCHlf633MwerFzbh8NndR0wluaQAOkyyo1CZ5PEf/X+arr+TpLeCdIAetOCP3TwkrapLWNXXoQ9GojhS5nMoLMznhCYSWm/UM3xDXlF5t7zHyg7PiisfgqsnStFnxWL0Ky4K0Lo/S9QEY8Lx+o2kQWYz2mhGiGkh8FPZqtLMpFgSn2r6VDaKQ==; 31:sRPvXlWozDgEVxRphpQW3XhZk8MBAtt/2/L6XKB2+W1eRnA5jKWT20fmn4mdHEBoZjlDeygRvyVuwWfg2QYRd2pxefUbNmPc+lpXpOkGYnsYml0gzj1Gkiwii9qZMYaOR2v7q+AXCZLrbeTr5luq2wNe1ZH8L/qL0KPpsXGqFydF97OMUgSA0FzyfuWXfoLZIS/odKrkT2ziLNU83zTKeVvRs6bM4i2U1C7vBh3uYWo= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2314: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2314; 20:BS8b/dn6JRXha8FQwAMOjaWmoX74FpKMWS6+aJKwS+20HWgNZIXsiViQsAUEMw5D6KZCJ6ZV3JS8SvhsPDr/gai+Nqp1FY4/v8TXasElBquIgCOJr1YScCPhHdginh5+Upg67Pn88cvBHKylUtCO0JZydNrc9Tndszt0d7BQJUrZtICpA/F3vBForm+giPP7dDMN48QZwDWssJa01JXoY1Edu0zph3OhXXIbmU7IQ7gH7cndhF0YN0BCGdfNRiWCHsuw560aNDYGg1TEvfZmxrvVtcRfAKgCxcZxxvRdMI0VLSwsXqWyyyLqkijs5OFB1hvVhMUy+Whrl0yO23EtQnZrFqp5rcrm0wnj40DM3DTlqJZ/fXjvVnfMFg0jYq+FmjXeL4Lnc196nUxWmCKKjSGEEC58ZQKaWR77sK7kMOcsLSMz1NczzfhrTIGgn4Ww1uuxLFSeuR3/FchCy+njh5b5t1+n1DSnGvU+4XRMP//KH0X64JnjVYt5Zi/5QRD0; 4:cele4Wh58hnXd/GeK79sRCAzvAlUHrY1pN22Lrv7ansM2jftgSY9sVFfw/C/Zpyip46TIu4mRY2ROsADr0iYF5zCFg/GfaCkjiBSnS9cqz4xcH7Wbd+DidBnhPQeV046f2FK1RZkZ9ZUBKHNV9aKmFKxREcTQzN0AEmaMgWfrUBYYu8CO9Zv8dnZGqHoEGMAfNFzuwRD/YswmicVAGfdKaaxLnWzMTowG8BICnYwr7iayGSywaORvFWZ7dvTHZF713TdsNCynJiS/0aFTVokrg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231232)(944501410)(52105095)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(6072148)(201708071742011); SRVR:HE1PR0501MB2314; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2314; X-Forefront-PRVS: 0650714AAA X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(346002)(366004)(39380400002)(39860400002)(396003)(8936002)(50226002)(52116002)(2906002)(8676002)(81166006)(7696005)(33026002)(5660300001)(316002)(16526019)(36756003)(50466002)(26005)(48376002)(2616005)(956004)(25786009)(4326008)(476003)(6116002)(6862004)(37006003)(7736002)(478600001)(86362001)(3846002)(59450400001)(55016002)(53936002)(305945005)(16586007)(386003)(4720700003)(6200100001)(6666003)(66066001)(47776003); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2314; H:mellanox.com; FPR:; SPF:None; LANG:en; MLV:sfv; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0501MB2314; 23:+gfhDIzxf+7xcLBiODZUgR6PjIWWFUnWmJ4/l1c?= =?us-ascii?Q?zzRs3C3r+s+unSzD/+fKYN+cGW2Z7lONlCJwxtwl4CUqF4d1Du8eQ4vfGUvo?= =?us-ascii?Q?z2AmDjV/Iy8rdCClOW1iAjNR5CZ59J4CLELhUstxWR3RGYGDrGyAgZ72Q5eH?= =?us-ascii?Q?E6asHvZOtTCi5WD9StYiNHqau+fHwHySe4PL1jZf7IbbmRwB/qv3BZ5450Zb?= =?us-ascii?Q?mBNnHkQCgFyGANuiz4PfYPd/3TdxmF6HPwVtEyeb3M065Qi4bMPN+fTmzQbH?= =?us-ascii?Q?/gJwv7pwpptzDCdHQLlGM7AHZAJ2HfBTW4RSa66E8Ek+pv0gHkNOrrwUBu3h?= =?us-ascii?Q?KyCBHgwbPRrw45JXr6vIDgyI3c04sPcDLq0ysGQzFxN1qUnoyEqqj05TSmS3?= =?us-ascii?Q?KU0afkLf/H5R4zFZdq2SsQa3TowVs65z01cVc49YIZYv3JHaTBGDzVSlGdCL?= =?us-ascii?Q?aUJ+s8RORuFaT7XxvZltB2tQImfhPH45LvGvAmtlO7BB2c0NWvfHgDBNBi/U?= =?us-ascii?Q?T0PDkpD5KyBr7IKJSHnFyrXz4bpnQikcr75YQF70L35zlmIorabnx6/pReoa?= =?us-ascii?Q?qcom5FmFdJeW2HP117OGA0wBErndQcQ8q2yuxPkpNZpypAXl4/kn/BXyQsex?= =?us-ascii?Q?mNJgjtYgEMeEIC9SPTDin2IAkrDYJqaO0d782LooIRnDZYDXRVFYvgLCljEf?= =?us-ascii?Q?HHtzop9lz3V4zGtXp6DNiwLicB+ZGv8SJYsvga/+cDoqsYl4Lwa0tEXyHgT8?= =?us-ascii?Q?JhoxoM+NLLlc2ISF93JoP0K3gFH2t3WJmt5Rmo+itHR6wO31oHNp/YWXWIK3?= =?us-ascii?Q?Xw127ragjs1nS/DGeDREnM6KP2kmzg93HgHcLmJoJwBsjYyDYAMnflzfwu1n?= =?us-ascii?Q?oMjbTQ4vjVr06D1l8Fp59BX+9gRMVc9yobmZgylB7Jbx/BBAMP8YB++BNNWd?= =?us-ascii?Q?LTIteSVwluwaa9IBvOpSZDveXiJ/+RAaAU6zjx4KgxzLTyV5lC/Ywg1v7fhg?= =?us-ascii?Q?NiEqqBtBz8h6YhEaZ24IAZE8OMt3Vgiaw0la3SMLhn4o7jw=3D=3D?= X-Microsoft-Antispam-Message-Info: LfjEXVyclAwZZZjC/UYb74SYowQ8U7wOuvUbKJpIr5uIpjfw+iJeN7xJwy/sSVj4tksK5DTNhGjzdWRGH52gZNbLVCyrDuueU0ngrE8XHTy5ozmUMd0+CBtoMu4T76HdWJDLIw+4kXmM+ax1Vom2rH5tD4BVA+8a6ZGYHEfusvuSbBUNQNw95pJdYXUJwfzM X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2314; 6:nLKcC8Kkwv4f317bErJ9L8NwOeBGdw6X/rvYvaW/KKNKZDyPaUGxi8/i4zyuvPMSei3mFEZnFCk1drH7h+shcyvYJ3slJwQ0rBzf9ro2zAXwgx36CRPjhCHmJXSAFpgDv/79Tr8xJVSzQiyIkSo7zNvosr7L5MmkHvrIwMDa/DtXRUknbH9epIcUdQCtnS1mOoY0MA7F5JhqFXLDz01suXd20yY2RssJ6qVE3XMFTs12Qt56IdghDs04fMIpPB49M5tUjZddvxmMtj1ciXAuM1OEoDibYr45dK8n5We/JjKNZXWZiaoSgu6PtAz/ppJkMNCKAXRz7P5yY8tjOB7qp3SlP0uAUzK9A1UdJyfiadE7lNZzxxfJi6v2KXXdfn7vxqtKWBGwDgIPXFirH3hR+JFU5Cavk4+SKsmmk88A80j5YnYvA8Aj0xjJNw8XxXXpqIz2WD3ajobjms/z/mwlPw==; 5:6QYqHNhuEp+GcRDWwU5WaGl4kgqc5UNOY9mYueSPIOkySMKh5hnpJ5zNDOOEUHGx99sDXEDi7mjqDUJKgghJ98AMz7XyVSRypS9cFEbqZ8TPNLuL1n8HOglKSEoigpCPzaLGXI0CLBPNYNUGQo1Ha4ytDwO25uHDXavQiWD1Uys=; 24:uqNcbHcw85H6FbBVrTERXxuxa0KfBaMR6xU3p3KJBLfLqSMw5ZkAIZlIYqbxIEZHVRA1byUEXLN8Ubv3qjqpHaGwYEQ3i5Ft4UYOOjq1tiA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2314; 7:9Leq91Ue3SabBvHd9tlOuLDUggF8Q90NYLAcfRgEv4cFTbeht/4Fxh1AQXuF5g6p5xTDexfyrDBmAT8xvS3vqlNwToAPVXiMTqQjExiergbXkbFCWOad2gzVMc/wzgB26wnU/O/KUHBHd2BrRDI+eI68t+LMs3n8yDm3LzZLIf9OiDfHqf+NkO5cT0BYToLuQ9Pm8cIJ4al5Tj8ZYuJKlBJBizTFNMm5as5FohxR77uQm1i1YVaCOdP31KDQRjR9 X-MS-Office365-Filtering-Correlation-Id: 65804c31-cbc8-4851-9457-08d5a85b892e X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2018 14:15:43.3877 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 65804c31-cbc8-4851-9457-08d5a85b892e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2314 Subject: [dpdk-stable] [PATCH v1] gso: fix marking TCP checksum flag in TCP segments X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Apr 2018 14:15:45 -0000 Large TCP packets which are marked with PKT_TX_TCP_SEG flag are segmented and the flag is cleared in the resulting segments, however, the segments checksum is not updated. It is therefore required to set PKT_TX_TCP_CKSUM flag in each TCP segment in order to mark for the sending driver the need to calculate the TCP checksum before transmitting the segment. Fixes: 119583797b6a ("gso: support TCP/IPv4 GSO") Cc: stable@dpdk.org Signed-off-by: Ophir Munk --- lib/librte_gso/rte_gso.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_gso/rte_gso.c b/lib/librte_gso/rte_gso.c index a44e3d4..e9ce9ce 100644 --- a/lib/librte_gso/rte_gso.c +++ b/lib/librte_gso/rte_gso.c @@ -50,12 +50,14 @@ rte_gso_segment(struct rte_mbuf *pkt, ((IS_IPV4_GRE_TCP4(pkt->ol_flags) && (gso_ctx->gso_types & DEV_TX_OFFLOAD_GRE_TNL_TSO)))) { pkt->ol_flags &= (~PKT_TX_TCP_SEG); + pkt->ol_flags |= PKT_TX_TCP_CKSUM; ret = gso_tunnel_tcp4_segment(pkt, gso_size, ipid_delta, direct_pool, indirect_pool, pkts_out, nb_pkts_out); } else if (IS_IPV4_TCP(pkt->ol_flags) && (gso_ctx->gso_types & DEV_TX_OFFLOAD_TCP_TSO)) { pkt->ol_flags &= (~PKT_TX_TCP_SEG); + pkt->ol_flags |= PKT_TX_TCP_CKSUM; ret = gso_tcp4_segment(pkt, gso_size, ipid_delta, direct_pool, indirect_pool, pkts_out, nb_pkts_out); -- 2.7.4