From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10058.outbound.protection.outlook.com [40.107.1.58]) by dpdk.org (Postfix) with ESMTP id 89E9E1E35 for ; Sun, 22 Apr 2018 16:19:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+vszY+9a0O/3UQDYshZJrspDNAB4eQilW8Ea3ppDcug=; b=gxOP8NRfOpqtk2afhHRcbJ2bHBQMXMxlwewFuK7Nu+UhFKm5Dr+fVLkHI3a1+SbWcE9XXBRndL8E3ObLeHJD7wM5LbN6JR8MsTFiBubg/cmLWMmx1P8HRgYXvRdGW/+Dx+8hwRPADtD7dPcWSLyHrqzWusw+W+nDcHgvnnw5fCQ= Authentication-Results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; Received: from mellanox.com (37.142.13.130) by HE1PR0501MB2314.eurprd05.prod.outlook.com (2603:10a6:3:27::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.675.14; Sun, 22 Apr 2018 14:19:48 +0000 From: Ophir Munk To: Ophir Munk Cc: stable@dpdk.org Date: Sun, 22 Apr 2018 14:19:35 +0000 Message-Id: <1524406775-29471-1-git-send-email-ophirmu@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR0601CA0016.eurprd06.prod.outlook.com (2603:10a6:800:1e::26) To HE1PR0501MB2314.eurprd05.prod.outlook.com (2603:10a6:3:27::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2314; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2314; 3:RH2KaI4AeemVCTRlmyrkdAuzDbXiXHk+DIqqlr9ca+egLhD1ScXuRL3ssb2qlSJ8ELc17G495/9vYrlp6sNloscZcM6m+cPS1ZLw76+AzFPSa6blJoijexOEo8sLvBE95Ljz0OuP7LFYInjeugw383xSpgGr3Q6rkExK8Q9glJAtAftMsKo9r/WFZ1WRh7fv9N0xlS0ryCnEHshnZPfA1398CKDejIMik3tkHsc3WbHpCyZJ/5o+2Qv9sOMZBC5v; 25:Si92oueQ+wcip0sfHDkdYBWZWYiEFFExK86q0r+/nwZ0qazTCwEKauM4ijNPuMCfYGks/ugvGkRei9dkMlyM+Cym9dj3O0SE9sQfFsOxuNoY4SbVaKRk1KPA1qBUgzrTto2AAotBbYpB9ePrvRA7op3t0S7M0WqxvMLjPmySA5HPULp0LP2B70YbVt9Lzv5yhexw+r0bP06hFBrbq4vO0kPX+fOYoJ/4J8PN4uBkMWItf6qYhKbvxjTMxGbeCNynjqC0V6ZhLdBHfyFAnhXKvL4T6tdORCMyenYX3nUt18wZhiPmWkrFlgnvX5NwOodbqr3oE9l9zivdsCMe70d8dg==; 31:4Fug9mfwZ+LKcycewJ7qt9cA3cd4CAxlKn6fXl9a3ZcbMF45BUFtqZ9mRqMwbR02uTxPtLYRwywR+I8usSmHN6xuGTKn0140nuXnf1ZVpFEotZGnP31XKCV4CjemMc8A7+ggSons8NYR4bg8fE5+gztAD+Hcr6mNePYB6UlRXqTEH004avk+sWoWWzaceDSrdBp/JS+Wf1ylh9dmEYEbu1eyLuuhbeDPOp3KZwDtO4Y= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2314: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2314; 20:in1xbK6hnKe+PBnNuPtCYKjfh2YNNiOWRl74Zkl8xs3Pk8BdX+w5cS81cxGXBQ7whhxi7saTIxWywQ4JzRQLoKzt5SJeuapX/Ax4HDWTt9VxnRAaSyq+SUAzMPA3zq6cYggXpKS1S5fpeRQ8V3CMckE6LtRkf+PL3a0QlaT/mVQ2h9POeOQ/M02WKMHiC8nJgNxaOigOtJX4n5zlzzwry3/foClHvQ5/87ziIEdv4IZVFbKVk4PDvwC2GjhUp0KEB/lM6ZlJmY60xDc8bzmWXoX6jYG25pB9i/RmBYd3/CKoh4S/UzE9N22/VCMT9Azsx/UnuB56LvTgxXZ0O4JkLgkVLVWj+K+8cEpRIygGfCRuT0ZtpMwVb/WYIAKu1+Uf71h+H5x8qPUHQLQEIjhTvVJuY7qQkGRb9S0bY0PnwfjE+HYrj5HA8e9qGlzdU2i/3mCb5dIGCY8WCf4NPxM2A9t7FjDmCX1SOY9+CXvq+DuTHVnJmz0cdNhbpkAyl5d0; 4:GG1/0DIMgWP136KRVwG0sbn9pTkuKBnlhitpx/YhxYFPmLBlIzHowrKEPsiDD2soauSN6P87PaIA0dycGwfccfpSm/sUNwGui7Ed84YZiIgizI9oVbtUmammMasNXNhk61UhmOCb902hA0inFtewKShvxbutwtSk1ByZa3k4wIH8TTc0hfB4wRK7HRZuacx2mbjVGd7eoDiDHKPYix1l0ZERFce7YyL6wSl84im0HDSxTVKOkoacuN4xe2R8xtgstrWxJbaRiW1hny0f0hnD6g== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231232)(944501410)(52105095)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(6072148)(201708071742011); SRVR:HE1PR0501MB2314; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2314; X-Forefront-PRVS: 0650714AAA X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(346002)(366004)(39380400002)(39860400002)(396003)(8936002)(50226002)(52116002)(2906002)(8676002)(81166006)(7696005)(33026002)(5660300001)(316002)(16526019)(36756003)(50466002)(26005)(48376002)(2616005)(956004)(25786009)(4326008)(476003)(6116002)(6862004)(37006003)(7736002)(478600001)(86362001)(3846002)(59450400001)(55016002)(53936002)(305945005)(16586007)(386003)(4720700003)(6200100001)(6666003)(66066001)(47776003); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2314; H:mellanox.com; FPR:; SPF:None; LANG:en; MLV:sfv; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0501MB2314; 23:XlInODKji7vV2lIR4nnD/3X7S93h7hcXNnNbrTn?= =?us-ascii?Q?q2xRTuxYhkEEkwwewG9PdtForZBoY2b1Jgmx8V6KteHN+B90Fyklo85hyMwi?= =?us-ascii?Q?HhQRdhc5QMf0cOS7jq3VvsbIFFwEvTRnDWdfoKk0wvyLuKYpZWp1mvSdTNIG?= =?us-ascii?Q?Ut+HlPxxMgRUyYqGTvGpgccmCrb0DKD7xkCQ4iF7BMso6V8cut6WUuqAUac6?= =?us-ascii?Q?8vToXq6W3ZtwOfKLxYM5f6zAYO0AIdmFhdkxTke3Z8zKjBWGTTzm7qF/kvUG?= =?us-ascii?Q?uJ4xIAFbQX1HFhwcT5efPo9rGRLJP6reAfnMRx0DMTezYu1f7ltQTSB6su6P?= =?us-ascii?Q?KY0xnqZWNVI2YcLg0rTr1Y6KjijZs22Cp6YV/AmArqpCGvOFxP9fbnLoHdTk?= =?us-ascii?Q?QnUCtpA8WWetTjvOpeGstDx9ChUAzFwIgip6+vG51lsHAXgWMe9nTW5TnQNI?= =?us-ascii?Q?2dgclM7zQeFdDZN+Lp269zWUF5xwhmpN4+v/llB7H/ezf6N63jqfeT34Q2Pw?= =?us-ascii?Q?Mt0khc2PRZnzM9DiHszoQFJDRwjnnVGbUNQXjrHXebVsoP27TKo+JeJdtRG/?= =?us-ascii?Q?HGLVjCHk//bwFntDfV0i1q6RY/wvyeDltO2Ihy9IYNossnwzEiFixrjj2EHl?= =?us-ascii?Q?EmhWZSC4Zr3MnmT2XaT8PXRyTOxYbVg9Ncj//TqaXx/eQtcD/qrHtSqPAsyE?= =?us-ascii?Q?Ke/oEnrFFZzkFnI737Jhyijs3WDPLbLawTHuXaQFHfh7/0DA2hnmxbFdTY1a?= =?us-ascii?Q?1hmgsi4Hip2Kbo0L+F59xsg4CGv+1TxjdqYMGp9hHWal3d+0KED+Moz247Mb?= =?us-ascii?Q?OuK1uA2ib1W6JWI1YB/b3RigIn0+bfLy94tdtF1tJEqEzf7GXmJL43JkYAcM?= =?us-ascii?Q?26AYVYdl2QL1VRu7WBRFojMDbDO4i3WiftEkyYV9s2Og5XhOXNUzg9QycVUN?= =?us-ascii?Q?mURb+RGZAgbGlM19ZRWW/Q3LSUuoRQeMvcLUBimse4Z5WxE79zLYphcJPaEd?= =?us-ascii?Q?FlmMv7djNaoh+phgUBVjAf19+h1PIda2aNK7fCs9ovY9kYw=3D=3D?= X-Microsoft-Antispam-Message-Info: mOAoZ4mV1ipwZTnopQ5NT4T8nNPDozYbHFD0ykJqX3b7HUMOzHiSXqD42ynOSRnLxPdM/Gdqh+SYtHEiy+V+jshgkilRonqikxqZCCxdSSQX20Esqmi2AVQM/VX1mGGe4Cnq5IZSGY2RuBNAOcED35VA2gGSjhrxeIa8Zod7t6Bmb8lKA6Gv0O6IQHDEnCdw X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2314; 6:Lm/fHkdULX/C7lc7Cym0Vt8bveKnMYT3iGiz1Z5sjQ1etaEzA5riBf7veaq8BJtukgrRFr7N4Xdl29AkKoSMvu09li0rXbKo/2iqXdr+3Jac3NyyzWoFigCKKQq+NaeDMhKXe/IHY0b0XHzdwfRM2ejXpRlU7bhjqH4750Z2zk3KKi7upHqmpx6BMdZQnZqrI2FQer98GkopbKAk5e4MQ4pZUhfNmOxa3KKv6r0oRQXN7i6lh7KHPr4HMLvGFlNuQt97F1Li9GRk4ZHPqfuUglrN125RNb4lQ5gBv8unFMlzT7n/yj851f2aclZJx5OkdsOKWOnPquahjXAY0ux6+hZD08tP6BDDjinR2S3Ui0iYGMbJfGmPdR9y5axmKFq7zK4Gef4swGVD2kZFNUtA7tTJ4KCpyPdZcJn7Zze1dENeS495Hoqgk0FaNjUUHSVUlVdgxmEldqiLEZeDPfb4yw==; 5:yPa+BjlfOPIQxelyEzBVKzXyF8Kj274Yiphdbo3jmUlc2JFQpv4JSW4jvoRDDt56Ufu03ZaJG7NmrgytDqTjCtb6z/d7K5eBXt69QAY/b+dOUcITHxBNEeEAsFq2kSOgvYsKMvRmQ0huqI2eY+AEqj/3tH63vRUjxJ0JY4IT6Dw=; 24:swY9kq+ZNnonEZBA5NM7Ua71KL24G1rJYaORuXmQ8rm6MDwuu0BjgQroDJXob1+y53ck4g0GjFe9t0SYPiePqJxPuNla8qX2FlnNkWmgGFA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2314; 7:2fe4MMkzRzqSoE5WTKGU05JzUvZUBLYO+Ex011FwrEFiCn/5syhy8jT360vQIoY7PcUrsxw/R9JP3qMY+h5hxzR2ifvE/LobAeTuK/p26IUrGv2UbCi5qYlbKfTQEruAciaOGMfPsQLfYeP2yfbDc53gsU6U0L1l8eZsXtozkXSNmTyHD3J2fhWkDQcglXnOtCpFQHBqoQBklcGLBbq2NdAL9N5896z3DATiGGpxCJ0Tge0c0fEupmoWA8JlA1EW X-MS-Office365-Filtering-Correlation-Id: 9295f7ba-c183-4222-2847-08d5a85c1b45 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2018 14:19:48.4986 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9295f7ba-c183-4222-2847-08d5a85c1b45 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2314 Subject: [dpdk-stable] [PATCH v1] gso: fix marking TCP checksum flag in TCP segments X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Apr 2018 14:19:50 -0000 Large TCP packets which are marked with PKT_TX_TCP_SEG flag are segmented and the flag is cleared in the resulting segments, however, the segments checksum is not updated. It is therefore required to set the PKT_TX_TCP_CKSUM flag in each TCP segment in order to mark for the sending driver the need to update the TCP checksum before transmitting the segment. Fixes: 119583797b6a ("gso: support TCP/IPv4 GSO") Cc: stable@dpdk.org Signed-off-by: Ophir Munk --- lib/librte_gso/rte_gso.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_gso/rte_gso.c b/lib/librte_gso/rte_gso.c index a44e3d4..e9ce9ce 100644 --- a/lib/librte_gso/rte_gso.c +++ b/lib/librte_gso/rte_gso.c @@ -50,12 +50,14 @@ rte_gso_segment(struct rte_mbuf *pkt, ((IS_IPV4_GRE_TCP4(pkt->ol_flags) && (gso_ctx->gso_types & DEV_TX_OFFLOAD_GRE_TNL_TSO)))) { pkt->ol_flags &= (~PKT_TX_TCP_SEG); + pkt->ol_flags |= PKT_TX_TCP_CKSUM; ret = gso_tunnel_tcp4_segment(pkt, gso_size, ipid_delta, direct_pool, indirect_pool, pkts_out, nb_pkts_out); } else if (IS_IPV4_TCP(pkt->ol_flags) && (gso_ctx->gso_types & DEV_TX_OFFLOAD_TCP_TSO)) { pkt->ol_flags &= (~PKT_TX_TCP_SEG); + pkt->ol_flags |= PKT_TX_TCP_CKSUM; ret = gso_tcp4_segment(pkt, gso_size, ipid_delta, direct_pool, indirect_pool, pkts_out, nb_pkts_out); -- 2.7.4