From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id AECDBE07 for ; Mon, 30 Apr 2018 15:43:28 +0200 (CEST) Received: by mail-wm0-f50.google.com with SMTP id f6so13260895wmc.4 for ; Mon, 30 Apr 2018 06:43:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=Agldtr50teJAWjooGCyWcitZA5TWIiSl2JmMmlFtULk=; b=WZA+BL7y05EVZDUTOUlCyhQMPydp0QpzDy+igL1Mji7k70XxfgaD7SxWwB+VsNbbw8 BdSpBoimL2jLoirw+hYMbOPkg3UPUF2YkfeLW3CzeZEXgDMbFHOBvHcQfTT5BMHLvDQr A4p/eGlUWwYcFiU7+KmEfbBhVnXOldsacRh2m/YdqQk8QPcTNSf0a44lS83AhHDg3N+7 9wdMi8zuHCAhsMTsiXmlu6XdaaQGjLPg9OpL9VnGzZwzwkAZwDx0eyo9dBA82FdM2b1J Um1bOiDoGy+tl8+ZfYN3AvlbsdqeC3gZuaIh4v/ivHEQ7TImiIzGKT+hLWcENSJCKlrn uCyQ== X-Gm-Message-State: ALQs6tAL/YWm5QRvf7odzsEDKh0ewCvoI1WaD54G0wClQsc+l2nXfqxe bWgbcj7zfzA0ZomHpMmmQoU= X-Google-Smtp-Source: AB8JxZpoZiw8xEWVH48TQXlwf6+WQd8BAAysqhtZq1Am8Rt4kJKfXysAppdsIG20QDO92oKH6///VQ== X-Received: by 10.28.54.141 with SMTP id y13mr7532961wmh.126.1525095808408; Mon, 30 Apr 2018 06:43:28 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id q2-v6sm9310234wrj.57.2018.04.30.06.43.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 06:43:27 -0700 (PDT) Message-ID: <1525095806.23337.20.camel@debian.org> From: Luca Boccassi To: Rosen Xu Cc: stable@dpdk.org Date: Mon, 30 Apr 2018 14:43:26 +0100 In-Reply-To: <1524915445-96710-1-git-send-email-rosen.xu@intel.com> References: <1521090873-50595-1-git-send-email-rosen.xu@intel.com> <1524915445-96710-1-git-send-email-rosen.xu@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH v5] net/i40e: fix disabling promiscuous mode X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 13:43:28 -0000 On Sat, 2018-04-28 at 19:37 +0800, Rosen Xu wrote: > v5 updates: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =C2=A0- Modificate some comments for this patch >=20 > v4 updates: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =C2=A0- Add some comments for this patch >=20 > v3 updates: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =C2=A0- Move modification from device close to device disable > =C2=A0- i40evf_reset_vf() will cause kernel driver enable all vlan > promiscuous, > =C2=A0=C2=A0=C2=A0so unicast/multicast promiscuous disable should set bef= ore reset. >=20 > v2 updates: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =C2=A0- Add more comments >=20 > In scenario of Kernel Driver runs on PF and PMD runs on VF, PMD exit > doesn't disable promiscuous mode, this will cause vlan filter set by > Kernel Driver will not take effect. >=20 > This patch will fix it, add promiscuous disable at device disable. >=20 > Fixes: 4861cde46116 ("i40e: new poll mode driver") > Cc: stable@dpdk.org >=20 > Signed-off-by: Rosen Xu > Acked-by: Qi Zhang Has this or a version of this fix been committed to mainline? --=20 Kind regards, Luca Boccassi