From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 3949CF3E for ; Mon, 30 Apr 2018 15:44:45 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id n10so14281232wmc.1 for ; Mon, 30 Apr 2018 06:44:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=odzQGNHXCPOrYMT0zOIPwwGPXjOz8Ega2Qyrbs5s/TI=; b=YW5MJTrTs9l8Wanr31A+JJp7kGXMhfhx5OFLwjRsvTKbfqZV7v9VkLy8cUKMALJqXt XJ4s+sVko6g4lHzUxWASZ4vDzSM5C3GR2HLba4aorC8XwsDBjUEBuj4XNSB9SL/T0mLb 6oTh5J6OlwAw4YhFkDpKCPg4Yezef6lnH/jLj4KTYRRk76KQ4vYHzrfT5U7ick6FsWBS 60OBIphVoQFUSx+GMFnu+0slR573BZB3mmUxKVPufOnR12gySxVd4/AnSXPC84NJboHL nyZ+Y4oONVDNZja2bDN2b3BC515mvjhSvELKrNxBqQBAcdjl+vNIeB91NiFmnShvXYt/ xm4w== X-Gm-Message-State: ALQs6tA+N0su0f5BDDaly9lSu9BmrEtKnYtLSqls5EKam7D1nXzCV+Ij OoHdnlBjC0FJICCepzQzu9Q= X-Google-Smtp-Source: AB8JxZq1ErxUvxmjcsKG7YllP8DXxQiXDH2KJpBidGymZ+d84Y3kjv3a59cO+R3dz4Qvmz+SXFb3zQ== X-Received: by 10.28.170.84 with SMTP id t81mr7769985wme.130.1525095884834; Mon, 30 Apr 2018 06:44:44 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id w14sm7046647wmd.1.2018.04.30.06.44.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 06:44:44 -0700 (PDT) Message-ID: <1525095883.23337.21.camel@debian.org> From: Luca Boccassi To: xiangxia.m.yue@gmail.com, maxime.coquelin@redhat.com, jianfeng.tan@intel.com, yliu@fridaylinux.org Cc: stable@dpdk.org Date: Mon, 30 Apr 2018 14:44:43 +0100 In-Reply-To: <1524840538-3941-1-git-send-email-xiangxia.m.yue@gmail.com> References: <1524840538-3941-1-git-send-email-xiangxia.m.yue@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 1/3] vhost: fix deadlock due to vhostuser socket and fdset X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 13:44:45 -0000 On Fri, 2018-04-27 at 07:48 -0700, xiangxia.m.yue@gmail.com wrote: > From: Tonghao Zhang >=20 > When qemu close the unix socket fd of the vhostuser as a > server, and then immediately delete the vhostuser port on > openvswitch. There will be a deadlock. >=20 > A thread (fdset event thread):=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0B= thread: > 1. fdset_event_dispatch=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0rte_vhost_driver_unregister > 2. set the fd busy to 1.=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0lock vsocket->conn_mutex > 3. vhost_user_read_cb=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0fdset_del waits busy changed t= o > 0. > 4. vhost peer closed, remove the > =C2=A0=C2=A0=C2=A0conn from vsocket->conn_list: > =C2=A0=C2=A0=C2=A0lock vsocket->conn_mutex >=20 > 5. set the fd busy to 0 >=20 > Fixes: 65388b43 ("vhost: fix fd leaks for vhost-user server mode") > Cc: stable@dpdk.org > Cc: Yuanhan Liu > Signed-off-by: Tonghao Zhang Hi, has a version of this series been merged into mainline? --=20 Kind regards, Luca Boccassi