From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f174.google.com (mail-wr0-f174.google.com [209.85.128.174]) by dpdk.org (Postfix) with ESMTP id 7B9B61B19 for ; Mon, 30 Apr 2018 17:43:30 +0200 (CEST) Received: by mail-wr0-f174.google.com with SMTP id c14-v6so8475282wrd.4 for ; Mon, 30 Apr 2018 08:43:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=Z45TZQmP9jcxeNkuWx0hgAUm2EAXqcSpbk5Cpvo2yvM=; b=QOZ6L0A0PKgrTfEYyn0G0lz1nAhJu+vJMEmsUO9m0IxsW017MmTmP261H9yaCHK1Jo 9whiimxCHjiDETa8cFztX39IUCeUjcFIRD4v5kegjep8ZKWHHpSFDph6cd9uYp2Qpw4M lFxC1cFWMs0HWhodMyfIseu9/W/d01Krwq7SBozkntspzm9rWWNZmr7dJ210oz2Ip1Ms THze06uHlU3tC0B0xIdhhrhpMPjP92vAu3izXSEB6cZ4yMc3cwpUE5kvubzo/9XiM+bV n/Kz5scN23BwSr0KiZP/kTKr58krO3pqfn9J1vCr1CfxMK/icEFBe29387kIuQcBwXpU F4cg== X-Gm-Message-State: ALQs6tBwT7SBEvfu63wmNx/2MgwsbXhDfJxRHSUfyrq/Y7nVVhezoG9y GPxrRgKakf+0f0+gUByNM2IEU7ueewc= X-Google-Smtp-Source: AB8JxZr46fupr3gGJ6IB/EBCAGOwhYXtI1T/OhZ6ICCnMqw5ZZl91gRr0ogm0slpZKd53nmxTmltmg== X-Received: by 2002:adf:dfcc:: with SMTP id q12-v6mr9238938wrn.68.1525103009883; Mon, 30 Apr 2018 08:43:29 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id k3-v6sm11507428wri.28.2018.04.30.08.43.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 08:43:29 -0700 (PDT) Message-ID: <1525103008.23337.25.camel@debian.org> From: Luca Boccassi To: Thomas Monjalon Cc: dpdk stable Date: Mon, 30 Apr 2018 16:43:28 +0100 In-Reply-To: <12735445.Izu66BeJPl@xps> References: <20180430140606.4615-80-luca.boccassi@gmail.com> <20180430144223.18657-1-luca.boccassi@gmail.com> <20180430144223.18657-57-luca.boccassi@gmail.com> <12735445.Izu66BeJPl@xps> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-stable] patch 'fix ethdev ports enumeration' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 15:43:30 -0000 On Mon, 2018-04-30 at 17:07 +0200, Thomas Monjalon wrote: > 30/04/2018 16:41, luca.boccassi@gmail.com: > > Hi, > >=20 > > FYI, your patch has been queued to stable release 18.02.2 > >=20 > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable > > yet. > > It will be pushed if I get no objections before 05/02/18. So please > > shout if anyone has objections. >=20 > I did not plan to backport it. But yes, it may be a good idead. > In this case, you need to backport some fixes on top of it: > net/mvpp2: fix build > ethdev: remove experimental flag of ports enumeration Are you sure about those 2? The first one doesn't apply as there's no mvpp2 in 18.02, and the second one changes the API > > --- > > From beef7e18559abf272f9ca0a4d1b62f8d32c47b02 Mon Sep 17 00:00:00 > > 2001 > > From: Thomas Monjalon > > Date: Thu, 5 Apr 2018 17:33:20 +0200 > > Subject: [PATCH] fix ethdev ports enumeration > >=20 > > [ upstream commit 8728ccf37615904cf23fb8763895b05c9a3c6b0c ] > >=20 > > Some DPDK applications wrongly assume these requirements: > > =C2=A0=C2=A0=C2=A0=C2=A0- no hotplug, i.e. ports are never detached > > =C2=A0=C2=A0=C2=A0=C2=A0- all allocated ports are available to the appl= ication > >=20 > > Such application iterates over ports by its own mean. > > The most common pattern is to request the port count and > > assume ports with index in the range [0..count[ can be used. > >=20 > > There are three consequences when using such wrong design: > > =C2=A0=C2=A0=C2=A0=C2=A0- new ports having an index higher than the por= t count won't be > > seen > > =C2=A0=C2=A0=C2=A0=C2=A0- old ports being detached (RTE_ETH_DEV_UNUSED)= can be seen as > > ghosts > > =C2=A0=C2=A0=C2=A0=C2=A0- failsafe sub-devices (RTE_ETH_DEV_DEFERRED) w= ill be seen by > > the application > >=20 > > Such mistake will be less common with growing hotplug awareness. > > All applications and examples inside this repository - except > > testpmd - > > must be fixed to use the iterator RTE_ETH_FOREACH_DEV. > >=20 > > Signed-off-by: Thomas Monjalon >=20 >=20 >=20 --=20 Kind regards, Luca Boccassi