From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id DCB2B1E2F for ; Tue, 1 May 2018 15:52:20 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id l1so19187623wmb.2 for ; Tue, 01 May 2018 06:52:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=XNrP1YGsjqj4bG7G+nEUdyu7rRbVWAIyWZSEeo1fyrM=; b=qvDpNcLBw5CifgZgaDBSwDUvc+RmMl1w2beFsoUxwgF+ONsurIevtvCG4wHjkzEWLj irUo0J7vrlBLWNw9nnJHQLa2OdJCSYI0nulmmwMRcVcEKzWIbtI8zfCFqzJg+KP25DS+ rpsuzUnJctGxCyqsNa/+96hFBs9On/0VNzBEosggOifNxqbFDFuc86ciabPbsjnXMVl5 aDOU9ksaBPnS0eMsSeSvQRohyrCVtPb5x+tHbUsHFiqfjaQhvzLW0Pr5yl1cy1VCO0JK KoNRUBdJX32WEIlaqy1JBmgMiNAroOGBYRQ4J8ha6nuyNpJ+7aIpe17A5+WLu4WniaeC yqNQ== X-Gm-Message-State: ALQs6tBZQ/O+c26kd4NANxmzgLDlxQSpLkyp+2A1EjJKUgOym4XBNxys 1QdxsB2GHiwNWNiUQ5wdhlYa8OrAkn0= X-Google-Smtp-Source: AB8JxZrEtj5jQXlqXw0vG738/uQpFcbo40B218kqpPMmsaG6Vjm8oWR6NqPskL9CjdmZcYXWTtVIRg== X-Received: by 10.28.183.215 with SMTP id h206mr10478434wmf.2.1525182740500; Tue, 01 May 2018 06:52:20 -0700 (PDT) Received: from localhost (slip139-92-244-193.lon.uk.prserv.net. [139.92.244.193]) by smtp.gmail.com with ESMTPSA id a13-v6sm9234387wrc.19.2018.05.01.06.52.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 May 2018 06:52:19 -0700 (PDT) Message-ID: <1525182737.23337.36.camel@debian.org> From: Luca Boccassi To: "Xu, Rosen" Cc: "stable@dpdk.org" Date: Tue, 01 May 2018 14:52:17 +0100 In-Reply-To: <0E78D399C70DA940A335608C6ED296D739FA48F6@SHSMSX104.ccr.corp.intel.com> References: <1521090873-50595-1-git-send-email-rosen.xu@intel.com> <1524915445-96710-1-git-send-email-rosen.xu@intel.com> <1525095806.23337.20.camel@debian.org> <0E78D399C70DA940A335608C6ED296D739FA48F6@SHSMSX104.ccr.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH v5] net/i40e: fix disabling promiscuous mode X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2018 13:52:21 -0000 On Tue, 2018-05-01 at 13:27 +0000, Xu, Rosen wrote: > > -----Original Message----- > > From: Luca Boccassi [mailto:bluca@debian.org] > > Sent: Monday, April 30, 2018 21:43 > > To: Xu, Rosen > > Cc: stable@dpdk.org > > Subject: Re: [dpdk-stable] [PATCH v5] net/i40e: fix disabling > > promiscuous > > mode > >=20 > > On Sat, 2018-04-28 at 19:37 +0800, Rosen Xu wrote: > > > v5 updates: > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > =C2=A0- Modificate some comments for this patch > > >=20 > > > v4 updates: > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > =C2=A0- Add some comments for this patch > > >=20 > > > v3 updates: > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > =C2=A0- Move modification from device close to device disable > > > =C2=A0- i40evf_reset_vf() will cause kernel driver enable all vlan > > > promiscuous, > > > =C2=A0=C2=A0=C2=A0so unicast/multicast promiscuous disable should set= before > > > reset. > > >=20 > > > v2 updates: > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > =C2=A0- Add more comments > > >=20 > > > In scenario of Kernel Driver runs on PF and PMD runs on VF, PMD > > > exit > > > doesn't disable promiscuous mode, this will cause vlan filter set > > > by > > > Kernel Driver will not take effect. > > >=20 > > > This patch will fix it, add promiscuous disable at device > > > disable. > > >=20 > > > Fixes: 4861cde46116 ("i40e: new poll mode driver") > > > Cc: stable@dpdk.org > > >=20 > > > Signed-off-by: Rosen Xu > > > Acked-by: Qi Zhang > >=20 > > Has this or a version of this fix been committed to mainline? >=20 > I have submit the patch, the action of merging this patch is belongs > to maintainer. > Do you think so? Yes - the reason I ask is because the process we follow for the stable releases is to tag commits that are backported with the commit ID of the patch that was merged into dpdk/master, for tracking. And also, for patches that to into dpdk/master, we wait to merge until the version to dpdk/master is merged first. --=20 Kind regards, Luca Boccassi