From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 6746E23C for ; Wed, 2 May 2018 16:02:30 +0200 (CEST) Received: by mail-wm0-f49.google.com with SMTP id f6so23016306wmc.4 for ; Wed, 02 May 2018 07:02:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=wE6FjQGnhKThH/gf/g3TTOr00E3qcefZrqc6jaciAW4=; b=BvvSnUtkkQLhU++lhthcNOM5nfT39NmO06f9eGf99G941FZnv0uBRajjCAuMvSHkpB lZpVvYhR0Sy3EyP6yw920ueDFieUXm7JCNcj+LJOEQXIPGZ/C5BzoBVjys1S/M/Vj/S7 qTNzabHVIW6g0trJ08JMvDXpjBOxVopglyJNR22tTD6Ezg+Owm/A0eVazhV3U8na936v YE6McDOxXv2dOENAnc493cWyn5WAMt9v01VRNnv2sDCGj3Mn8o50IxeTbL4y4ezqc++L mH/3s124xd4i0+8FBR1rvc9CstULyZ1jaP3J2iD6PfENrDyAE/dBNyzt15q2wBeuL6xE EcYQ== X-Gm-Message-State: ALQs6tBYuogfkL6oUKBXDbWYLOmxPohTCRJBOaqUz/kXoXJXzNcpJDbe H1hK2sbD/SJF+8TBoSTMYPw= X-Google-Smtp-Source: AB8JxZqPgn0ayvvR4ic0WU6gu4YZLre0CeviPeANqmN5DwpxNOtJtGQ9DQHY3BG9xkbZlEyNhDJ5GQ== X-Received: by 10.28.85.201 with SMTP id j192mr14213098wmb.160.1525269749809; Wed, 02 May 2018 07:02:29 -0700 (PDT) Received: from localhost (slip139-92-244-193.lon.uk.prserv.net. [139.92.244.193]) by smtp.gmail.com with ESMTPSA id w5sm10223969wmd.26.2018.05.02.07.02.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 02 May 2018 07:02:28 -0700 (PDT) Message-ID: <1525269747.23337.45.camel@debian.org> From: Luca Boccassi To: =?ISO-8859-1?Q?Ga=EBtan?= Rivet Cc: dpdk stable Date: Wed, 02 May 2018 15:02:27 +0100 In-Reply-To: <20180502121645.cwdamjgmgwsfw5tw@bidouze.vm.6wind.com> References: <20180430144223.18657-85-luca.boccassi@gmail.com> <20180430145402.23057-1-luca.boccassi@gmail.com> <20180430145402.23057-2-luca.boccassi@gmail.com> <20180502082602.bqg4ctdkyyaom6g2@bidouze.vm.6wind.com> <1525258673.23337.40.camel@debian.org> <20180502121645.cwdamjgmgwsfw5tw@bidouze.vm.6wind.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-stable] patch 'bus/vdev: fix find device implementation' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2018 14:02:30 -0000 On Wed, 2018-05-02 at 14:16 +0200, Ga=C3=ABtan Rivet wrote: > On Wed, May 02, 2018 at 11:57:53AM +0100, Luca Boccassi wrote: > > On Wed, 2018-05-02 at 10:26 +0200, Ga=C3=ABtan Rivet wrote: > > > Hi Luca, > > >=20 > > > On Mon, Apr 30, 2018 at 03:53:21PM +0100, luca.boccassi@gmail.com > > > wrote: > > > > Hi, > > > >=20 > > > > FYI, your patch has been queued to stable release 18.02.2 > > > >=20 > > > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stabl > > > > e > > > > yet. > > > > It will be pushed if I get no objections before 05/02/18. So > > > > please > > > > shout if anyone has objections. > > >=20 > > > This patch will be bogus while still compiling in a stable > > > release, > > > without the commit: 35f462839b69 ("bus/vdev: add lock on device > > > list"). > > >=20 > > > It should be slightly reworked to function without. The previous > > > version > > > of this patch [1] could be used instead. > > >=20 > > > [1]: https://dpdk.org/ml/archives/dev/2018-April/098822.html > > >=20 > > > Regards, > >=20 > > Do you think it's worth including or can I skip it? > >=20 >=20 > It is an actual bug with a simple fix, so I think it's worth > including > yes. This is the diff when removing v2 and applying v1 instead: --- a/drivers/bus/vdev/vdev.c +++ b/drivers/bus/vdev/vdev.c @@ -397,7 +397,7 @@ vdev_find_device(const struct rte_device *start, rte_de= v_cmp_t cmp, } while (dev !=3D NULL) { if (cmp(&dev->device, data) =3D=3D 0) - break; + return &dev->device; dev =3D TAILQ_NEXT(dev, next); } return NULL; Please let me know if this is correct. Thanks! --=20 Kind regards, Luca Boccassi