patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] doc/guides/rel_notes: Add known issue for IOMMU attributes read
@ 2018-05-14 10:44 Rosen Xu
  2018-05-14 17:10 ` Burakov, Anatoly
  2018-05-16  7:29 ` [dpdk-stable] [PATCH v2] " Rosen Xu
  0 siblings, 2 replies; 9+ messages in thread
From: Rosen Xu @ 2018-05-14 10:44 UTC (permalink / raw)
  To: dev
  Cc: anatoly.burakov, gaetan.rivet, john.mcnamara, rosen.xu,
	yulong.pei, stable

Read IOMMU attributes from linux kernle 4.10.0 error.

Cc: stable@dpdk.org

Signed-off-by: Rosen Xu <rosen.xu@intel.com>
---
 doc/guides/rel_notes/known_issues.rst | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/doc/guides/rel_notes/known_issues.rst b/doc/guides/rel_notes/known_issues.rst
index afcc2c4..74876ff 100644
--- a/doc/guides/rel_notes/known_issues.rst
+++ b/doc/guides/rel_notes/known_issues.rst
@@ -714,3 +714,24 @@ igb_uio can not be used when running l3fwd-power
 
 **Driver/Module**:
    ``igb_uio`` module.
+
+
+linux kernel iommu attribute read error
+---------------------------------------
+
+**Description**:
+   Read immu attributes from /sys/devices/virtual/iommu/dmarXXX/intel-iommu/cap in linux kernel
+   4.10.0 error. That because the link between the iommu sysfs-device and the struct intel_iommu
+   is no longer stored as driver-data.
+
+**Implication**:
+   When insmod ``vfio-pci`` and running testpmd APP, it doesn't initiate properly.
+
+**Resolution/Workaround**:
+   Use other linux kernel version. It only happens in linux kernel 4.10.0.
+
+**Affected Environment/Platform**:
+   ALL OS of linux kernel 4.10.0.
+
+**Driver/Module**:
+   ``vfio-pci`` module.
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [PATCH] doc/guides/rel_notes: Add known issue for IOMMU attributes read
  2018-05-14 10:44 [dpdk-stable] [PATCH] doc/guides/rel_notes: Add known issue for IOMMU attributes read Rosen Xu
@ 2018-05-14 17:10 ` Burakov, Anatoly
  2018-05-16  6:08   ` Xu, Rosen
  2018-05-16  7:29 ` [dpdk-stable] [PATCH v2] " Rosen Xu
  1 sibling, 1 reply; 9+ messages in thread
From: Burakov, Anatoly @ 2018-05-14 17:10 UTC (permalink / raw)
  To: Rosen Xu, dev; +Cc: gaetan.rivet, john.mcnamara, yulong.pei, stable

On 14-May-18 11:44 AM, Rosen Xu wrote:
> Read IOMMU attributes from linux kernle 4.10.0 error.

s/kernle/kernel :)

> 
> Cc: stable@dpdk.org
> 
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> ---
>   doc/guides/rel_notes/known_issues.rst | 21 +++++++++++++++++++++
>   1 file changed, 21 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/known_issues.rst b/doc/guides/rel_notes/known_issues.rst
> index afcc2c4..74876ff 100644
> --- a/doc/guides/rel_notes/known_issues.rst
> +++ b/doc/guides/rel_notes/known_issues.rst
> @@ -714,3 +714,24 @@ igb_uio can not be used when running l3fwd-power
>   
>   **Driver/Module**:
>      ``igb_uio`` module.
> +
> +
> +linux kernel iommu attribute read error

Should this be capitalized?

> +---------------------------------------
> +
> +**Description**:
> +   Read immu attributes from /sys/devices/virtual/iommu/dmarXXX/intel-iommu/cap in linux kernel
> +   4.10.0 error. That because the link between the iommu sysfs-device and the struct intel_iommu
> +   is no longer stored as driver-data.

s/immu/IOMMU/, and i think this needs to be rewritten to something like 
as follows:

Reading IOMMU attributes from 
/sys/devices/virtual/iommu/dmarXXX/intel-iommu/cap in Linux kernel 
4.10.0 results in an error. This is because the link between the IOMMU 
sysfs-device and struct intel_iommu is no longer stored as driver-data.

(i have no idea what that last sentence means, maybe someone could help 
provide a better explanation?)

> +
> +**Implication**:
> +   When insmod ``vfio-pci`` and running testpmd APP, it doesn't initiate properly.

Should probably be reworded as follows:

When binding devices to VFIO and attempting to run testpmd application, 
testpmd (and other DPDK applications) will not initialize.

> +
> +**Resolution/Workaround**:
> +   Use other linux kernel version. It only happens in linux kernel 4.10.0.
> +
> +**Affected Environment/Platform**:
> +   ALL OS of linux kernel 4.10.0.
> +
> +**Driver/Module**:
> +   ``vfio-pci`` module.
> 


-- 
Thanks,
Anatoly

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [PATCH] doc/guides/rel_notes: Add known issue for IOMMU attributes read
  2018-05-14 17:10 ` Burakov, Anatoly
@ 2018-05-16  6:08   ` Xu, Rosen
  0 siblings, 0 replies; 9+ messages in thread
From: Xu, Rosen @ 2018-05-16  6:08 UTC (permalink / raw)
  To: Burakov, Anatoly, dev; +Cc: gaetan.rivet, Mcnamara, John, Pei, Yulong, stable

Hi Anatoly,

> -----Original Message-----
> From: Burakov, Anatoly
> Sent: Tuesday, May 15, 2018 1:10
> To: Xu, Rosen <rosen.xu@intel.com>; dev@dpdk.org
> Cc: gaetan.rivet@6wind.com; Mcnamara, John <john.mcnamara@intel.com>;
> Pei, Yulong <yulong.pei@intel.com>; stable@dpdk.org
> Subject: Re: [PATCH] doc/guides/rel_notes: Add known issue for IOMMU
> attributes read
> 
> On 14-May-18 11:44 AM, Rosen Xu wrote:
> > Read IOMMU attributes from linux kernle 4.10.0 error.
> 
> s/kernle/kernel :)

Fixed
 
> >
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> > ---
> >   doc/guides/rel_notes/known_issues.rst | 21 +++++++++++++++++++++
> >   1 file changed, 21 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/known_issues.rst
> > b/doc/guides/rel_notes/known_issues.rst
> > index afcc2c4..74876ff 100644
> > --- a/doc/guides/rel_notes/known_issues.rst
> > +++ b/doc/guides/rel_notes/known_issues.rst
> > @@ -714,3 +714,24 @@ igb_uio can not be used when running l3fwd-
> power
> >
> >   **Driver/Module**:
> >      ``igb_uio`` module.
> > +
> > +
> > +linux kernel iommu attribute read error
> 
> Should this be capitalized?

Fixed
 
> > +---------------------------------------
> > +
> > +**Description**:
> > +   Read immu attributes from /sys/devices/virtual/iommu/dmarXXX/intel-
> iommu/cap in linux kernel
> > +   4.10.0 error. That because the link between the iommu sysfs-device and
> the struct intel_iommu
> > +   is no longer stored as driver-data.
> 
> s/immu/IOMMU/, and i think this needs to be rewritten to something like as
> follows:
> 
> Reading IOMMU attributes from

Fixed

> /sys/devices/virtual/iommu/dmarXXX/intel-iommu/cap in Linux kernel
> 4.10.0 results in an error. This is because the link between the IOMMU sysfs-
> device and struct intel_iommu is no longer stored as driver-data.
> 
> (i have no idea what that last sentence means, maybe someone could help
> provide a better explanation?)

This linux kernel issue is fixed, around the 4.10/4.11 timeframe.
commit a7fdb6e648fb10a4174483b5fc4dac9c25bd2093
Author: Joerg Roedel <jroedel@suse.de>
Date:   Tue Feb 28 13:57:18 2017 +0100

    iommu/vt-d: Fix crash when accessing VT-d sysfs entries
    
    The link between the iommu sysfs-device and the struct
    intel_iommu is no longer stored as driver-data. Update the
    code to use the new access method.
 
> > +
> > +**Implication**:
> > +   When insmod ``vfio-pci`` and running testpmd APP, it doesn't initiate
> properly.
> 
> Should probably be reworded as follows:
> 
> When binding devices to VFIO and attempting to run testpmd application,
> testpmd (and other DPDK applications) will not initialize.

Fixed.
 
> > +
> > +**Resolution/Workaround**:
> > +   Use other linux kernel version. It only happens in linux kernel 4.10.0.
> > +
> > +**Affected Environment/Platform**:
> > +   ALL OS of linux kernel 4.10.0.
> > +
> > +**Driver/Module**:
> > +   ``vfio-pci`` module.
> >
> 
> 
> --
> Thanks,
> Anatoly

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [dpdk-stable] [PATCH v2] doc/guides/rel_notes: Add known issue for IOMMU attributes read
  2018-05-14 10:44 [dpdk-stable] [PATCH] doc/guides/rel_notes: Add known issue for IOMMU attributes read Rosen Xu
  2018-05-14 17:10 ` Burakov, Anatoly
@ 2018-05-16  7:29 ` Rosen Xu
  2018-05-28 15:31   ` Mcnamara, John
  1 sibling, 1 reply; 9+ messages in thread
From: Rosen Xu @ 2018-05-16  7:29 UTC (permalink / raw)
  To: dev
  Cc: anatoly.burakov, gaetan.rivet, john.mcnamara, rosen.xu,
	yulong.pei, stable

Linux kernel 4.10.0 iommu attribute read error

Cc: stable@dpdk.org

Signed-off-by: Rosen Xu <rosen.xu@intel.com>

v2 updates:
===========
 - Fixed Anatoly comments
---
 doc/guides/rel_notes/known_issues.rst | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/doc/guides/rel_notes/known_issues.rst b/doc/guides/rel_notes/known_issues.rst
index afcc2c4..716bd73 100644
--- a/doc/guides/rel_notes/known_issues.rst
+++ b/doc/guides/rel_notes/known_issues.rst
@@ -714,3 +714,28 @@ igb_uio can not be used when running l3fwd-power
 
 **Driver/Module**:
    ``igb_uio`` module.
+
+
+Linux kernel 4.10.0 iommu attribute read error
+----------------------------------------------
+
+**Description**:
+   When VT-d is enabled (``iommu=pt intel_iommu=on``), reading IOMMU attributes from
+   /sys/devices/virtual/iommu/dmarXXX/intel-iommu/cap on Linux kernel 4.10.0 error.
+   This bug is fixed in `Linux commmit a7fdb6e648fb
+   <https://patchwork.kernel.org/patch/9595727/>`_,
+   This bug is introduced in `Linux commmit 39ab9555c241
+   <https://patchwork.kernel.org/patch/9554403/>`_,
+
+**Implication**:
+   When binding devices to VFIO and attempting to run testpmd application,
+   testpmd (and other DPDK applications) will not initialize.
+
+**Resolution/Workaround**:
+   Use other linux kernel version. It only happens in linux kernel 4.10.0.
+
+**Affected Environment/Platform**:
+   ALL OS of linux kernel 4.10.0.
+
+**Driver/Module**:
+   ``vfio-pci`` module.
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [PATCH v2] doc/guides/rel_notes: Add known issue for IOMMU attributes read
  2018-05-16  7:29 ` [dpdk-stable] [PATCH v2] " Rosen Xu
@ 2018-05-28 15:31   ` Mcnamara, John
  2018-05-28 15:36     ` Mcnamara, John
  0 siblings, 1 reply; 9+ messages in thread
From: Mcnamara, John @ 2018-05-28 15:31 UTC (permalink / raw)
  To: Xu, Rosen, dev
  Cc: Burakov, Anatoly, gaetan.rivet, Pei, Yulong, stable, Yigit, Ferruh



> -----Original Message-----
> From: Xu, Rosen
> Sent: Wednesday, May 16, 2018 8:29 AM
> To: dev@dpdk.org
> Cc: Burakov, Anatoly <anatoly.burakov@intel.com>; gaetan.rivet@6wind.com;
> Mcnamara, John <john.mcnamara@intel.com>; Xu, Rosen <rosen.xu@intel.com>;
> Pei, Yulong <yulong.pei@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] doc/guides/rel_notes: Add known issue for IOMMU
> attributes read
> 
> Linux kernel 4.10.0 iommu attribute read error
> 
> Cc: stable@dpdk.org
> 
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>


Could you open an Bugzilla defect for this and add it to the text.

Like this patch: http://dpdk.org/dev/patchwork/patch/40475/

Thanks,

John

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [PATCH v2] doc/guides/rel_notes: Add known issue for IOMMU attributes read
  2018-05-28 15:31   ` Mcnamara, John
@ 2018-05-28 15:36     ` Mcnamara, John
  2018-05-29  0:25       ` Xu, Rosen
  2018-05-30 12:04       ` Thomas Monjalon
  0 siblings, 2 replies; 9+ messages in thread
From: Mcnamara, John @ 2018-05-28 15:36 UTC (permalink / raw)
  To: Xu, Rosen, dev
  Cc: Burakov, Anatoly, gaetan.rivet, Pei, Yulong, stable, Yigit, Ferruh



> -----Original Message-----
> From: stable [mailto:stable-bounces@dpdk.org]
> Sent: Monday, May 28, 2018 4:31 PM
> To: Xu, Rosen <rosen.xu@intel.com>; dev@dpdk.org
> Cc: Burakov, Anatoly <anatoly.burakov@intel.com>; gaetan.rivet@6wind.com;
> Pei, Yulong <yulong.pei@intel.com>; stable@dpdk.org; Yigit, Ferruh
> <ferruh.yigit@intel.com>
> Subject: Re: [dpdk-stable] [PATCH v2] doc/guides/rel_notes: Add known
> issue for IOMMU attributes read
> 
> 
> 
> > -----Original Message-----
> > From: Xu, Rosen
> > Sent: Wednesday, May 16, 2018 8:29 AM
> > To: dev@dpdk.org
> > Cc: Burakov, Anatoly <anatoly.burakov@intel.com>;
> > gaetan.rivet@6wind.com; Mcnamara, John <john.mcnamara@intel.com>; Xu,
> > Rosen <rosen.xu@intel.com>; Pei, Yulong <yulong.pei@intel.com>;
> > stable@dpdk.org
> > Subject: [PATCH v2] doc/guides/rel_notes: Add known issue for IOMMU
> > attributes read
> >
> > Linux kernel 4.10.0 iommu attribute read error
> >
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> 
> 
> Could you open an Bugzilla defect for this and add it to the text.
> 
> Like this patch: http://dpdk.org/dev/patchwork/patch/40475/

Actually, I changed my mind. This isn't quite the same as the other new, known issues, so there is no need to track it in Bugzilla or move it to the release note.

It is okay as is.


Acked-by: John McNamara <john.mcnamara@intel.com>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [PATCH v2] doc/guides/rel_notes: Add known issue for IOMMU attributes read
  2018-05-28 15:36     ` Mcnamara, John
@ 2018-05-29  0:25       ` Xu, Rosen
  2018-05-30 12:04       ` Thomas Monjalon
  1 sibling, 0 replies; 9+ messages in thread
From: Xu, Rosen @ 2018-05-29  0:25 UTC (permalink / raw)
  To: Mcnamara, John, dev
  Cc: Burakov, Anatoly, gaetan.rivet, Pei, Yulong, stable, Yigit,
	Ferruh, Mcnamara, John, Kovacevic, Marko

Hi Mcnamara and Kovacevic,

Could you apply this patch? Thanks a lot.

> -----Original Message-----
> From: Mcnamara, John
> Sent: Monday, May 28, 2018 23:37
> To: Xu, Rosen <rosen.xu@intel.com>; dev@dpdk.org
> Cc: Burakov, Anatoly <anatoly.burakov@intel.com>;
> gaetan.rivet@6wind.com; Pei, Yulong <yulong.pei@intel.com>;
> stable@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: RE: [PATCH v2] doc/guides/rel_notes: Add known issue for IOMMU
> attributes read
> 
> 
> 
> > -----Original Message-----
> > From: stable [mailto:stable-bounces@dpdk.org]
> > Sent: Monday, May 28, 2018 4:31 PM
> > To: Xu, Rosen <rosen.xu@intel.com>; dev@dpdk.org
> > Cc: Burakov, Anatoly <anatoly.burakov@intel.com>;
> > gaetan.rivet@6wind.com; Pei, Yulong <yulong.pei@intel.com>;
> > stable@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
> > Subject: Re: [dpdk-stable] [PATCH v2] doc/guides/rel_notes: Add known
> > issue for IOMMU attributes read
> >
> >
> >
> > > -----Original Message-----
> > > From: Xu, Rosen
> > > Sent: Wednesday, May 16, 2018 8:29 AM
> > > To: dev@dpdk.org
> > > Cc: Burakov, Anatoly <anatoly.burakov@intel.com>;
> > > gaetan.rivet@6wind.com; Mcnamara, John <john.mcnamara@intel.com>;
> > > Xu, Rosen <rosen.xu@intel.com>; Pei, Yulong <yulong.pei@intel.com>;
> > > stable@dpdk.org
> > > Subject: [PATCH v2] doc/guides/rel_notes: Add known issue for IOMMU
> > > attributes read
> > >
> > > Linux kernel 4.10.0 iommu attribute read error
> > >
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> >
> >
> > Could you open an Bugzilla defect for this and add it to the text.
> >
> > Like this patch: http://dpdk.org/dev/patchwork/patch/40475/
> 
> Actually, I changed my mind. This isn't quite the same as the other new,
> known issues, so there is no need to track it in Bugzilla or move it to the
> release note.
> 
> It is okay as is.
> 
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [PATCH v2] doc/guides/rel_notes: Add known issue for IOMMU attributes read
  2018-05-28 15:36     ` Mcnamara, John
  2018-05-29  0:25       ` Xu, Rosen
@ 2018-05-30 12:04       ` Thomas Monjalon
  1 sibling, 0 replies; 9+ messages in thread
From: Thomas Monjalon @ 2018-05-30 12:04 UTC (permalink / raw)
  To: Xu, Rosen
  Cc: stable, Mcnamara, John, dev, Burakov, Anatoly, gaetan.rivet, Pei,
	Yulong, Yigit, Ferruh

> > > Linux kernel 4.10.0 iommu attribute read error
> > >
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> > 
> > 
> > Could you open an Bugzilla defect for this and add it to the text.
> > 
> > Like this patch: http://dpdk.org/dev/patchwork/patch/40475/
> 
> Actually, I changed my mind. This isn't quite the same as the other new, known issues, so there is no need to track it in Bugzilla or move it to the release note.
> 
> It is okay as is.
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [dpdk-stable] [PATCH v2] doc/guides/rel_notes: Add known issue for IOMMU attributes read
@ 2018-05-16  7:05 Rosen Xu
  0 siblings, 0 replies; 9+ messages in thread
From: Rosen Xu @ 2018-05-16  7:05 UTC (permalink / raw)
  To: rosen.xu; +Cc: stable

Linux kernel 4.10.0 iommu attribute read error

Cc: stable@dpdk.org

Signed-off-by: Rosen Xu <rosen.xu@intel.com>

v2 updates:
===========
 - Fixed Anatoly comments
---
 doc/guides/rel_notes/known_issues.rst | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/doc/guides/rel_notes/known_issues.rst b/doc/guides/rel_notes/known_issues.rst
index afcc2c4..716bd73 100644
--- a/doc/guides/rel_notes/known_issues.rst
+++ b/doc/guides/rel_notes/known_issues.rst
@@ -714,3 +714,28 @@ igb_uio can not be used when running l3fwd-power
 
 **Driver/Module**:
    ``igb_uio`` module.
+
+
+Linux kernel 4.10.0 iommu attribute read error
+----------------------------------------------
+
+**Description**:
+   When VT-d is enabled (``iommu=pt intel_iommu=on``), reading IOMMU attributes from
+   /sys/devices/virtual/iommu/dmarXXX/intel-iommu/cap on Linux kernel 4.10.0 error.
+   This bug is fixed in `Linux commmit a7fdb6e648fb
+   <https://patchwork.kernel.org/patch/9595727/>`_,
+   This bug is introduced in `Linux commmit 39ab9555c241
+   <https://patchwork.kernel.org/patch/9554403/>`_,
+
+**Implication**:
+   When binding devices to VFIO and attempting to run testpmd application,
+   testpmd (and other DPDK applications) will not initialize.
+
+**Resolution/Workaround**:
+   Use other linux kernel version. It only happens in linux kernel 4.10.0.
+
+**Affected Environment/Platform**:
+   ALL OS of linux kernel 4.10.0.
+
+**Driver/Module**:
+   ``vfio-pci`` module.
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2018-05-30 12:04 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-14 10:44 [dpdk-stable] [PATCH] doc/guides/rel_notes: Add known issue for IOMMU attributes read Rosen Xu
2018-05-14 17:10 ` Burakov, Anatoly
2018-05-16  6:08   ` Xu, Rosen
2018-05-16  7:29 ` [dpdk-stable] [PATCH v2] " Rosen Xu
2018-05-28 15:31   ` Mcnamara, John
2018-05-28 15:36     ` Mcnamara, John
2018-05-29  0:25       ` Xu, Rosen
2018-05-30 12:04       ` Thomas Monjalon
2018-05-16  7:05 Rosen Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).