From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0050.outbound.protection.outlook.com [104.47.37.50]) by dpdk.org (Postfix) with ESMTP id 5E2BF1B424; Thu, 7 Jun 2018 18:31:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dxu6v8jp0/9FEhnfPMrF8kjT/d1RPGkcBi7U4T+1ziE=; b=U0n0nbgnIWmeQCvDhO1zltA0zMND+YvHX+QFx8AfBfp3vVmtSqxsgz4K4nwrNwnGVk07tQ3eH/cgKJ1jmgcnn+srKejuRBFZueIrH9zNOKj07RErJ61nlJkzlRNl0G0JOoZAAHcTjWCYwH07+SV61uCjSRoMkQt0Md2mHlGVvpQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by BL0PR07MB4018.namprd07.prod.outlook.com (2603:10b6:207:4b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.841.14; Thu, 7 Jun 2018 16:31:14 +0000 From: Rasesh Mody To: dev@dpdk.org Cc: Shahed Shaikh , ferruh.yigit@intel.com, Dept-EngDPDKDev@cavium.com, stable@dpdk.org Date: Thu, 7 Jun 2018 09:30:52 -0700 Message-Id: <1528389052-4875-2-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1528389052-4875-1-git-send-email-rasesh.mody@cavium.com> References: <1528389052-4875-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: BYAPR07CA0011.namprd07.prod.outlook.com (2603:10b6:a02:bc::24) To BL0PR07MB4018.namprd07.prod.outlook.com (2603:10b6:207:4b::20) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:BL0PR07MB4018; X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4018; 3:Cct8gLbaoGgFI1lXh2qVNYKtUlrS7s3xkanRfeM3BzSMp8/ix5ePbGaaWLBPsAQnoyEM9cLKmM280MfE0WmZ8x8vLC+VS9KPpOzwyG+vOpefLWZXt7zwjfOGBTGDdFySGuNiwZmm81p/g7Dsx0PD6gqaQSokCl+iuF5MCsNfcPONvtR/Q1TrLPBh8u/X5pDY8QJllAzv4I33QSKfg0VN2nEHm6tR8PZkPQ0B9oChF1Gk4qp2GiiJeAwuRDvOUNTw; 25:lM73jPQDcx73pFhHJ3c5QOZPnnHwwwM92DJ4IAXPMt9JXTsT/HEaWEzkPR0x9ELgSnuE2d/jpTEDQb6cjKCj7p0xbtmn4RbTivx0pmpGp8Auu76A/6LttB+e1wsU1NmxejsvZbPC+oh+uBdmZkr/PqAJp44Qi7L/ES9U4NgVcZUUCj76F+RkZGOg1ajY7oHm+vNtkYg055mHHAzNNu75G6b490QLsz7aefGWyX4CcUKO9pXRXOHly86MHB8SBYG015s8Mow4ufXj4T7rlfwlymrVGxkEjs8Cjxth62dvuM5af0fQ2l/o5iwrNCti9xbSshYBO0NW/ORBjJGZ8IpZGA==; 31:Ou5eJLhOibeU6cU3I2aANvhkTsCeAwNRV64i4pDHjyTG98w2Xy4AJlyrvbXkWQVOaf1tmFQ5l8/vy/RAzEOTpFY/37s3Y1rrfy5KE7F9kZHSGiCzJQjCgkkTAWA5KCet1Ips5YJd6kooIGGnlp/lIBYWG/IMeeIr6m6VcqO55cs7FyZ9Fd3e2IgKyAR18LR4D+MGAkCuk2NlGumXtL2R61oYHvXDfNkKPjWRnSx9PEo= X-MS-TrafficTypeDiagnostic: BL0PR07MB4018: X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4018; 20:QDZ/mfSIpLPUk6HkntEjmewe5ek06FkBxRM9MPBV77KNavKTvXRlEGXnkNug7pAyGRmlocHPT1f1Ffamrz0lbr71X/fUp0OJqlq+WcuC44j7MCqFjFLdlw26NpZShItbUYz0S1VRzdkdyLbMpTPE24RGObgZxEjiRaIByBWT1sZUsycIiv3oyxz9Rl3OyLQ8oNEaUWZksNmyGj2NJYoHT/euF+Y7Mr///gumms21gSvsT6jmfrqkZPU2RHirrdPX3WxE3G47ZK193T9EkYzTOwcm46PRpfL1/KlPreh7WrukGe0izfRWG09+IotBpSgYiuQq087snpwfqhfp7thQ2akzWw2mGadrAgCZlU+MivksJJ2crDvfrFG5VGEBhexPQKx7Nm1o9HWKVWKwhEVCK0Tddrh3EJPTb9488ZsWw8S5Qt8geVBpl5Mf6GHNypmavuCPcWF69TGede+KcFOWJ6anOGaQ6P68M1goNcvcaLzqZbcSZJG2JMwhgfcbAmAU; 4:r3/jEATZm0c37yJS9LKGhPxygFFVbW09fLN3rzsDqFkZ+UpqHFZw+OECalUnwRtxpJ2sBlshfSeN/QxCnVQd424wMyLP6FCXvw7edOTwJ8vw5qGsrHc3evLbfvBP01k/5BlVo9i5zVZ4WmOnvT8niivTpKaTpKqs8hNnBjaHepaqq6kW6x6z+UrDol1NDcHZpAPEvB7/51CQAZAJAJeuM9+7NBe3oETukCy9fVq888LR7eYVz0DejedUbxUpn6DHig+T43BveNm6u7NJHgFRen9roiAmuqbgFm1za2+S3z7iTzDqEGFotJ092S723gGE X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:BL0PR07MB4018; BCL:0; PCL:0; RULEID:; SRVR:BL0PR07MB4018; X-Forefront-PRVS: 06968FD8C4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(396003)(346002)(366004)(39380400002)(39860400002)(199004)(189003)(478600001)(8936002)(72206003)(5660300001)(51416003)(97736004)(7696005)(52116002)(8676002)(16526019)(36756003)(386003)(59450400001)(76176011)(68736007)(7736002)(6916009)(6666003)(69596002)(106356001)(66066001)(105586002)(305945005)(47776003)(50466002)(2351001)(25786009)(48376002)(81166006)(81156014)(956004)(2616005)(476003)(16586007)(4326008)(4720700003)(2361001)(15650500001)(86362001)(26005)(6116002)(3846002)(50226002)(55016002)(486006)(316002)(446003)(44832011)(11346002)(2906002)(186003)(53936002)(21086003); DIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR07MB4018; H:cavium.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BL0PR07MB4018; 23:hB+OG9m6/VOpF7RtuAAIuZ8tbLL8kG3pYtQMZwr9f?= =?us-ascii?Q?K/ZbyC7uFby2Qke23OC926snmnFcEiYyIxFTgFzxS138rFsFHSg/mmviMmCz?= =?us-ascii?Q?553ZsNIBjRKe+cDUisO0dmGpOGRg0z5aHhPuKUpLHgHFn1v4JYLHOEZQMpdv?= =?us-ascii?Q?nHYVEtlBCovvf1EMHSrdxUwy+N3tKz1WblwgAMwO4iZ1+yCp7QN9nEeWabTq?= =?us-ascii?Q?aZrchBVwm0owoWcORG654IDrfT5eo8iHLZUzONAFDCpKrcNYqxfUV2YuKk8X?= =?us-ascii?Q?YX7JALNqERRHf9mq4yEu2d3a9jk0Bz49OjXf7ka9ACYN4/OV68sPwNcwUeXA?= =?us-ascii?Q?/Tnfh6A0Ninm3okukPAuCLgxNJr8UR4tK1fNKRsLNqMimRHdYzA9EVicmlS0?= =?us-ascii?Q?bngQYJzJLTB1ZpTDmos/7iKo6kvXMNFn2ifXSu2JLzkM02RmtDKUUf7i82lI?= =?us-ascii?Q?6tWxC44X32Cp2jerdoBXC9Zxj29mKLnmDROmJpPJtgJmVxhshzhjxUnKmgRz?= =?us-ascii?Q?XZuspZrTjMVtoda/R+JBUBqWskP67TVLrOGwPnpQ9ver8j/e38bjkBZz1mJK?= =?us-ascii?Q?lmlyoTkHxkV09fLayK5gM881bOUkGKkb0A5jEomIX6MehvOyV095e2vAl7WS?= =?us-ascii?Q?nykeSgErhnBdTaQGNoE19f3BLaD1IX2eZ3AIEnEXX70AxGiUWEEpX9C+6eOu?= =?us-ascii?Q?jsGsPp9s0rLp8dDABFG7aaJrJqmhq0thYN0O+QcB6R0AYZwm6RGSBY8f7GEr?= =?us-ascii?Q?NVSpyhbssreUZymj68Cib6TuulM33A35tJimyvGOtTzRvJKG6SC1pwChC43A?= =?us-ascii?Q?jEVSKkPcP4bREJZEn6Kq9aisrzaWN8Wq7PJeBF8cp5kAgxi9nXQah/dioAhd?= =?us-ascii?Q?xUxgHh5l4D9SARfA/fBjxS+DIB6CaqFowYFmuqUx5HJmwoLUrLAjH6etBGAf?= =?us-ascii?Q?1IU/3M3GaK1qMiYnXVjFP78O6v9p+AhWb6AJToHGFVh8EOyK3ivg+YZSEw6B?= =?us-ascii?Q?5FtgHmNhiqS1I1B4FXSaTVyrSF8/tuO1TTb6GaODvs0IRgCnyuq4TbSB6amE?= =?us-ascii?Q?/1IHOnJ9lUU9rOlY7Psh5ITJ4Vam3ZzGy+m6827KqmXVRPPkg18OMqzNnlp1?= =?us-ascii?Q?mXt+XmaXfA2qlmyGKwJeNnlOBJuux/XVESP41dPxQ5fqmQTomfd1rXX3ZNNi?= =?us-ascii?Q?uyx7XDPf3HHuydMbTOBw394verVzTEbTsdfa75H3LU1+wSta7RW1tS+tfXJp?= =?us-ascii?Q?s8jZJdahzJsIj/v4uCZ0nxV1/WAHitCylZaJ6tn+SPRjc0OGgtjxflVglv0y?= =?us-ascii?Q?cXnsIFVsZxXqRWBY9RSI8BWjpMGJ1nQ2h3rBMgHHeuI0lHpoXqPYBGd+8jxH?= =?us-ascii?Q?nvw4Q=3D=3D?= X-Microsoft-Antispam-Message-Info: oc3AhDMFSVVR6RSj9eycJaUdQLHHna1AP4NgA7qP0Xw8UUzg/qIZDUmqKOBsl9JkNUa5Nl6ddJt4B3UaynDj/CQwLe1mm+tgA1rj152M4rHRZG/xaDwmxtdgr9SGCHC38Wc5RltleFQW6BsZS3yBLeqsVSJWrZKjPBB6hk8WUzSwrfLcNci3cq6KHNBQaCzo X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4018; 6:gkoCfk21KiCIeXvlJNqu82jVJRfygVYQRriy+jAiVcqpLHPSsmUM2NeKszs1ZQ3t8BJ9Y201O4FC299v38aW2kDJ/1N+5TTD+vld1FkS3eYIK3fazfZJkiybh5cXwWEaSx97SBGizC5S/FJOPGi2Bs5B3LmOCQBMrRXr2cwwBqCwbXlc81Xpqlz+USdSG5upZhaRLqrCJT9VTiwX44IKkP/WqKB2QiR9QVhXgO6uhmvsrR2GRXug1czKM0c0+4NYnWCfIMb/OoJdpj4ZC0H/nalZarU44Ap4pnIUfMVSLbzUwjD4s4PdoBmiN1pOXoqaaMCEq349akyHqleg1PJD63g/ERNA3VOGqEDdpsbAV/cINb0rtDRMXjMQtBcOcvUFl7rapHRn+lOsKYopCqoZFLIplMjrm1Qsdc1AoLGdQWTvKuQUUnKZu8qa8uxPU6/cdQsdqsmL6JUMt4WRKnVu/g==; 5:Fj+8TvZfN90Bhb1NWgPyXW7Q/LUj+C+0wG02huLMtV+wZojnuNBOhnSRPk8Sm4sb+FOYGSVX3/BBRVHFs+ZPNYAkGMcxx+2Wcu6WUnL1yUrQKKljAqUrSzpCP2AkufbmAq5VHaOMDhmeXBsAS8Bdrt5N/bLRv1+pe15GYw2u8pk=; 24:SQV0+1/w3leiKQHVkHFE8tb8aNPDQXRPXiFjtchntHylh1JApeaHZ2xI2r0FT8ok+gl885/Oa/GkVYLbH3pXjntHhGvyzraSbrIAORjktYM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4018; 7:SGhHrvC+9IYpre7SKEJRxcy/rUBuFtAxeH7/ReDm+sS2rg4S0M8eTtVVRZecSza+s2y0AEQ3RwThujW0kxf0qJwOjBDC2Rgl1J7lAicMtw/sht6IOtj18Lw4UXOe9AUZTotu5AQVuT9A4Ii7vAD/uWhVdfMKkxATsZ1StE+a8NytLRQc6sQjxJqtkb0BNzR1olTYTUF3iHF1+LlNWMir2gECg/eu4sjWR+3NPWwLuli1dpyG3yxE1/5RsExR9/Vr X-MS-Office365-Filtering-Correlation-Id: 5332125e-1af0-4123-20b9-08d5cc9416d9 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2018 16:31:14.3890 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5332125e-1af0-4123-20b9-08d5cc9416d9 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR07MB4018 Subject: [dpdk-stable] [PATCH 2/2] net/qede: fix link change event notification X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jun 2018 16:31:18 -0000 From: Shahed Shaikh As per existing behavior, when firmware sends a link change notification, PMD only updates the link structure but does not notify applications about it. This results in application sending packets even when link status is down. Fix this issue by issuing RTE_ETH_EVENT_INTR_LSC. Fixes: ec94dbc57362 ("qede: add base driver") Cc: stable@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c index c3407fe..de5a7ca 100644 --- a/drivers/net/qede/qede_main.c +++ b/drivers/net/qede/qede_main.c @@ -634,8 +634,11 @@ void qed_link_update(struct ecore_hwfn *hwfn) { struct ecore_dev *edev = hwfn->p_dev; struct qede_dev *qdev = (struct qede_dev *)edev; + struct rte_eth_dev *dev = (struct rte_eth_dev *)qdev->ethdev; - qede_link_update((struct rte_eth_dev *)qdev->ethdev, 0); + if (!qede_link_update(dev, 0)) + _rte_eth_dev_callback_process(dev, + RTE_ETH_EVENT_INTR_LSC, NULL); } static int qed_drain(struct ecore_dev *edev) -- 1.7.10.3