From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0059.outbound.protection.outlook.com [104.47.37.59]) by dpdk.org (Postfix) with ESMTP id 950521B167 for ; Fri, 8 Jun 2018 02:51:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q9oLaSVQvlDfDdHw5f0lUmoohnOOn58CeHGkioFMPK8=; b=VBiZ/BJhA0Ar4bHexg9cH5bi03/BLhadvlONr2N1v2X1BzH4Dmf8PTahcZv2kczOtWdRHApJkY9gPHpLPJB8zw5a+rIQXgTJkPehmkrXkF754mW7W9zNuL6GUsW9RMZcS1td2PNlDprciWjPBrTvyGDlQS+DFyjSdbXzZhTr0UY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by SN1PR07MB4031.namprd07.prod.outlook.com (2603:10b6:802:2b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.841.16; Fri, 8 Jun 2018 00:51:29 +0000 From: Rasesh Mody To: stable@dpdk.org Cc: Rasesh Mody , yliu@fridaylinux.org, Dept-EngDPDKDev@cavium.com Date: Thu, 7 Jun 2018 17:51:11 -0700 Message-Id: <1528419074-18954-2-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1528419074-18954-1-git-send-email-rasesh.mody@cavium.com> References: <1528419074-18954-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: BYAPR01CA0014.prod.exchangelabs.com (2603:10b6:a02:80::27) To SN1PR07MB4031.namprd07.prod.outlook.com (2603:10b6:802:2b::14) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(2017052603328)(7153060)(7193020); SRVR:SN1PR07MB4031; X-Microsoft-Exchange-Diagnostics: 1; SN1PR07MB4031; 3:JygcygP97sv+gpn2QtOko3KI1//yP3NohHoGhqWRpEmCKATvkiKI3beVQ3tZeDMIiMDCPTIs3dJioePlSXrFA0jbDcmidahO620194zIHOT8ugNK474ekw9eNmE2kaF+e0lqaOrJyqSK9FQKIFvAIqR9ZB59LkymHpXu9luXffDcF55l4VYff7sNWPaaqzTbG9vwHy3OEX02e9iWNKZYSPZO00CkwZ016FaujycU/pbjra/CsvPBSdueS2lbQxcq; 25:fjYmFRTKqVANBTZuP1hgnnNL+aPm+bnccusjZibCUaqxW6NrOg84KnDlz8JrKROQ9OvyjVXRw9DU88FshSVGOBDsKlCL1S/UHZpDXXNo9e5D61/4X1jEZ5S1udehCt0SvXIzU2yPiG3sPOYAgHbXsk238Q6MdNBFxMSMQRc8NUYEKsbf8I/B26vFgU8xXfRJ59f7WymE8BDCpSA64cH7W5psYN5W1PHOINsycld+tpFzAuThDNrJ4d8kEHyM2W1WVFugK1VvWvC3a4VuQ+QM8PDLy0By5vN7AWAGEq436vMJkxI/JFVwFvgmli9Kd5v5tHs+g2M+AJoBvZiGsIrZ7A==; 31:Z+gu64EDZYlo4pMU8mz2CrMJePWanf6fr5cLqNXzHV3w1bt/6ZEakC1bvpyblyukmRcB5rx09BP8yA3tOd6zk6tRtvsVvl34GcKT2QwoVHAJbH9DDALwXQmC260HzMS++fxzgeuxRk8yjE2dUkxKmDNsV02dt5IZQX+SQUkbhjGq7qeF6Lfr5cEl2NDdzhOgeD3/l6iXAlPSV/8MTZWB71LVjYVWiHieSSI3n8Is/LM= X-MS-TrafficTypeDiagnostic: SN1PR07MB4031: X-Microsoft-Exchange-Diagnostics: 1; SN1PR07MB4031; 20:ZyHly6khhQqItLEWd0Y1id/+YrzDKlc5Z6iR5RDHPtB+87m//l1O0/Di0m2ujz7dlOw+7sTzocCX93IbQrGapEyWMJHE94olzNzQFqHtvfA1TlLUei1xxJa70ml79DIGfPyLmrwfl+pGQ2UF8PbIp6WxEJjyqp4Vl3es/V2v28rpNY6/HBxgW748LKwC+pdhk//7oMeU804zCALbZ6WoTbAXtjocmxHs9p5C8PUnB/Nh1cvKBzsX8RyZzzPjy/8oIJcQ8V+YCWGnQlxZpvC0d/+KUzNlvyRGX7Vl6lxolsWJmhWTnBwOYDBluFLboa6T1iVl3nQF/wMFxDlc0tCBssxkt2qQbbfYmk3+Vp3hllqxXlm5PhDTsLGGkPc/WzAbKIUaTxNgbkbz5L7+37rN9Sdl1XHtxXUQdd8vrcIgETXqSZci7sl9v8/jIL3jrbiLDwvq0/Q5/GF4Ji5zdI6KJXAukuvwJ/Rv/6ux1UpniSsaoaHwk4mQlDA7ITv4shJS; 4:n/U5cqKHM1IPlTh6zkpp8QjtL8Ozw7s89xrAs7tfk98jrAYLrs9lcFGPd/ZK1vb4QY16hzJeWc9wr/wV5L5qrpqeSORkV2FbK2q+RIZpZTMrselfq69rKJ4BIZZZXJIk5qfVdOmVMYnE2TfoleesrV+8y2cGdo9oX/xZCu5MdoEve0o3cCcNupeCCrzuUOKrBWW68dvCyF7I+DsM56grwL6t+tCrYoRHIvupQgQ9sMWZZKJsnYRfGqE/PiFBlfaPiOM1HaC1zhoBo2TsbymGsA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(3231254)(944501410)(52105095)(10201501046)(93006095)(93001095)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:SN1PR07MB4031; BCL:0; PCL:0; RULEID:; SRVR:SN1PR07MB4031; X-Forefront-PRVS: 06973FFAD3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(366004)(39860400002)(346002)(396003)(376002)(199004)(189003)(25786009)(81166006)(55016002)(50226002)(6116002)(3846002)(50466002)(81156014)(21086003)(16586007)(486006)(53936002)(7736002)(72206003)(305945005)(8936002)(2616005)(26005)(476003)(48376002)(316002)(956004)(44832011)(11346002)(7696005)(52116002)(86362001)(97736004)(186003)(16526019)(51416003)(386003)(76176011)(106356001)(5660300001)(6916009)(2906002)(4720700003)(69596002)(8676002)(47776003)(59450400001)(446003)(68736007)(2361001)(6666003)(2351001)(66066001)(4326008)(36756003)(478600001)(107886003)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR07MB4031; H:cavium.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR07MB4031; 23:xphLHX952hIXgnv5Rnz1QS82B4rucUqXhh57FXOtV?= =?us-ascii?Q?b8Pbjbfo53Upz55lAoraKUa3KolKmZt0fahBj/mFK2SYZtb743Cc4j6EMIXZ?= =?us-ascii?Q?HxHGL41sMCXF8ppgd7pmPN6tYfCW5KEESEFWOa4hTJgge7ZVkHhl4Yt7bD65?= =?us-ascii?Q?Fpoy6yIqZv0w64HIOkEblNkFUNRoN5Bc0/NMHdYovbbVlclcc3BU/ucXk6jZ?= =?us-ascii?Q?/cjau1N2belhBCMy/+54N1aRmlBSfnZedESJDlSnWtmUgFHT32XA8GZFpQHG?= =?us-ascii?Q?/wZeZPbFpuDGb/mLYoXfSIinFZOH8X8JkOfVXXW2WQHzKzJA3yqrv8cmiSzb?= =?us-ascii?Q?cTrynXXcgWLEZ7g3mrpd+o00Jo2kTgTHG+yQT/BULJ+zO4GNOu9dc2b1mlqn?= =?us-ascii?Q?5XdGwypJe6G6AUoGTE+9MzergpeYN8iB5bxlqyIipV6FgISTF0VN29H8GtQu?= =?us-ascii?Q?fPIsRUc66b2G3lq0y1FTPpmOvgVBrqkaxYjF4JPw1WkXmtXYPPAR2+FQx8oA?= =?us-ascii?Q?uo35sG/Iy7S7v+pEvKzPrNCIxpdVm3AUvcCseG7oli2o2fpjJF1Nq5jzm40B?= =?us-ascii?Q?wCCcPttzX69/Kr7a84ugtQDqyVrWurQPBc+7b4B/BoALV8vJotZmaFsKL4tV?= =?us-ascii?Q?lxmZozpP8PPXoF/ZNbmwIi1O1X7gLCv+w9nJK6silEMI10Y0cwG8ixLXP8qL?= =?us-ascii?Q?zu2SJFMdSVXCHUmwXyI3uR+3XhD7dYKZEPTxQ07l7KT/4alE4VchZOdcrzkF?= =?us-ascii?Q?4/fRh4EM7xKY8UFMg0+eOsCzcWuSvr1q+OdVbRRkG3dldpwbYGlkgvMkvv17?= =?us-ascii?Q?Gpew/+9UDU1qMPDOwUnn0h/oz4xjAYShQ6YIUsf2ZlxAIDQ/VoXQptMc9J/h?= =?us-ascii?Q?AOVX3YSzLETOFpkgTZb22yj4AM6ixSUEp6xj2I4rLckCkO8KBIJp87Qgswcv?= =?us-ascii?Q?GbZZCGNANE0shPDhVhdrkOX4/tCLNIBl6sdua1l/8KCrTO6RHC6yHZa0L3H3?= =?us-ascii?Q?PuX0YGRTAdtcRAQ4QNkWWsB2VqFlW5ObrE91m4pMaZrvVEDgPglWqrrZQCsL?= =?us-ascii?Q?kp1bz0UR6VQQ/uu4+ekPHeKbmgkaGxLHZE9E01+hY+C/IBShFvYunorlAPJx?= =?us-ascii?Q?yPEftabyYTKn8weRt8+FH2JL+RuQXGvjn+v+aI7QeNZFSLrb1XHQDTJFkfYz?= =?us-ascii?Q?g1vEgNsm6TrMuAvNlxkjrScjizQ21sUzPN2uIjR27RPP2E5xwzHZV4eeoEXG?= =?us-ascii?Q?D+S8IqEny7aeM/umlwGCZEUoOZ/LoHDFw5YglQerzv/BCWCqz/H19XobdxIK?= =?us-ascii?Q?twPAgJ6xYX9PLNSh62Q72nCS67h6M4eYwg9oNPTeMooUivQwrWmYiSsFyHWJ?= =?us-ascii?Q?AoOCA=3D=3D?= X-Microsoft-Antispam-Message-Info: PlK5IL5uQNZ8OmlDGspJ3afnJhZDGezdhMVTH5B1sjB58aUSRvPqUOC4+fStQ2moXk91ZPJOy9LSnALU3LILQNqifo6JS30xUIi82b9sHkX2u377IIKRZpYk6e9/av+R1ikwGGMQL8WAyq9BqfrqHqbGFGK9CpO5BVWWi+BAk39TRwbzlYMmfXskPUFo8tKW X-Microsoft-Exchange-Diagnostics: 1; SN1PR07MB4031; 6:OgEHjOPX7NgJPILJV52MVp3j5gp0CSSzKiCXu+Q8hBsIchZCBl0o8z6PHFSEwZ7N4UZWZRDHDqyRDeV55ImqxLleMp6m3YG8mmYPRyjp+2VZRrPVsBMJ0Wp+Acjs3HlaWaoj9yE997+ytZeJYc28G6HfR2c3w9zSqWxixXuyv/NnidSllfvA93wXyie7IUsPjmFHhYvjwCOOEpb94SK/tD8WYtfMQZQWCb3J5SIopFPvc8LF5GBhLLt3dqwYhHsyr4xdAzp21b+FUxuQB7373cMnK0fsyb5EE/TjKTJ97Sms1ECHLvt4Mg9UrbUhssUgpx9Rt9P55g4+QnAkaII3vXfX9PVLnsGG3z0A6KRkbG2HfQQYiYmWZ868P8qJiGAebmNvWnWx9myDvsF+N7QVyBTqQ80D33aEqAmJO6rqmRek8Ei6yz4UuOPyeDNydOnhohFF+wSkWmtn9pid2GMj7g==; 5:b4xr1MaTMjSM3zV8hGx4fpwfcwLwsXesyj7+YPKf0xN3yuPhGgnHUdTLnAjszxn+vlHf60anjT/H/gSY6YpigjFvNHCaf+eQqQZrGG6cXyt+sruymiGYdCqXy7KIE/b52+cEnMIU5QyBadwh0uiYIgdSomqKwR2ZTF6GEcpmz6o=; 24:NZ4Je4r/yOiDbrwiLWQ55BrVlk9pQWRLYRpxuUe2SbURUKctgoJ0b+2hNToudGTjkdDlN3oCCf/DHJugZtPop+Bwh8PS0AexEnlNVBjxQJ8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR07MB4031; 7:8LmHoZeupz5AkACyjbjPsd9R1GzyzL0+cXiT/sXOqKgifGvcDjgURFG77KAEihL0BAI3ppnT1NtczH8WG1Ma69S42iRnSaJJuL+RGFnRSHEInmya+vh0S2xIXF6374Q1kpJdxDBpeKExgF4p8wrdO0eE+5BBNPBfp6qad38TYRtfqQ2RxmWdgbH19kvjG5d+bI/56rH85zFqTDVBZcY0GtLkSmropY0N5d9ULFWG5AB3kiqIJyj+vZyWDapwsnaO X-MS-Office365-Filtering-Correlation-Id: abf984c5-6b03-4d48-5f00-08d5ccd9f8ff X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2018 00:51:29.7126 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: abf984c5-6b03-4d48-5f00-08d5ccd9f8ff X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR07MB4031 Subject: [dpdk-stable] [PATCH 17.11 2/5] net/qede: fix device stop to remove primary MAC X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jun 2018 00:51:32 -0000 [ upstream commit 83ade1ebdbfc8211d3cb5c2bc282c3fa396e4a34 ] This fix is to remove primary MAC filter during dev stop. Without the fix device start attempt to add the primary MAC fails. Perform MAC set remove under IS_PF() check. Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence") Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 15b6c27..d266fff 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -905,7 +905,7 @@ static int qede_del_mcast_filters(struct rte_eth_dev *eth_dev) ether_addr_copy(ð_dev->data->mac_addrs[index], (struct ether_addr *)&ucast.mac); - ecore_filter_ucast_cmd(edev, &ucast, ECORE_SPQ_MODE_CB, NULL); + qede_mac_int_ops(eth_dev, &ucast, false); } static void @@ -1245,6 +1245,9 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev) /* Disable traffic */ ecore_hw_stop_fastpath(edev); /* TBD - loop */ + if (IS_PF(edev)) + qede_mac_addr_remove(eth_dev, 0); + DP_INFO(edev, "Device is stopped\n"); } @@ -2329,6 +2332,9 @@ static int qede_set_mtu(struct rte_eth_dev *dev, uint16_t mtu) dev->data->dev_started = 0; qede_dev_stop(dev); restart = true; + } else { + if (IS_PF(edev)) + qede_mac_addr_remove(dev, 0); } rte_delay_ms(1000); qede_start_vport(qdev, mtu); /* Recreate vport */ @@ -2356,7 +2362,9 @@ static int qede_set_mtu(struct rte_eth_dev *dev, uint16_t mtu) dev->data->dev_conf.rxmode.jumbo_frame = 0; /* Restore config lost due to vport stop */ - qede_mac_addr_set(dev, &qdev->primary_mac); + if (IS_PF(edev)) + qede_mac_addr_set(dev, &qdev->primary_mac); + if (dev->data->promiscuous) qede_promiscuous_enable(dev); else -- 1.7.10.3