From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 1B440F72 for ; Mon, 23 Jul 2018 19:10:52 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id f21-v6so1828846wmc.5 for ; Mon, 23 Jul 2018 10:10:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=nurgCNdZdgd/M1tncF5NlwtmYsletpHS2bRyF+1KZO8=; b=ROCbRrNeTW4ZHl5rWVzCx+Owqv/LAkUCSAaa5YP1Lza2oRAAQkwhWeAbmnWRoDBT0s zjK6eqryMojZ1in7hqbGt/EnQOVngDSnhzKz/Ulaw+qW1eG31Z6X1irOt7ET52z28iZ6 thFmkAC7ymcU3UDs0B3aYNNRIFd5mhd1fjXN53VhD0dStkE9kpyCAMHH9sI0gMcnMZPp K5TXgEhHcI9nABf0AFtbG0frBlUFhI5reWo7E6PhrelGlzWU/scbmLz5+vnCB2P11pu2 RjG3js288Mo23D+qSFlP/LH/bfMkCtYDHCuSZFD1HPtnlzsoT0E8X4xBmtNCIUr9JRIZ 0Wrw== X-Gm-Message-State: AOUpUlEP4FnN4MQIYs7QISe/97APU8INBUL0phUVgbl5NKfY6cOnKyYt 5jOql2uRqnjbVDobGEUyX2c= X-Google-Smtp-Source: AAOMgpd/h4TcVpIwv0MIK8he3Xy2dTYyAw0iNr+ktVeOjtcEfvkDOUk1yCmwTexiW8cFHcK4xpXoqA== X-Received: by 2002:a1c:90cf:: with SMTP id s198-v6mr8337191wmd.5.1532365851710; Mon, 23 Jul 2018 10:10:51 -0700 (PDT) Received: from localhost ([2a00:23c5:be94:4600:7b12:f8a0:fd52:f87d]) by smtp.gmail.com with ESMTPSA id h17-v6sm5227500wrq.73.2018.07.23.10.10.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Jul 2018 10:10:50 -0700 (PDT) Message-ID: <1532365849.7624.12.camel@debian.org> From: Luca Boccassi To: Andrew Rybchenko , arybchik@oktetlabs.ru Cc: stable@dpdk.org Date: Mon, 23 Jul 2018 18:10:49 +0100 In-Reply-To: <1531302380-16764-1-git-send-email-arybchenko@solarflare.com> References: <1531302380-16764-1-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] net/sfc: cut non VLAN ID bits from TCI X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2018 17:10:52 -0000 On Wed, 2018-07-11 at 10:46 +0100, Andrew Rybchenko wrote: > TCI may contain PCP or DEI bits. Matching of these bits is not > supported, but the bits still may be set in specification value and > not covered by mask. So, these bits should be ignored. >=20 > Fixes: 894080975e1e ("net/sfc: support VLAN in flow API filters") > Cc: stable@dpdk.org >=20 > Signed-off-by: Andrew Rybchenko > Reviewed-by: Roman Zhukov > --- > =C2=A0drivers/net/sfc/sfc_flow.c | 3 ++- > =C2=A01 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c > index 5613d59a9..18387415e 100644 > --- a/drivers/net/sfc/sfc_flow.c > +++ b/drivers/net/sfc/sfc_flow.c > @@ -371,7 +371,8 @@ sfc_flow_parse_vlan(const struct rte_flow_item > *item, > =C2=A0 =C2=A0* the outer tag and the next matches the inner tag. > =C2=A0 =C2=A0*/ > =C2=A0 if (mask->tci =3D=3D supp_mask.tci) { > - vid =3D rte_bswap16(spec->tci); > + /* Apply mask to keep VID only */ > + vid =3D rte_bswap16(spec->tci & mask->tci); > =C2=A0 > =C2=A0 if (!(efx_spec->efs_match_flags & > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0EFX_FILTER_MATCH_OUTER_VID)) = { Hi Andrew, For which stable release branch is this patch intended? Has it (or an equivalent) been merged into mainline? --=20 Kind regards, Luca Boccassi