* [dpdk-stable] [PATCH] app/testpmd: fix dcb config failure
@ 2018-07-24 11:32 Xiaoyun Li
2018-07-24 16:16 ` [dpdk-stable] [dpdk-dev] " Iremonger, Bernard
0 siblings, 1 reply; 2+ messages in thread
From: Xiaoyun Li @ 2018-07-24 11:32 UTC (permalink / raw)
To: wenzhuo.lu, jingjing.wu; +Cc: dev, Xiaoyun Li, stable
After adding RSS hash offload check, default rss_hf will fail on devices
that do not support all bits. This will lead to dcb config failure. The
patch fixes this issue by taking rss_hf as a suggested value and only
setting bits that the device supports based on rte_eth_dev_get_info.
Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
Fixes: 1a572499beb6 ("app/testpmd: setup DCB forwarding based on traffic class")
Cc: stable@dpdk.org
Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
---
app/test-pmd/testpmd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index f504ca3..d221469 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2575,6 +2575,9 @@ init_port_dcb_config(portid_t pid,
if (retval < 0)
return retval;
port_conf.rxmode.offloads |= DEV_RX_OFFLOAD_VLAN_FILTER;
+ rte_eth_dev_info_get(pid, &rte_port->dev_info);
+ port_conf.rx_adv_conf.rss_conf.rss_hf &=
+ rte_port->dev_info.flow_type_rss_offloads;
/* re-configure the device . */
rte_eth_dev_configure(pid, nb_rxq, nb_rxq, &port_conf);
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix dcb config failure
2018-07-24 11:32 [dpdk-stable] [PATCH] app/testpmd: fix dcb config failure Xiaoyun Li
@ 2018-07-24 16:16 ` Iremonger, Bernard
0 siblings, 0 replies; 2+ messages in thread
From: Iremonger, Bernard @ 2018-07-24 16:16 UTC (permalink / raw)
To: Li, Xiaoyun, Lu, Wenzhuo, Wu, Jingjing; +Cc: dev, Li, Xiaoyun, stable
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xiaoyun Li
> Sent: Tuesday, July 24, 2018 12:33 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] app/testpmd: fix dcb config failure
>
> After adding RSS hash offload check, default rss_hf will fail on devices that do
> not support all bits. This will lead to dcb config failure. The patch fixes this
> issue by taking rss_hf as a suggested value and only setting bits that the
> device supports based on rte_eth_dev_get_info.
>
> Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
> Fixes: 1a572499beb6 ("app/testpmd: setup DCB forwarding based on traffic
> class")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-24 16:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-24 11:32 [dpdk-stable] [PATCH] app/testpmd: fix dcb config failure Xiaoyun Li
2018-07-24 16:16 ` [dpdk-stable] [dpdk-dev] " Iremonger, Bernard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).