From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 7925C3230 for ; Thu, 26 Jul 2018 11:46:56 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id s9-v6so1312877wmh.3 for ; Thu, 26 Jul 2018 02:46:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=nkBwwsK2cq1zft6XRrEtc9jNIv7UHTHhRbEZa45GPKE=; b=gGjPKeIKFL5mJ3C9srcn9k4mgG26LtYNVy4nrc7QHxzNQUDyZ1pnnQPinuk5ebdqIQ yr3h9S/62mfL0JtdkYaqgEePnaxuJVXXt0e9iu5eRv0Xk70lgS3fNXKR4cv8RCO13e1N zYTV9v+quqwLwPGIFAE7z+bvp4VhHe8u8argJ5mILQqFEW17nBCQfPYC/f3/qXSSul19 lJ/raLoGHnkkcB94V1w1+U+2Gvd+emgAH71DAmomamafAuVDYqzZo5CvGPC0iiz6Tc3n M/OG6ZV1jq9d4jUSFfd8XipFSDnF5no1nK+9X9MUAL2S9g/I0qSFLPgyWb/9iUCg0E5W DQTQ== X-Gm-Message-State: AOUpUlGJ9VIOIfnxDYz8qVZ3EOc7AFBokl+fq3zUyfrS3nrzJFJKiofo gEt09v2+9FqYVZQXzaEhMkA= X-Google-Smtp-Source: AAOMgpfl7t1Gv3nLGrl7PC73MVjkk7FZ2dknltlh+aGmgwgxZDQMDUF8+plQ/DEeBCtCSv7AlGiLyw== X-Received: by 2002:a1c:91c7:: with SMTP id t190-v6mr1140351wmd.2.1532598416181; Thu, 26 Jul 2018 02:46:56 -0700 (PDT) Received: from localhost ([2a00:23c5:be94:4600:7b12:f8a0:fd52:f87d]) by smtp.gmail.com with ESMTPSA id c124-v6sm1456187wma.47.2018.07.26.02.46.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Jul 2018 02:46:54 -0700 (PDT) Message-ID: <1532598414.20916.22.camel@debian.org> From: Luca Boccassi To: Andrew Rybchenko , arybchik@oktetlabs.ru Cc: stable@dpdk.org Date: Thu, 26 Jul 2018 10:46:54 +0100 In-Reply-To: <4de7a434-ea9f-8f0c-fd11-6b3c6419ad7c@solarflare.com> References: <1531302380-16764-1-git-send-email-arybchenko@solarflare.com> <1532365849.7624.12.camel@debian.org> <4de7a434-ea9f-8f0c-fd11-6b3c6419ad7c@solarflare.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] net/sfc: cut non VLAN ID bits from TCI X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 09:46:56 -0000 On Thu, 2018-07-26 at 12:42 +0300, Andrew Rybchenko wrote: > On 23.07.2018 20:10, Luca Boccassi wrote: > > On Wed, 2018-07-11 at 10:46 +0100, Andrew Rybchenko wrote: > > > TCI may contain PCP or DEI bits. Matching of these bits is not > > > supported, but the bits still may be set in specification value > > > and > > > not covered by mask. So, these bits should be ignored. > > >=20 > > > Fixes: 894080975e1e ("net/sfc: support VLAN in flow API filters") > > > Cc: stable@dpdk.org > > >=20 > > > Signed-off-by: Andrew Rybchenko > > > Reviewed-by: Roman Zhukov > > > --- > > > =C2=A0=C2=A0drivers/net/sfc/sfc_flow.c | 3 ++- > > > =C2=A0=C2=A01 file changed, 2 insertions(+), 1 deletion(-) > > >=20 > > > diff --git a/drivers/net/sfc/sfc_flow.c > > > b/drivers/net/sfc/sfc_flow.c > > > index 5613d59a9..18387415e 100644 > > > --- a/drivers/net/sfc/sfc_flow.c > > > +++ b/drivers/net/sfc/sfc_flow.c > > > @@ -371,7 +371,8 @@ sfc_flow_parse_vlan(const struct > > > rte_flow_item > > > *item, > > > =C2=A0=C2=A0 =C2=A0* the outer tag and the next matches the inner tag= . > > > =C2=A0=C2=A0 =C2=A0*/ > > > =C2=A0=C2=A0 if (mask->tci =3D=3D supp_mask.tci) { > > > - vid =3D rte_bswap16(spec->tci); > > > + /* Apply mask to keep VID only */ > > > + vid =3D rte_bswap16(spec->tci & mask->tci); > > > =C2=A0=C2=A0 > > > =C2=A0=C2=A0 if (!(efx_spec->efs_match_flags & > > > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0EFX_FILTER_MATCH_OU= TER_VID)) { > >=20 > > Hi Andrew, > >=20 > > For which stable release branch is this patch intended? Has it (or > > an > > equivalent) been merged into mainline? >=20 > Hi Luka, >=20 > Yes, the patch is applied in mainline [1]. >=20 > It would be good if it is applied to 17.11, 18.02 and 18.05 stable > branches. >=20 > [1]=C2=A0 > https://git.dpdk.org/dpdk/commit/?id=3D8028142107a858a146bfdbaa010b7e77 > ff987342 >=20 > Thanks, > Andrew. Ok, thanks, in the future please use --subject-prefix=3D'PATCH xx.yy' with git send-email to indicate the target branch(es) --=20 Kind regards, Luca Boccassi