From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 07B1D3421 for ; Thu, 26 Jul 2018 12:03:08 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id g6-v6so1109951wrp.0 for ; Thu, 26 Jul 2018 03:03:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=1KoGk+dzwEtMil7dbHSEXax5DGKU3XV0Rqg4ecKYzlQ=; b=rpnUQj+mgO8xkSsQYJUxZkEz7oX7ArLv3jNU7m5cusJu3iLsiCD0X9hATbHGrRGxHN 22Q8Ft7otH5AzxblBNDVAxhWX89Y013bd0OG5hfIwAj2AXQu0ONP70E3N5+CKDsjSr1C JLmpAkGopG/4AOpPI0yFKW8Uphx/E0xgQAeo+3BnrEaZilapFQfnJu/Nuq9i+kXNM7z2 tWpB18jrTyruudZCfxrh02ztVadxkuTDMSlcprhhuOaomok97aQFPPLtpGjAhoYMNNJW u2+BQJoPtSakgE4G24LmCnn7H5bHB2mrS3rDdIOAZyryWb6Zgm8u2ybOkAdj80TXIZbm YKsw== X-Gm-Message-State: AOUpUlGkdoV7QHj6/n2oTr4hsrEaTHvPDM0M0kjzu3fDVWDcuX9q+C0t 6U+t0MQUNFcKo4/SujTEDzVP02LI X-Google-Smtp-Source: AAOMgpd3icffbp33tYHfk0BHOi+9HtnqAo+Hpnlc7lDLXMciLGR3ekxgHgLf0Kox30PBuTdaVmgtcg== X-Received: by 2002:adf:81a3:: with SMTP id 32-v6mr1115947wra.9.1532599387785; Thu, 26 Jul 2018 03:03:07 -0700 (PDT) Received: from localhost ([2a00:23c5:be94:4600:7b12:f8a0:fd52:f87d]) by smtp.gmail.com with ESMTPSA id c124-v6sm1512177wma.47.2018.07.26.03.03.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Jul 2018 03:03:06 -0700 (PDT) Message-ID: <1532599385.20916.24.camel@debian.org> From: Luca Boccassi To: Andrew Rybchenko Cc: stable@dpdk.org Date: Thu, 26 Jul 2018 11:03:05 +0100 In-Reply-To: References: <1531302380-16764-1-git-send-email-arybchenko@solarflare.com> <1532365849.7624.12.camel@debian.org> <4de7a434-ea9f-8f0c-fd11-6b3c6419ad7c@solarflare.com> <1532598414.20916.22.camel@debian.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] net/sfc: cut non VLAN ID bits from TCI X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 10:03:08 -0000 On Thu, 2018-07-26 at 12:52 +0300, Andrew Rybchenko wrote: > On 26.07.2018 12:50, Andrew Rybchenko wrote: > > On 26.07.2018 12:46, Luca Boccassi wrote: > > > On Thu, 2018-07-26 at 12:42 +0300, Andrew Rybchenko wrote: > > > > On 23.07.2018 20:10, Luca Boccassi wrote: > > > > > On Wed, 2018-07-11 at 10:46 +0100, Andrew Rybchenko wrote: > > > > > > TCI may contain PCP or DEI bits. Matching of these bits is > > > > > > not > > > > > > supported, but the bits still may be set in specification > > > > > > value > > > > > > and > > > > > > not covered by mask. So, these bits should be ignored. > > > > > >=20 > > > > > > Fixes: 894080975e1e ("net/sfc: support VLAN in flow API > > > > > > filters") > > > > > > Cc: stable@dpdk.org > > > > > >=20 > > > > > > Signed-off-by: Andrew Rybchenko > > > > > > Reviewed-by: Roman Zhukov > > > > > > --- > > > > > > =C2=A0=C2=A0=C2=A0drivers/net/sfc/sfc_flow.c | 3 ++- > > > > > > =C2=A0=C2=A0=C2=A01 file changed, 2 insertions(+), 1 deletion(-= ) > > > > > >=20 > > > > > > diff --git a/drivers/net/sfc/sfc_flow.c > > > > > > b/drivers/net/sfc/sfc_flow.c > > > > > > index 5613d59a9..18387415e 100644 > > > > > > --- a/drivers/net/sfc/sfc_flow.c > > > > > > +++ b/drivers/net/sfc/sfc_flow.c > > > > > > @@ -371,7 +371,8 @@ sfc_flow_parse_vlan(const struct > > > > > > rte_flow_item > > > > > > *item, > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0* the outer tag and = the next matches the inner tag. > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0*/ > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (mask->tci =3D=3D supp_= mask.tci) { > > > > > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 vid =3D rte_bswap16= (spec->tci); > > > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* Apply mask to ke= ep VID only */ > > > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 vid =3D rte_bswap16= (spec->tci & mask->tci); > > > > > > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 if (!(efx_spec->efs_match_flags & > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0EFX_FILTER_MATCH_OUTER_VID)) { > > > > >=20 > > > > > Hi Andrew, > > > > >=20 > > > > > For which stable release branch is this patch intended? Has > > > > > it (or > > > > > an > > > > > equivalent) been merged into mainline? > > > >=20 > > > > Hi Luka, > > > >=20 > > > > Yes, the patch is applied in mainline [1]. > > > >=20 > > > > It would be good if it is applied to 17.11, 18.02 and 18.05 > > > > stable > > > > branches. > > > >=20 > > > > [1] > > > > https://git.dpdk.org/dpdk/commit/?id=3D8028142107a858a146bfdbaa01 > > > > 0b7e77 > > > > ff987342 > > > >=20 > > > > Thanks, > > > > Andrew. > > >=20 > > > Ok, thanks, in the future please use --subject-prefix=3D'PATCH > > > xx.yy' > > > with git send-email to indicate the target branch(es) > >=20 > > Sorry, but I'm not sure that I understand. It was a fix to mainline > > which should be applied to stable branches as well. > > As I understand PATCH xx.yy is applicable only when it is a > > dedicated > > patch to stable release. Am I missing something? >=20 > Oh yes, I'm sorry. I recall that it was test send and I've missed > that > stable@dpdk.org is included from the patch itself. > I'm sorry for confusion. >=20 > Andrew. Ah ok, I thought it was just for stable. No worries! --=20 Kind regards, Luca Boccassi