From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id DAE391B14C for ; Wed, 1 Aug 2018 12:07:18 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id f21-v6so6297342wmc.5 for ; Wed, 01 Aug 2018 03:07:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=t17IqMMMe5NHopVg4ejWDHlXUdiWLGEfcywXnI4p5RQ=; b=P6/77ur3O/qpsDV0cyYJ0Z1EGA/QMzFEGZTncLjbYNWFiFB8P+45XxXsIXOjKQMbBs AQwVYw9v70Wnz9+B8tPT3jbwAmKu7ea1osZL4wZkitrorz+ZLCQLEr4hy+GCAaNr15O/ +aOsXfB+g7XcSfSI3sN3h+nkNsG1ySxoILAylbVhiioESeNZLz5kIrPXlsYV42m2mbxS YvHdu6M/Xv1nRHDEXsU0AFzZL3tM2nmX2WsgQSVhf0BAyF/SIVgJxJaiT9mCi+2X4Qnc hZmusuYXuZBg5fhGkqbTY0u5cARkNSN24L8wCdRWC+iC3uDO448T7733+iVeM/Vu+jbh dmGw== X-Gm-Message-State: AOUpUlHR9CnmVGbuEEsRfwwxhXWsxRAqWdOVa7NTnwavm2ZER4N+W/bV WjtxTcIrjRWfsslxLmvP7U0= X-Google-Smtp-Source: AAOMgpchcikPdhY9Bq6rYaL9GvvKl8N6YKprlq24X2HgWiwj98HAto2f02pWj1AtiVpxz9RxMJKxPQ== X-Received: by 2002:a1c:b756:: with SMTP id h83-v6mr2447263wmf.8.1533118038432; Wed, 01 Aug 2018 03:07:18 -0700 (PDT) Received: from localhost ([2001:1be0:110d:fcfe:dc12:297:5785:c4fa]) by smtp.gmail.com with ESMTPSA id f18-v6sm13588330wrt.64.2018.08.01.03.07.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Aug 2018 03:07:17 -0700 (PDT) Message-ID: <1533118036.20916.56.camel@debian.org> From: Luca Boccassi To: Ophir Munk Cc: stable@dpdk.org Date: Wed, 01 Aug 2018 11:07:16 +0100 In-Reply-To: <1533076587-18997-1-git-send-email-ophirmu@mellanox.com> References: <1533076587-18997-1-git-send-email-ophirmu@mellanox.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH v1] net/mlx5: fix secondary process resource leakage X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2018 10:07:19 -0000 On Tue, 2018-07-31 at 22:36 +0000, Ophir Munk wrote: > When running testpmd with an mlx5 device and then executing at > testpmd > prompt in a raw: "port start all" followed by "port stop all" > a new file named /var/tmp/net_mlx5_ is created as a > result > of creating a new unix domain socket (used for communication between > the primary and secondary processes). > When the new unix socket file is created the old unix socket file > should > have been removed. This commit fixes it by closing the old unix > socket > just before creating the new one in function mlx5_socket_init() >=20 > Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file > descriptor") > Cc: stable@dpdk.org >=20 > Signed-off-by: Ophir Munk > --- > =C2=A0drivers/net/mlx5/mlx5_socket.c | 6 ++++++ > =C2=A01 file changed, 6 insertions(+) >=20 > diff --git a/drivers/net/mlx5/mlx5_socket.c > b/drivers/net/mlx5/mlx5_socket.c > index 99297d5..a3a5229 100644 > --- a/drivers/net/mlx5/mlx5_socket.c > +++ b/drivers/net/mlx5/mlx5_socket.c > @@ -36,6 +36,12 @@ > =C2=A0 int flags; > =C2=A0 > =C2=A0 /* > + =C2=A0* Close the last socket that was used to communicate > + =C2=A0* with the secondary process > + =C2=A0*/ > + if (priv->primary_socket) > + mlx5_socket_uninit(dev); > + /* > =C2=A0 =C2=A0* Initialise the socket to communicate with the secondary > =C2=A0 =C2=A0* process. > =C2=A0 =C2=A0*/ Hi, Has this (or a version of this) been merged in master? For which of the stable releases is this for? --=20 Kind regards, Luca Boccassi