patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] net/bonding: stop and deactivate slaves when bonding port is stopped
@ 2018-08-01 13:18 Radu Nicolau
  2018-08-01 13:44 ` [dpdk-stable] [dpdk-dev] " Chas Williams
  2018-08-02 13:38 ` [dpdk-stable] " Doherty, Declan
  0 siblings, 2 replies; 13+ messages in thread
From: Radu Nicolau @ 2018-08-01 13:18 UTC (permalink / raw)
  To: dev; +Cc: declan.doherty, chas3, Radu Nicolau, stable

When a bonding port is stopped also stop and deactivate all slaves.
Otherwise slaves will be still listed as active.

Fixes: 69bce062132b ("net/bonding: do not clear active slave count")
Cc: stable@dpdk.org

Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
 drivers/net/bonding/rte_eth_bond_pmd.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 16105cb..960140c 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -2229,12 +2229,15 @@ bond_ethdev_stop(struct rte_eth_dev *eth_dev)
 			tlb_last_obytets[internals->active_slaves[i]] = 0;
 	}
 
-	internals->link_status_polling_enabled = 0;
-	for (i = 0; i < internals->slave_count; i++)
-		internals->slaves[i].last_link_status = 0;
-
 	eth_dev->data->dev_link.link_status = ETH_LINK_DOWN;
 	eth_dev->data->dev_started = 0;
+
+	internals->link_status_polling_enabled = 0;
+	for (i = 0; i < internals->slave_count; i++) {
+		internals->slaves[i].last_link_status = 0;
+		rte_eth_dev_stop(internals->slaves[i].port_id);
+		deactivate_slave(eth_dev, internals->slaves[i].port_id);
+	}
 }
 
 void
-- 
2.7.5

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2018-09-28 11:04 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-01 13:18 [dpdk-stable] [PATCH] net/bonding: stop and deactivate slaves when bonding port is stopped Radu Nicolau
2018-08-01 13:44 ` [dpdk-stable] [dpdk-dev] " Chas Williams
2018-08-01 14:02   ` Radu Nicolau
2018-08-02 13:38 ` [dpdk-stable] " Doherty, Declan
2018-08-05 21:55   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2018-08-06 15:50     ` Chas Williams
2018-08-23 13:15       ` Ferruh Yigit
2018-08-23 15:21         ` Chas Williams
2018-08-24 10:39           ` Ferruh Yigit
2018-08-24 14:05             ` Chas Williams
2018-09-28 10:00               ` Ferruh Yigit
2018-09-28 10:03                 ` Ferruh Yigit
2018-09-28 11:04       ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).