From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0076.outbound.protection.outlook.com [104.47.32.76]) by dpdk.org (Postfix) with ESMTP id 8C3C71B513 for ; Fri, 3 Aug 2018 03:02:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eFPjOy42sPofvG9/JddMIKT8Ijxmxrxh3WLAYbyiKaM=; b=kpaIKkf8uGI/tmzgR0XR3T2NFniFQqtggK24f4gLNkM1ShDVP7gUwMASevwWsLSapRBGj39O9V4y2nMc9fGbmR05QMiPAb1JcIotciwmb9+28PgZAHgn7L+kF4tRCT5DGY4qmJFtJ1+NMYRs5wkd/sWBvZydjicUmcmxIs14O1k= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.1.5) by BYAPR07MB5365.namprd07.prod.outlook.com (2603:10b6:a03:64::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.15; Fri, 3 Aug 2018 01:00:53 +0000 From: Rasesh Mody To: stable@dpdk.org Cc: Shahed Shaikh , yskoh@mellanox.com, Dept-EngDPDKDev@cavium.com Date: Thu, 2 Aug 2018 18:00:31 -0700 Message-Id: <1533258032-11551-4-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1533258032-11551-1-git-send-email-rasesh.mody@cavium.com> References: <1533258032-11551-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [198.186.1.5] X-ClientProxiedBy: CO1PR15CA0061.namprd15.prod.outlook.com (2603:10b6:101:1f::29) To BYAPR07MB5365.namprd07.prod.outlook.com (2603:10b6:a03:64::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 48d06277-4a64-4ec1-1ffd-08d5f8dc9144 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB5365; X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB5365; 3:1KFnly89/ZfliytNxMSQX6EragOUl+a/rG2ZU2iXLvj6OJkWi5RVZ6zt1QiHKsJnZ6KttklfYfaqkWyTzLpcZQhd37nPxHXEJQDtPoSSZN7EOpiwy+IJ04GCLV0elqqe8iE0Ie26fJlvU/ufKQAtpyFqSGdqa5waOpP8cTYT+LGmXBV28ytSivgNV6BhJJful5zWVZYNkrJEXAr6IUpcZQ8cKZzoRSFAHVt7d+6Y908NXlCKrxKEW5Q+20rW9D5H; 25:MVWTIQCv3VHnMzP/4jy3Dmb/2KqTDBXdX9W+CbKlUbrZ2VYs140NWCq2g6Cv/yZ+Bm23BB4alIhur0rQobOvHsKH2ozSHm6Vvq0ZY0qRe5Xr+PLNT932IN1ql1fRgrvikly7pl1JEokyMq8tTZGtdHGsHzAgmcXi9t7SN930ixUugPfhuW50c5Fdsr+0kRoalH14TxTSiJVVW4LLnjSitf+I37AzoQx1Gk/QAicyoVpdjB+WFT7P7N4/OjE3dPHf00RyOgOC1HufpQBesB0ZVVbJpiP7BnB4hSfkH8u4LK9uNAtSQSgg8MJ/9nI0Izp0et0Pyuu7nEbjNGUfkqYdwQ==; 31:VXaSzoRPgd4Qk7qiOJHoHBW5qLJ3Ch0/56JLpILe2zb8ELGXrp/ZCGuYiwcOcakzBXUAoZeo+JTj1Esjk+2nYlDKnWAXAlGmtgwKSJYoN+cJfvdS66gENGtjqSGg+wpPBuTrgVtopT7inkVkDp2edCst8cwZV2c1Y+BmsXPQApkSRRE7xpquoO9vP5MMxTPGua+y/F9neo/wZPvpB1dqAzDfW5mUekSD1VYc4HPCDwk= X-MS-TrafficTypeDiagnostic: BYAPR07MB5365: X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB5365; 20:cTXq5cuJVAQeZ1TkcS4+GE3ajFXFJbKTOcR7gsxPmxgwtvcgiZVNPOqP7VMVYNtSHCCUeF39P9E9PZ7g5MxArN+C0CAUGbSnuBo6EgIBSiR14JZDsUjjC8uFa8OBGFYBK9QMqqArNIEl36n2RYtpQBk6XcU6t1W9c6vjfpZRDDtAW9m+IE2+JDeznIv5rWfaIgimcVSu4qz/g8cd6alB+3S11D+7O5mCbOaep2uFeqtsuMT11D6rKCYwRF/Lts54mqo+fhUQvbjgjTzPBHj9J46Wt+iu5fy+1o12dSy4XsdWnvUknJvJjya2Wedsw3Fbkrmf8DDnVgEkDMePfLxe4j0d4av4NNiS48oOxDCHgsyeGZy2wXyfUSENhDjmxxNISRBRS9dxsTRC2qQlBdibZM9prOA1bup9cjDcoDFVkhetS1TBoQaRaiHKAYg1avvIhB+OjtuwFa6uuX3zqD9POaIopKKREtbZ5bejTIiHDhjFavy+Wk7M/R+yTOTjhbU9; 4:6Se0OOFX57klQLbMOHAlDucGcBVIyaGYftfSTFVgLgi/NNnKwYsaNxTWwHq4pMA4I6qoOjzYB8WwCSaMvMByqSmq8edeqWe1MLF6IJZmfM580QAqpBR1HwgSAXSzQRDk16frD/QkPWokLbVzF3fr2sRiuZJKxqmjE0u3DT6ro+YFjZek1YmDMni8UVaI6my3KD1DX5tD2FP0gyuRxtwqj+SKmXKI2oOiYQIIQlFpN4URL9C8Rw6vZPZAbp44CWlKPX3pRQmBNUA8OCoraUILQg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231311)(944501410)(52105095)(10201501046)(3002001)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:BYAPR07MB5365; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB5365; X-Forefront-PRVS: 0753EA505A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(979002)(39860400002)(396003)(376002)(136003)(366004)(346002)(189003)(199004)(55016002)(305945005)(72206003)(3846002)(478600001)(52116002)(107886003)(2906002)(6916009)(21086003)(5660300001)(4720700003)(6666003)(97736004)(81156014)(81166006)(7736002)(51416003)(8936002)(8676002)(26005)(386003)(16526019)(186003)(6116002)(7696005)(86362001)(76176011)(106356001)(44832011)(446003)(4326008)(68736007)(11346002)(2616005)(956004)(486006)(476003)(14444005)(66066001)(105586002)(2351001)(25786009)(50226002)(48376002)(36756003)(16586007)(316002)(69596002)(47776003)(53936002)(50466002)(2361001)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB5365; H:cavium.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BYAPR07MB5365; 23:i6jFXRmSMOdWSVYNr9ZgWGO1Rc0iegox4SYZQwM0P?= =?us-ascii?Q?tbJhAIsXh2O8KUQlKtMYmTgEvTDoDKHdVGpqF1enE0OzaJm5WWxywFyTFNyM?= =?us-ascii?Q?FT2J3y21EzLuEy59pkYOB25zRpPlq+dqlzDWehcIfK3jYD869HJ/rUk4INqy?= =?us-ascii?Q?gL8ivgWfaey26NMVz2I80bH3JVbm/Lp79jHRF7qiUKCDja6b25r5MLi2rF57?= =?us-ascii?Q?TA+VXLaj9XZJBi5ahOi7KVvCwys2AM287gwjTnJSDyso/pe54CQuGY6PXHTI?= =?us-ascii?Q?9XN3YXE5kLAd6bkfajUfywSBOZ6Ld6xYif4xMKZYqhKODNc9CLwcVB5pmlVJ?= =?us-ascii?Q?iGyaKm7xT6oCn9gM1gpsEKlnaB22Xnl8olzUkkWDpGE/TefSnlCQZw7R7DFt?= =?us-ascii?Q?UnMwVRxOhCcsCANCLmiEVecEEO60Mxn4SjOzRvGck1FK4FgtA64hF9LuqtzR?= =?us-ascii?Q?hlOFQNT0NlXMqV21bMzpcGJhbbWqauRrn/z8r4pZUCUFsegqmTVgzChYEhGI?= =?us-ascii?Q?6MotUGl5ETvqVZQiDXMSrSbN1EV/91OBW6JrlL5MwYSkdKXgPOOPBT0M7l3u?= =?us-ascii?Q?N1HJt+3zO7D+fn09yJV155SCWit06FrVGcT+cmIuz7hF7cNERaOMQu32aLOv?= =?us-ascii?Q?wk3o9aojvPbUyFaEyGUprZHM5QUhAcQL0x3nq/ziki+Z68hBDi3cy9EaCyuH?= =?us-ascii?Q?H2AEpIClGVfdbzEjikaMN88Ebl3waQdt2B+EeIN6WyaLeEzU+aV2DQ9Xg3br?= =?us-ascii?Q?N7GGYvjeKaJJ/xFnwaxouRJHz8Iw2ovBNkhkTcXq80F1NF9kOX8wLqJq8dfX?= =?us-ascii?Q?ahaUW0jtJXj8xgvowRdnsz9DyuJ6h7wuT5M+k3gkHo8RQEzShs+swSO0IcwY?= =?us-ascii?Q?5HFra3XL2ICR1eEFhOK2SYVSf6dk8dUnr7CMdPqbAPUe5kXhfd6j9naF/i3n?= =?us-ascii?Q?Ot8eSOqxNkMaFNy1nCg6huZflBYMy5T7m/XUcG0Y0Aua8QlKiF9K6FnbXC9c?= =?us-ascii?Q?BCsxyGrOSaB24s+mLv+bsGVkhPZo1e3QntZIbWhyfQh5xTkLxjE8wxpM0o/G?= =?us-ascii?Q?zeyQzqNgSo+y169MyafnvN/j7AWvmZtgCV/2EjGZLRZywevH69s3OhX0oEjt?= =?us-ascii?Q?xHvOO5hmnk/5M4g0gpV0q4ioKtGSYRCDj5GX4tD5Cmw8QLSVLS/uANNjumGB?= =?us-ascii?Q?8PF3pZ6F0IbmGaJXG1ZINFELbbe64N4t412K4O0/0QPa4jwqfjeLvHENsxvG?= =?us-ascii?Q?UONcsI4DN2VB8GKExuqdLhID1OZ7RTNXxA5liVDviZ4+JRE2qSyvzgGQyrLO?= =?us-ascii?Q?p9zYBzqp2YKWZo9TDINabfvT+TeNzI+iZP7PNEC7jpEl8gleY5DYzGXwvgXP?= =?us-ascii?Q?W6chU4WfhKNaCLm6b4FUAPddJ/qoKHliEMRGXHYNceji1u7Doa3xG7OWhUzu?= =?us-ascii?Q?6dqEL/SnnFcZEFUwHKYSF2pt4rbZhs=3D?= X-Microsoft-Antispam-Message-Info: 9diiY9vQ6euZrUaQYd4B1O0a3gVTHj1uEALVkTRbZp2H1MH0hwMhLNxi07HQ0V2XmfJylvTosdA+SsZFmLmjbLWN30wNTeXbm0wfsf4RoiPWG4O469DD+ZFFi2fKaCTA191LO79Nohdaf24BuKN+YaIiqw8r7koWoFL3xpPq1K5XlgZ1krvAWAXKAw+H9ec6Qqw1eF2SGJLV3n+M8jS46Otnb5Jky4wVVHspLPxXpx4GD+qriLLy1SEbIIF3e0b81gBwPZKGFnO9XgtbpdcJFFk1TvCoOXGR5fMeeaa0Dq0tZslbOLAgoQXL7c0RjCd7NI9MC7xultgQUvSi9V+Ue8eIJffgLOrlsB5ZUEv7yqk= X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB5365; 6:bEG2n9elzcmkjzEzQLpxIGAZF2Eh3TmjBlNd3fcTqwf4nNwpCRvyWEIQTHlOkgvbkGS6UQC3pSQFCXGEIvjlgJ9TTN27TB6bZ3kQAgEk7Cc/DKEed12tOngFmT+Qabt+Kg9gFDqYmxGQ4dXV5aD6c/WbfK6ZpV9wZ57hEX64sjzLRjO9aU3gVQvTVv2r3ZIyYeBgUhPXhNwHXDstfMEZgaZa2eTD3lmVpK5yvNX4KqimO5rh0X34z054HmDkUtXOWn4OhcfGkHgVg6HWn5xByt0P4NLBu7tNj0UE7EZpaVRULGY3B11ub/AUVQogcnN4ob4YTWtGBx08IzuxOUHCBKaMmj0USLUwAb67fXV7TqfX/ePi8BNUH6yT15UdzMd80OIEJta5TFpyYHmROuZ5QxJLfz8r03anhzCAwxOACWAlZP6s4mn9/qHELf6Op28bk7+gO9Hrc4jJUbEeZm9LkA==; 5:XQGQ6M/F2KzLtkg+gcwmaxsfZW8Jz6fjriHr/pZQi0mr5XkAlvxeZb0e/Oo5GroQuItkL3w7kruvVN13OMznoYw+RdMwEjpYhXrxuDo9VhiMHyGoMYad9IKBHcbSlvbH6+mZvixdRdJNFJG4ChymzM0zm3M0BSdBCOODB+o5Xyw=; 7:bBgJz59fvwgrviKlb5GOTbAqvfoyra4FgTXRE537UfXI2GiUf6zo/SsfFtivN95rMguUeYrIMKZVpJaAEKkAdAKlD/dJK64/FL0ib14a3zXY3tXpJbMzVnvDpgElmKpI9Q3xh9PlJt/KTw1tiLz4Xrt7KVrQqBIdHYP6xXxp+aCrK9HMUDAz18k+GoybV4PC45Og8XAceuVytAdvTfiWuahKK/ii0bI5TZXEBHuER/s7pRgkHNgbgtYk0GKO3KZD SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2018 01:00:53.5202 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 48d06277-4a64-4ec1-1ffd-08d5f8dc9144 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5365 Subject: [dpdk-stable] [PATCH 17.11 4/5] net/qede: fix incorrect link status update X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Aug 2018 01:02:16 -0000 From: Shahed Shaikh [ upstream commit c6034a20d9e221dc6125db57e4378520af3a515d ] qede_link_update() always returns -1 i.e. link not changed, because it compares the variables which always hold same value. Fix this function by caching old link state and comparing it with new one. Fixes: 2ea6f76aff40 ("qede: add core driver") Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_ethdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 687104f..73947fc 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -1478,7 +1478,7 @@ static int qede_dev_configure(struct rte_eth_dev *eth_dev) { struct qede_dev *qdev = eth_dev->data->dev_private; struct ecore_dev *edev = &qdev->edev; - uint16_t link_duplex; + uint16_t link_duplex, old_link_status; struct qed_link_output link; struct rte_eth_link *curr = ð_dev->data->dev_link; @@ -1503,6 +1503,7 @@ static int qede_dev_configure(struct rte_eth_dev *eth_dev) curr->link_duplex = link_duplex; /* Link Status */ + old_link_status = curr->link_status; curr->link_status = (link.link_up) ? ETH_LINK_UP : ETH_LINK_DOWN; /* AN */ @@ -1514,7 +1515,7 @@ static int qede_dev_configure(struct rte_eth_dev *eth_dev) curr->link_autoneg, curr->link_status); /* return 0 means link status changed, -1 means not changed */ - return ((curr->link_status == link.link_up) ? -1 : 0); + return ((curr->link_status == old_link_status) ? -1 : 0); } static void qede_promiscuous_enable(struct rte_eth_dev *eth_dev) -- 1.7.10.3