From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0076.outbound.protection.outlook.com [104.47.32.76]) by dpdk.org (Postfix) with ESMTP id 20C961B50F for ; Fri, 3 Aug 2018 03:02:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H0yz2Ehf2/qbWooAXWPJQ2mQpXuGC+e9LmqpmXzjQiA=; b=hhtG5O8T23OkjP8OpZYQQFTb1e3LJbjh7yp085aLePN2BFoP3tx8C9huEDJenceMeTR6Oj64VxBTaNDQrO0aaRADEjmFnJkg3YJpLrO2fBO+0WvVkZMvonUBQBsc4s0Q2dxbOW98Qz1HIpgdePxar+t4M1+5U56ANFsL8xmUMyo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.1.5) by BYAPR07MB5365.namprd07.prod.outlook.com (2603:10b6:a03:64::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.15; Fri, 3 Aug 2018 01:00:56 +0000 From: Rasesh Mody To: stable@dpdk.org Cc: Shahed Shaikh , yskoh@mellanox.com, Dept-EngDPDKDev@cavium.com Date: Thu, 2 Aug 2018 18:00:32 -0700 Message-Id: <1533258032-11551-5-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1533258032-11551-1-git-send-email-rasesh.mody@cavium.com> References: <1533258032-11551-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [198.186.1.5] X-ClientProxiedBy: CO1PR15CA0061.namprd15.prod.outlook.com (2603:10b6:101:1f::29) To BYAPR07MB5365.namprd07.prod.outlook.com (2603:10b6:a03:64::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3ac1fef5-b605-4eb2-878c-08d5f8dc92e4 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB5365; X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB5365; 3:IIw8lBTR8VjM3a2hV60H8nV//WHpvYIcEzVF42Rxp17L0jVun0+Uki7vPAVmHIQ902vgrTQWhvpUH4DWYPkmY16xR17KOD3gqbyvTlC0MG9Zn17uMbs1tMORG9KY8hCD2i3BGC8I/4jPUh23kiOPRVC1j+TSWAYb1kJv2osWtanpOWpKD6Awr+QV/Yns32Y+Jq3DahK8YcVkJjX8WfR1jwJyopS5R3u03WNZc/geyMq4OtzOEJcrxTrZo4l7+0aT; 25:CLyUC44Nb80bbzYpCP16QP5Wnr4MwpPuXcyBVS14FKkkPknFeZaJAlHw4iJdEhdJVsvt3fqyy9VtjjhVFJF5LJJgdy8EMQoCKvUg5Hh6bvS1RFE3kiUY1jhNLSF4VQl90+SOv2aOgACmnEEb3oOQLDgvHdASNl3CF49mG8YdzS71zxoJqlgt63p6WGNBe3oBYYoJ5PBfuUcK0neW+kCFSrVh26RNGurZ8TQDtigrRRiC9ryvS61m3tOhcOa9BUM4bSL1NWGVGTb0RufKTe0EqfdEDBfh6/BAAR4jaLkjZr4LhT+7SxQPvBqW1StEEnYy+rqbf9ePTsPI7lU71+ZbMw==; 31:HQKv/gXqtxCUks6LGY1mfQFv4EbzV+FZufv5cRIPCek+9SaPQkwDerBq+KnjNS7HT5MpRUThFPnUkqc0477xsbhAF5wbvS4FJvykvicFKqfTG5++MCev173OyJS2bdzCyC1YV5uoHqUuGr4jLcLsHuDXtSbKltSUnXsVEp131hHyc2Ix20hSbYwXiLqiW5QIlIpZj9oz3OVmB4iTfFTAsjJulxIYderPAL1U4/idNT8= X-MS-TrafficTypeDiagnostic: BYAPR07MB5365: X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB5365; 20:pxLKaBV+LetPEBptKqMSmaAb8hwfOFjfDHfp5bnHjE85eSB++m9+li/1E68mIrgqbjMjZWi7IIbUOjRbKf9j/0EQKXU5fxQnzeHF2ZLheTSxzj/BobMtfvdBqmsNeY8iTDj9UgpDzTUV+q57h+liTprF1wloeqsV31uEiNe75IpFA1rkzWJ01rxWgIODzzpNt6FMHHgiMxhoeRY/p84amnWK4i5F70amJD/d1XIvnqMBHLGVYIV6W4jozB6VTBo1+ZymvSYh36Gl3HXpoJkx3xGrlQ5TNXtdKDVQRtDcygJSKjw5URqCuFAwIJ3/TK+nO6/TF9BTIQLwHmWE4pOOzk/X4fve3c/OmsFKMXMk8mZerYTlcVZTRcO4v+maO/8gFkYYsipODIwxyX02T5jvhi1b6Efqiv6P+ng56OvmFqLdbkELxInGxH++pgAeGnwJzJryd74sJHzgDBC0sd+dN2eIIEblkDgwnUbfTyvDxMxdacFNVN4gtphEcL2heCcu; 4:O9w/uU1PqbyWMC1G+Jm48L2RFS9J8hRS5EftzgsUT/PseVaBDDxuhKj8jc+6CEfj6XQNl+z++jrikzfUQApJRTnnfleZF+gG8JQFXyxDg8LTMZmXkQckMJoISnO4dUVJV06qYefxsplxoc22owt9dCRuzhMoN8W1/vthoXTQN06AADHe/QDB9myqyfSi76Q1+0PETB4VyqixjoElN5+wwkOvYgudDhkj52vACaa0dSV81q0HDMFDkWcceWUJ6M350hD87W63O0RzYowVov3kqw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231311)(944501410)(52105095)(10201501046)(3002001)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:BYAPR07MB5365; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB5365; X-Forefront-PRVS: 0753EA505A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(376002)(136003)(366004)(346002)(189003)(199004)(55016002)(305945005)(72206003)(3846002)(478600001)(52116002)(107886003)(2906002)(6916009)(21086003)(5660300001)(4720700003)(6666003)(97736004)(81156014)(81166006)(7736002)(51416003)(8936002)(8676002)(26005)(386003)(16526019)(186003)(6116002)(7696005)(575784001)(86362001)(76176011)(106356001)(44832011)(446003)(4326008)(68736007)(11346002)(2616005)(956004)(486006)(476003)(14444005)(66066001)(105586002)(2351001)(25786009)(50226002)(48376002)(36756003)(16586007)(316002)(69596002)(47776003)(53936002)(50466002)(2361001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB5365; H:cavium.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BYAPR07MB5365; 23:KBTl4xf/n4nSnJhHRsbtEGyZR2+UaPDzI2qMym1ys?= =?us-ascii?Q?tehZoxxEC3Egm2Jk7AzaWPvXZARkdr6SJf1TYpyZ0+0xCLz+GFJYZ8ZkP5U+?= =?us-ascii?Q?QgLMRrit9G5gf1/xwYi5FuxyAUoetP/gg+B/lt/nC1LxvZOgEpJ44ztRicrK?= =?us-ascii?Q?d5RHxGytC2qZQgxqM+C23jGfzj6NNM6CFNkQZs91pwOcWCSbuGjCv26E0egn?= =?us-ascii?Q?ljqyHpp8FScNv5IdrAJkd2pYbAzRNuzpxFgNuaU+ljeKkAIPvpmOw9612S+7?= =?us-ascii?Q?/GKLyKa67+Z4PuMkHHPziwBu4JRs1IsNW5n3nXcbnhV2qxQiSEjLINbfINRB?= =?us-ascii?Q?G0htTEHRrvn60mR9iaa8lwpmnY3tXinYyiUuS754ylnpEf+8eFrMj4CekdUO?= =?us-ascii?Q?Me3jLrBRbEYmPsqbgQfgpLMDYgMtgAMuJ4QTHisR4wtLN2YPUvFfk2YtbjE+?= =?us-ascii?Q?VbhdKCF1/d6zXJM93g6+oCSC3/Bef8gzSl/vI9sqNtaKVDH6Mp7mr5hTvu7k?= =?us-ascii?Q?APY2oSPHBN20zhbA1++uNk9PBVWoqVTW3KPWm8xWEWxjAuPOjY42huhe0Ox/?= =?us-ascii?Q?NjOtohtIiSM2FvaGN8f2GbjQCLIydspPDg3F7MhiPWTF2R1ylcrrRkctks/g?= =?us-ascii?Q?yfuitxT69y+7yosYS9UnKFgqUYmMDTqnjBBOy3ajXFEEOXCyetZPFy5tNmBw?= =?us-ascii?Q?8v8ZCiUGTjdrnVihQ0saJBd6oFu6BsPZW9WtbXOjLZxD3Z5mhMZdgg4vSPEc?= =?us-ascii?Q?gHHzljfOxmnd/2yogJk99ANGhyKzsHFliDRralaDpTxUw/iMS4S7R5sRoKG0?= =?us-ascii?Q?sMbPKawphVfumNgu5HgYWdIVrmGPiesdeimMSH+Uz6cjagWJ5IMs4LF3Guhn?= =?us-ascii?Q?6ZtD+f7XgecVm1FZVs5bNjgH1RuO+1WeGBQm01o11FMo+oHHOZGVD28Jj22f?= =?us-ascii?Q?c1Tuxq/+rNT5VfKtym6JkbWvKUclpGziuALoSB/ruDMk+WEgq1v3DLrbbvEj?= =?us-ascii?Q?8aWtMnmpQXTMjNtXIcSBZzKquuQNVypaL5zw4PPGBVLsFGTXHkYoT8iiFsDQ?= =?us-ascii?Q?GLMdyo6CWcYvpE5fR5EAw+wuGofrZjW+03yb9vffhZ6WpZ4m6Cx2m1x2FMLZ?= =?us-ascii?Q?i6OzncB25kXqN80Gs330gHYRqRUea70vUdlUKQVaNncHTEX8ARnUkmH65N8L?= =?us-ascii?Q?f/fgvH0dyPMZ0shjgQn8d0auXteo26wuAcmyLnGM85XBktnMZHiEph1Z0Dhr?= =?us-ascii?Q?hKUOnj5RECDUk/88yW4h2cVrV2PowT3jJYKLh7hb4yAMo5HvJYe8VDiLuq7K?= =?us-ascii?Q?sJ63XV28I3b8LexpU8a7q3VZLKKs4QRAvfFrcFWAMFCL2ZZ0/JO+BlcXb5JS?= =?us-ascii?Q?zPe8A=3D=3D?= X-Microsoft-Antispam-Message-Info: Yl2RGoNkR+w19IEuFwLpeVK6Q9utmRMz3BQBIj87LpUERAfSw2ZfCquTGAIjDj1n8EERa/7avrL59mqnTbioA1Jf6HbqhfXhctomLYoH/pKYL07ZjA2FzShAVNKBiSr0RxynPk46l73AEM3mLeHkQvn3sOfZsKLWZ0kxWNt32sJG9xzgjAXPfZ8IIse+uNpgJ8Uw9Qbh1zjd79hxje2wBaWJDvY3scCn4MKRAmOEiU+AuqLHs9RBCdl06iKVgsht67H/3eXRhOUn8jx0KzBQbsGwRKS6gzBkjXhJ9OQGT0u+Oa6+5GCTpG/npAf5DDPA9gbQva10isSUNSiLD5Y9ijW2MSq2qmP7fZRkYtv0fQo= X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB5365; 6:D9GpBSRHDp6agrd2pifZGllFYwPvzrqrs146XyGQ/aq8zN1K+HFjcrzAOibKn1+WBfiuD7nJpRps6rQKGlnZeJeTbvO26+UvD71so+4b9Obesp3C7U7uavIWdYiNM05K6XyLMRMCl9DWOV4odaAQBZjW0gt27WNAZH1odXMVBMYlCZTmr7nCgM4MieX+bn6YjmZx9041CfIavMG2UBfwjeZyeOKkqCDUQ+T2B5WI+hkxp+93fEKL6stP2ejJTwb57cMb8WSV8xNH55sUOWNMmNGclU8/aIBIvN6yjrwKieN/qeV21Xp8O/cd1VPuygIGjDb08KqnLlFp3fVYKD/UXa/fh/HZmjm6SJcEtWkY451cP0v1/97FA+BaWOvbOBNzM3pXmUw3UyCtjSp7/YZc7WNCHZGnN8zg4JdD+0AU/grspGNRG+k1hMHBor57NaufJERfcXgctbS0w0NZHNbJZA==; 5:IscQqBP29KiAyml2FpnardVuqaWYu8tUQYuHvpm4OQyqK8BYl634jjyfwfKpESIDriZlNIzpf/+JaCyYs3RALVQPLrbhrZHz6iMqRMkv9HAOiDuhPy1CTGnxXeKVjbqmVqdTEnjDAllDNrG5tQKVHPPWRXUGAdW/wlQfXc2IKrc=; 7:oGtnWfZetH1ehVV9xO0D4OCyf6bR+JSblCtKDx89kK8Ikz2/LPb/o9E6NXt+V7tKAuTLHOySzKdS1J4VftFSOEBTbp5OV+M04mXJtx1pLxHnLzSrw946XPqEhteVRjorCAsupIaSxj/atLdThcgR4kcVJp1f5o6Dp+aGVgcLO/P+pC4f5/J395S7Koz7iEUaI1aTlENA9IHKxE/JdY3ZGFCbfkfK+ym77ha7xPtoYs6SLghYnDxCrfAYEuU9YYlv SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2018 01:00:56.2311 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3ac1fef5-b605-4eb2-878c-08d5f8dc92e4 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5365 Subject: [dpdk-stable] [PATCH 17.11 5/5] net/qede: fix unicast MAC address handling in VF X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Aug 2018 01:02:15 -0000 From: Shahed Shaikh [ upstream commit c7641841af2aaf05bca987a5a0eff5a7fe96caeb ] We did not register unicast mac configuration handlers for VF causing failure in bonding of VFs. Also, mac_addr_set operation requires mac_remove followed by mac_add. Fixes: 86a2265e59d7 ("qede: add SRIOV support") Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_ethdev.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 73947fc..89f6ce0 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -859,7 +859,11 @@ static int qede_del_mcast_filters(struct rte_eth_dev *eth_dev) struct ecore_filter_ucast ucast; int re; + if (!is_valid_assigned_ether_addr(mac_addr)) + return -EINVAL; + qede_set_ucast_cmn_params(&ucast); + ucast.opcode = ECORE_FILTER_ADD; ucast.type = ECORE_FILTER_MAC; ether_addr_copy(mac_addr, (struct ether_addr *)&ucast.mac); re = (int)qede_mac_int_ops(eth_dev, &ucast, 1); @@ -881,6 +885,9 @@ static int qede_del_mcast_filters(struct rte_eth_dev *eth_dev) return; } + if (!is_valid_assigned_ether_addr(ð_dev->data->mac_addrs[index])) + return; + qede_set_ucast_cmn_params(&ucast); ucast.opcode = ECORE_FILTER_REMOVE; ucast.type = ECORE_FILTER_MAC; @@ -906,6 +913,7 @@ static int qede_del_mcast_filters(struct rte_eth_dev *eth_dev) return; } + qede_mac_addr_remove(eth_dev, 0); qede_mac_addr_add(eth_dev, mac_addr, 0, 0); } @@ -2824,6 +2832,9 @@ int qede_dev_filter_ctrl(struct rte_eth_dev *eth_dev, .mtu_set = qede_set_mtu, .udp_tunnel_port_add = qede_udp_dst_port_add, .udp_tunnel_port_del = qede_udp_dst_port_del, + .mac_addr_add = qede_mac_addr_add, + .mac_addr_remove = qede_mac_addr_remove, + .mac_addr_set = qede_mac_addr_set, }; static void qede_update_pf_params(struct ecore_dev *edev) @@ -3004,7 +3015,7 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf) ECORE_LEADING_HWFN(edev), vf_mac, &is_mac_forced); - if (is_mac_exist && is_mac_forced) { + if (is_mac_exist) { DP_INFO(edev, "VF macaddr received from PF\n"); ether_addr_copy((struct ether_addr *)&vf_mac, ð_dev->data->mac_addrs[0]); -- 1.7.10.3