From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 041381B539 for ; Fri, 3 Aug 2018 11:05:34 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id q8-v6so5606122wmq.4 for ; Fri, 03 Aug 2018 02:05:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=MdlJmYVFzmL6YKg9D346gHmTKmHx2t/xqHHbatJ8VM4=; b=TFAOAdUJ98ECsZmDP97MQWtT3kkMzabE/d9HD/fwlRV56UZTyv2ucbbt4kAz3rrfxV HZkjQYRfZ8PnquWt1NQoP12gIRCxjThZStctEfoxhrgiwd0ZnE2YmqzZ9q+jjwefQnG2 D11HUs2o23JVlYgkXXSw23dhGYoPLkML4j/x6Nftj6hkxedbQSxpoSpZuWn84rym/xr2 YC9SqxiKwn1v/jY4g67CyLIUe+uWvltMvqf0jSyUR7J1Y53S5mZyUlcGEqSEJ/qQ7Vsu gQwp1bojrpli2sRjrwN8M1p0NOwVQ0vUxEztjEo3ojbk+GfDGQiYWgqo3s+k6HE2IQMd Bn7A== X-Gm-Message-State: AOUpUlGyXeZJ5DpJdYf/BVG1ei8m8YiZCn+fJcQduSX4LYu/9n2iADqH HzzT9txzwfY68NI9hOl37IA= X-Google-Smtp-Source: AAOMgpeO3YIG2UHVdp8a0wzcQ4dIY7sVxbEv2gP7lK81QJO5pIKKYM+9HFNaAhh+b3cSzfI6wij5cw== X-Received: by 2002:a1c:1fc6:: with SMTP id f189-v6mr4176180wmf.12.1533287133684; Fri, 03 Aug 2018 02:05:33 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id j8-v6sm1364338wrp.11.2018.08.03.02.05.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 Aug 2018 02:05:32 -0700 (PDT) Message-ID: <1533287131.20916.63.camel@debian.org> From: Luca Boccassi To: Hyong Youb Kim , stable@dpdk.org Cc: johndale@cisco.com Date: Fri, 03 Aug 2018 10:05:31 +0100 In-Reply-To: <20180803043304.12175-1-hyonkim@cisco.com> References: <20180803043304.12175-1-hyonkim@cisco.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 16.11] net/enic: do not overwrite admin Tx queue limit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Aug 2018 09:05:34 -0000 On Thu, 2018-08-02 at 21:33 -0700, Hyong Youb Kim wrote: > [ backported from upstream commit > 2a7e3d54659cd12d337ad816dcf202eec1af1367 ] >=20 > Currently, enic_alloc_wq (via rte_eth_tx_queue_setup) may overwrite > the admin limit with a lower value. This is wrong as seen in the > following sequence. >=20 > 1. UCS admin-set Tx queue limit (config.wq_desc_count) =3D 4096 > 2. Set up tx queue with 512 descriptors > =C2=A0=C2=A0=C2=A0The admin limit (config.wq_desc_count) becomes 512. > 3. Stop ports and now set up Tx queue with 1024 descriptors. > =C2=A0=C2=A0=C2=A0This fails because 1024 is greater than the admin limit= (512). >=20 > Do not modify the admin limit, and when queried, report the current > number of descriptors instead of the admin limit. The rx queue setup > (enic_alloc_rq) does not this problem. >=20 > Fixes: fefed3d1e62c ("enic: new driver") >=20 > Signed-off-by: Hyong Youb Kim > Reviewed-by: John Daley > --- > =C2=A0drivers/net/enic/enic_main.c | 30 ++++++++++++++---------------- > =C2=A01 file changed, 14 insertions(+), 16 deletions(-) Thanks, applied and pushed to dpdk-stable/16.11. --=20 Kind regards, Luca Boccassi