From: Luca Boccassi <bluca@debian.org>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH 16.11] net/bnxt: fix close operation
Date: Fri, 10 Aug 2018 10:07:36 +0100 [thread overview]
Message-ID: <1533892056.15446.15.camel@debian.org> (raw)
In-Reply-To: <20180810011139.99348-1-ajit.khaparde@broadcom.com>
On Thu, 2018-08-09 at 18:11 -0700, Ajit Khaparde wrote:
> [backported from commit 3c2e87c10b6f2c249a26e419b565bff5589b4637]
>
> We are not cleaning up all the memory and also not unregistering
> the driver during device close operation. This patch fixes the issue.
>
> Fixes: 893074951314 ("net/bnxt: free memory in close operation")
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c
> b/drivers/net/bnxt/bnxt_ethdev.c
> index 86c2a8108..44bf6ba98 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -137,6 +137,7 @@ static struct rte_pci_id bnxt_pci_id_map[] = {
> ETH_RSS_NONFRAG_IPV6_UDP)
>
> static void bnxt_print_link_info(struct rte_eth_dev *eth_dev);
> +static int bnxt_dev_uninit(struct rte_eth_dev *eth_dev);
>
> /***********************/
>
> @@ -586,6 +587,8 @@ static void bnxt_dev_close_op(struct rte_eth_dev
> *eth_dev)
> rte_free(bp->grp_info);
> bp->grp_info = NULL;
> }
> +
> + bnxt_dev_uninit(eth_dev);
> }
>
> static void bnxt_mac_addr_remove_op(struct rte_eth_dev *eth_dev,
Thanks, applied and pushed to dpdk-stable/16.11.
--
Kind regards,
Luca Boccassi
prev parent reply other threads:[~2018-08-10 9:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 1:11 Ajit Khaparde
2018-08-10 9:07 ` Luca Boccassi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1533892056.15446.15.camel@debian.org \
--to=bluca@debian.org \
--cc=ajit.khaparde@broadcom.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).