From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id A83F32C5 for ; Fri, 10 Aug 2018 11:07:38 +0200 (CEST) Received: by mail-wr1-f65.google.com with SMTP id h15-v6so7626093wrs.7 for ; Fri, 10 Aug 2018 02:07:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=ZkKsI1TnMiCiSTkIrWB/JQzkqZ/BY/nVEb50Ntu0xUM=; b=ZWuBcn1QzdNxkqojYLS+3mKayYfPlbIgibRPcvw5ZQTS6cGrtiW75nSnsOg/yQslTc /EwX+Yv8bXGgCUthy0h7sWdw67BuQutfRpRW+ke3Hk8E4R66SrijachdhADjngqn+ncv e+6Z5Bz8SwK70vt+jD3pjWGxk9IDaNQ4OpmfYE5yZcMtXVp0Os+L4CK6yt+QdGmpOIcd gMuycE7GxEaiOqWc2HYrjVyem/wMmBnK/+55HUtwXXbLmM0Nr4+7xpq8ujFc+qDHQLYN cXdZehf9aR3N+FcoXlKDbNx6fxyew2ozfE6YU1w/o3AMpo5Qu7uqVhJ/o1eFC57QiyVo nH/A== X-Gm-Message-State: AOUpUlH62IZWJY6x3QzBtyXFLuwTXt/lnvLSNqeXFuVMAssyW0RVe+NQ 6fMZrk/anNBo6Bc7AzV6jiQ= X-Google-Smtp-Source: AA+uWPwCmx/vccV/bOEnFK7Kt8ebCpxN27rQPWfeRVpatvww76na8oUVxRIQ4rVXoQCiANCdUnAjXg== X-Received: by 2002:adf:a3d6:: with SMTP id m22-v6mr3708114wrb.1.1533892058433; Fri, 10 Aug 2018 02:07:38 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id g18-v6sm632347wmh.21.2018.08.10.02.07.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 10 Aug 2018 02:07:37 -0700 (PDT) Message-ID: <1533892056.15446.15.camel@debian.org> From: Luca Boccassi To: Ajit Khaparde , stable@dpdk.org Date: Fri, 10 Aug 2018 10:07:36 +0100 In-Reply-To: <20180810011139.99348-1-ajit.khaparde@broadcom.com> References: <20180810011139.99348-1-ajit.khaparde@broadcom.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 16.11] net/bnxt: fix close operation X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 09:07:38 -0000 On Thu, 2018-08-09 at 18:11 -0700, Ajit Khaparde wrote: > [backported from commit 3c2e87c10b6f2c249a26e419b565bff5589b4637] >=20 > We are not cleaning up all the memory and also not unregistering > the driver during device close operation. This patch fixes the issue. >=20 > Fixes: 893074951314 ("net/bnxt: free memory in close operation") >=20 > Signed-off-by: Ajit Khaparde > --- > =C2=A0drivers/net/bnxt/bnxt_ethdev.c | 3 +++ > =C2=A01 file changed, 3 insertions(+) >=20 > diff --git a/drivers/net/bnxt/bnxt_ethdev.c > b/drivers/net/bnxt/bnxt_ethdev.c > index 86c2a8108..44bf6ba98 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -137,6 +137,7 @@ static struct rte_pci_id bnxt_pci_id_map[] =3D { > =C2=A0 ETH_RSS_NONFRAG_IPV6_UDP) > =C2=A0 > =C2=A0static void bnxt_print_link_info(struct rte_eth_dev *eth_dev); > +static int bnxt_dev_uninit(struct rte_eth_dev *eth_dev); > =C2=A0 > =C2=A0/***********************/ > =C2=A0 > @@ -586,6 +587,8 @@ static void bnxt_dev_close_op(struct rte_eth_dev > *eth_dev) > =C2=A0 rte_free(bp->grp_info); > =C2=A0 bp->grp_info =3D NULL; > =C2=A0 } > + > + bnxt_dev_uninit(eth_dev); > =C2=A0} > =C2=A0 > =C2=A0static void bnxt_mac_addr_remove_op(struct rte_eth_dev *eth_dev, Thanks, applied and pushed to dpdk-stable/16.11. --=20 Kind regards, Luca Boccassi