From: Luca Boccassi <bluca@debian.org>
To: Kevin Traynor <ktraynor@redhat.com>, stable@dpdk.org
Cc: christian.ehrhardt@canonical.com, yskoh@mellanox.com
Subject: Re: [dpdk-stable] [RFC stable-scripts v2] 1-import: don't filter commits for later releases that fix backported patches
Date: Mon, 08 Oct 2018 12:17:52 +0100 [thread overview]
Message-ID: <1538997472.8721.20.camel@debian.org> (raw)
In-Reply-To: <fb3045a8-a7d6-c019-df11-708ef6bfafac@redhat.com>
On Mon, 2018-10-08 at 11:58 +0100, Kevin Traynor wrote:
> On 09/25/2018 01:36 PM, Luca Boccassi wrote:
> > A patch might fix a commit in a later release and so it is skipped.
> > But
> > that commit might have been backported in the past, so skipping the
> > patch is wrong.
>
> Just a minor thing, but I was a bit confused by the first sentence
> above. It was clear when I read the code/comment. How about rewording
> to
> something like: A patch might fix a commit that has already been
> backported to the stable branch but is not yet part of a stable
> release.
>
>
> Acked-by: Kevin Traynor <ktraynor@redhat.com>
Thanks, changed and pushed
--
Kind regards,
Luca Boccassi
prev parent reply other threads:[~2018-10-08 11:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 18:07 [dpdk-stable] [RFC stable-scripts] " Luca Boccassi
2018-09-25 12:36 ` [dpdk-stable] [RFC stable-scripts v2] " Luca Boccassi
2018-10-08 9:02 ` Luca Boccassi
2018-10-08 10:58 ` Kevin Traynor
2018-10-08 11:17 ` Luca Boccassi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1538997472.8721.20.camel@debian.org \
--to=bluca@debian.org \
--cc=christian.ehrhardt@canonical.com \
--cc=ktraynor@redhat.com \
--cc=stable@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).