* [dpdk-stable] [PATCH v4 1/8] net/mlx5: fix flow counters creation
[not found] ` <1540289032-29628-1-git-send-email-viacheslavo@mellanox.com>
@ 2018-10-23 10:04 ` Slava Ovsiienko
0 siblings, 0 replies; 2+ messages in thread
From: Slava Ovsiienko @ 2018-10-23 10:04 UTC (permalink / raw)
To: Slava Ovsiienko; +Cc: dev, stable
The Flow counter creation function contains two problems:
- Flow counter object in Verbs is not freed in case of memory
allocation error. The call of counter Verbs object deallocating
function is added to fix.
- The initial value of reference counter is set to one in order
to provide the correct counter object freeing in the
flow_verbs_counter_release() function. The reference counter
field should be initialized to one.
Fixes: 60bd8c9747e8 ("net/mlx5: add count flow action")
Cc: stable@dpdk.org
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
---
drivers/net/mlx5/mlx5_flow_verbs.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/mlx5/mlx5_flow_verbs.c b/drivers/net/mlx5/mlx5_flow_verbs.c
index 4ae974b..6ddb13b 100644
--- a/drivers/net/mlx5/mlx5_flow_verbs.c
+++ b/drivers/net/mlx5/mlx5_flow_verbs.c
@@ -72,6 +72,7 @@
}),
.hits = 0,
.bytes = 0,
+ .ref_cnt = 1,
};
if (!tmpl.cs) {
@@ -80,6 +81,7 @@
}
cnt = rte_calloc(__func__, 1, sizeof(*cnt), 0);
if (!cnt) {
+ claim_zero(mlx5_glue->destroy_counter_set(tmpl.cs));
rte_errno = ENOMEM;
return NULL;
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [dpdk-stable] [PATCH v4 1/8] net/mlx5: fix flow counters creation
[not found] ` <1540289541-30019-1-git-send-email-viacheslavo@mellanox.com>
@ 2018-10-23 10:12 ` Slava Ovsiienko
0 siblings, 0 replies; 2+ messages in thread
From: Slava Ovsiienko @ 2018-10-23 10:12 UTC (permalink / raw)
To: Shahaf Shuler; +Cc: Slava Ovsiienko, stable
The Flow counter creation function contains two problems:
- Flow counter object in Verbs is not freed in case of memory
allocation error. The call of counter Verbs object deallocating
function is added to fix.
- The initial value of reference counter is set to one in order
to provide the correct counter object freeing in the
flow_verbs_counter_release() function. The reference counter
field should be initialized to one.
Fixes: 60bd8c9747e8 ("net/mlx5: add count flow action")
Cc: stable@dpdk.org
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
---
drivers/net/mlx5/mlx5_flow_verbs.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/mlx5/mlx5_flow_verbs.c b/drivers/net/mlx5/mlx5_flow_verbs.c
index 4ae974b..6ddb13b 100644
--- a/drivers/net/mlx5/mlx5_flow_verbs.c
+++ b/drivers/net/mlx5/mlx5_flow_verbs.c
@@ -72,6 +72,7 @@
}),
.hits = 0,
.bytes = 0,
+ .ref_cnt = 1,
};
if (!tmpl.cs) {
@@ -80,6 +81,7 @@
}
cnt = rte_calloc(__func__, 1, sizeof(*cnt), 0);
if (!cnt) {
+ claim_zero(mlx5_glue->destroy_counter_set(tmpl.cs));
rte_errno = ENOMEM;
return NULL;
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-23 10:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1539962470-10950-1-git-send-email-viacheslavo@mellanox.com>
[not found] ` <1540289032-29628-1-git-send-email-viacheslavo@mellanox.com>
2018-10-23 10:04 ` [dpdk-stable] [PATCH v4 1/8] net/mlx5: fix flow counters creation Slava Ovsiienko
[not found] ` <1540289541-30019-1-git-send-email-viacheslavo@mellanox.com>
2018-10-23 10:12 ` Slava Ovsiienko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).