From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40074.outbound.protection.outlook.com [40.107.4.74]) by dpdk.org (Postfix) with ESMTP id B678E1B46D for ; Tue, 23 Oct 2018 12:12:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1I1/gp05ITbNWr48u+k9oHhwW+5T/VNpGR7M5Gogq30=; b=Nrpv4tJYygFBs6zTYGcZj1AN4VDlGRq9UZ4d3AShbteOQCx6vdRcvovY9XS5KjvWUWU/op3EwY1qCe15H6VowUEW3O9UMXhSR62JXipM8nI6CI9MsvjxGyqXqG4n8znquVdktKMiUiQ3ngV7SHQmsUG+wxCOwoL5//v9Mm2TDm0= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.186.150) by AM4PR05MB3457.eurprd05.prod.outlook.com (10.171.187.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1250.30; Tue, 23 Oct 2018 10:12:54 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::477:2091:24b4:439f]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::477:2091:24b4:439f%4]) with mapi id 15.20.1250.028; Tue, 23 Oct 2018 10:12:54 +0000 From: Slava Ovsiienko To: Shahaf Shuler CC: Slava Ovsiienko , "stable@dpdk.org" Thread-Topic: [PATCH v4 1/8] net/mlx5: fix flow counters creation Thread-Index: AQHUarj2RYtU5KuC3UisO54h9NCVvw== Date: Tue, 23 Oct 2018 10:12:53 +0000 Message-ID: <1540289541-30019-2-git-send-email-viacheslavo@mellanox.com> References: <1539962470-10950-1-git-send-email-viacheslavo@mellanox.com> <1540289541-30019-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1540289541-30019-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: CWLP265CA0280.GBRP265.PROD.OUTLOOK.COM (2603:10a6:401:5c::28) To AM4PR05MB3265.eurprd05.prod.outlook.com (2603:10a6:205:4::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [37.142.13.130] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR05MB3457; 6:itqaDpz71sXeopRcWJeddqE9MecRZaltKFNvEBdEY0mWWk6xXHrI/pzWiZC8fVqPrgF1o8LuFg2gldeH56EP2mgsjokvxSdIF024kv57mA/2fZhddn1CqmZIefUFYYY/GP4OkJ4dCwgOe2MiSgCZgUA49kh8w4aeWcJXBM/K0wAqv5fMvHWsQ3EFwxeIstFvGd5uf7S9fXtC1Gl4B6UydmWfn9E1fLbp90SKfBjX6ALwg/otLpe08n43XD420mtTAV73AGErhSQoW84EeJCo27foi7TtDAZ9sB+JWMVh9NWuYrIu68SjKtAkH4u7McqBI4EiJroLGHvGQPbJypoMBhRCkZ613t/L/WtiQKlPY0HuycNI/PiIqTMjMpNPDJvQIDsIJ12o6Lg4MFjkVYRAGlPd8upRcLBs9Z1b/SGoNd/v/xoPvVhUhSYG52EmbzsdXZ6kOSwT4btScZMTg2FOmQ==; 5:Z0acLTqtIRG5KxI7KNF9ooW4DcZNDWHK8gMoWlVs+cN1CM+89lGdwlpvzBMfZjbEjkW2KfruSjAGOKih8UQvdRdQAdPz8iUpkVzoSiBnONgrNlZJsGThucSCyRfxtSAX1qXLjNOFYV9ujGZrdQunpU3qjsh/naGHCtuzSSlmu4Y=; 7:ntBdbpz9igCRFL5SQWFkTWxvv3snzvgpoScgiwXLNbApoWYeDUKDJClqW65l4v2piTjvnGMCfuFP2MUKmaDnkX4KjSVLTBFpaEJ9X7lmjJGSS7JOjLkMr2odsFESRzuYgMthxGGc3WnfDnjpP6WNQQoPd7nM4faMwsohrftZ13KhSePtphuKwGF6/5+Gd6j+aCImKOC1UquGaR8aQjXjnELve6pcpgB8d4s8iWmGTfzmLV5UbI8xiSBNBaz9V0WY x-ms-office365-filtering-correlation-id: c5e5e976-c5c8-411b-db07-08d638d01893 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM4PR05MB3457; x-ms-traffictypediagnostic: AM4PR05MB3457: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231355)(944501410)(52105095)(10201501046)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(20161123564045)(201708071742011)(7699051)(76991095); SRVR:AM4PR05MB3457; BCL:0; PCL:0; RULEID:; SRVR:AM4PR05MB3457; x-forefront-prvs: 0834BAF534 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39860400002)(376002)(396003)(366004)(136003)(189003)(199004)(6862004)(316002)(256004)(3846002)(71200400001)(71190400001)(2906002)(14454004)(478600001)(6116002)(5250100002)(36756003)(106356001)(105586002)(66066001)(97736004)(6436002)(186003)(476003)(6486002)(386003)(486006)(6512007)(68736007)(102836004)(52116002)(99286004)(446003)(76176011)(86362001)(81166006)(8936002)(26005)(11346002)(5660300001)(2616005)(7736002)(54906003)(37006003)(305945005)(81156014)(6506007)(14444005)(6636002)(53936002)(25786009)(2900100001)(8676002)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3457; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: xTt4p1Xmqi0cXmd44VzS+nldyGJUO/wlfgyfWDOtvlSxfdBe+MlD25NsG6SaftvNtWHlhHaqZ1Ippdya0/9GFA2XtYfib43DTTcnP0tlVKblQWnKXngdmbSlYfuy5btDQqnmyEj2Frpjvqn6F1wFv1YjE66uxz4iWflKVsYFvsF4VNj4WgaabR5vcZUyjYBEJ80ST6enfoSBC3qo27PZ77aCyTtrqDbTOnePuYlv8ulkGtZocmCxFofwzgPISN2AykAPXjmdSKs3/idgdTvR/vpPpdbzZhfnyhxOfeD5zHhWaFA6dtVLWLtGl74ydSfOsuwy5UWV4Gi6FLUjLM6HBrz5tYXI2wvJ1sIrFrguVVY= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5e5e976-c5c8-411b-db07-08d638d01893 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2018 10:12:53.9662 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3457 Subject: [dpdk-stable] [PATCH v4 1/8] net/mlx5: fix flow counters creation X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2018 10:12:55 -0000 The Flow counter creation function contains two problems: - Flow counter object in Verbs is not freed in case of memory allocation error. The call of counter Verbs object deallocating function is added to fix. - The initial value of reference counter is set to one in order to provide the correct counter object freeing in the flow_verbs_counter_release() function. The reference counter field should be initialized to one. Fixes: 60bd8c9747e8 ("net/mlx5: add count flow action") Cc: stable@dpdk.org Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_verbs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_verbs.c b/drivers/net/mlx5/mlx5_flo= w_verbs.c index 4ae974b..6ddb13b 100644 --- a/drivers/net/mlx5/mlx5_flow_verbs.c +++ b/drivers/net/mlx5/mlx5_flow_verbs.c @@ -72,6 +72,7 @@ }), .hits =3D 0, .bytes =3D 0, + .ref_cnt =3D 1, }; =20 if (!tmpl.cs) { @@ -80,6 +81,7 @@ } cnt =3D rte_calloc(__func__, 1, sizeof(*cnt), 0); if (!cnt) { + claim_zero(mlx5_glue->destroy_counter_set(tmpl.cs)); rte_errno =3D ENOMEM; return NULL; } --=20 1.8.3.1