From: Phil Yang <phil.yang@arm.com>
To: stable@dpdk.org
Cc: bluca@debian.org
Subject: [dpdk-stable] [PATCH 16.11 2/3] app/testpmd: fix physic port socket initialization
Date: Fri, 2 Nov 2018 15:40:16 +0800 [thread overview]
Message-ID: <1541144417-11169-2-git-send-email-phil.yang@arm.com> (raw)
In-Reply-To: <1541144417-11169-1-git-send-email-phil.yang@arm.com>
[ backported from upstream commit effdb8bbb018bd8a611b2ac86a15739f67ea7cbc ]
Once the lcore list setting excluded the socket which physic device
attached, it will cause failure. Meanwhile, it will disable Testpmd
cross NUMA scenario.
Fixes: dbfb8ec ("app/testpmd: optimize mbuf pool allocation")
Signed-off-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
---
app/test-pmd/testpmd.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 8984d0b..8ec8941 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -483,9 +483,21 @@ set_default_fwd_ports_config(void)
portid_t pt_id;
int i = 0;
- RTE_ETH_FOREACH_DEV(pt_id)
+ RTE_ETH_FOREACH_DEV(pt_id) {
fwd_ports_ids[i++] = pt_id;
+ /* Update sockets info according to the attached device */
+ int socket_id = rte_eth_dev_socket_id(pt_id);
+ if (socket_id >= 0 && new_socket_id(pt_id)) {
+ if (num_sockets >= RTE_MAX_NUMA_NODES) {
+ rte_exit(EXIT_FAILURE,
+ "Total sockets greater than %u\n",
+ RTE_MAX_NUMA_NODES);
+ }
+ socket_ids[num_sockets++] = socket_id;
+ }
+ }
+
nb_cfg_ports = nb_ports;
nb_fwd_ports = nb_ports;
}
--
2.7.4
next prev parent reply other threads:[~2018-11-02 7:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 7:40 [dpdk-stable] [PATCH 16.11 1/3] app/testpmd: fix vdev " Phil Yang
2018-11-02 7:40 ` Phil Yang [this message]
2018-11-02 7:40 ` [dpdk-stable] [PATCH 16.11 3/3] app/testpmd: reserve NUMA node per device port and per ring Phil Yang
2018-11-02 10:42 ` [dpdk-stable] [PATCH 16.11 1/3] app/testpmd: fix vdev socket initialization Luca Boccassi
2018-11-03 10:10 ` Phil Yang (Arm Technology China)
2018-11-03 10:53 ` Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1541144417-11169-2-git-send-email-phil.yang@arm.com \
--to=phil.yang@arm.com \
--cc=bluca@debian.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).