* [dpdk-stable] [dpdk-dev] [PATCH] net/e1000: fix uninitialized variables
@ 2018-11-06 7:45 wangyunjian
0 siblings, 0 replies; 3+ messages in thread
From: wangyunjian @ 2018-11-06 7:45 UTC (permalink / raw)
To: wangyunjian; +Cc: stable
From: Yunjian Wang <wangyunjian@huawei.com>
This patch fixes this variable may be used uninitialized.
Fixes: 95fe5e10ee81 ("e1000/base: i210 PLL workaround")
Cc: stable@dpdk.org
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
drivers/net/e1000/base/e1000_i210.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/e1000/base/e1000_i210.c b/drivers/net/e1000/base/e1000_i210.c
index 277331c..c2abb43 100644
--- a/drivers/net/e1000/base/e1000_i210.c
+++ b/drivers/net/e1000/base/e1000_i210.c
@@ -941,6 +941,7 @@ STATIC s32 e1000_pll_workaround_i210(struct e1000_hw *hw)
if (ret_val != E1000_SUCCESS)
nvm_word = E1000_INVM_DEFAULT_AL;
tmp_nvm = nvm_word | E1000_INVM_PLL_WO_VAL;
+ phy_word = E1000_PHY_PLL_UNCONF;
for (i = 0; i < E1000_MAX_PLL_TRIES; i++) {
/* check current state directly from internal PHY */
e1000_read_phy_reg_gs40g(hw, (E1000_PHY_PLL_FREQ_PAGE |
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/e1000: fix uninitialized variables
2018-11-06 7:57 wangyunjian
@ 2018-11-07 18:56 ` Zhang, Qi Z
0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2018-11-07 18:56 UTC (permalink / raw)
To: wangyunjian, Lu, Wenzhuo, dev; +Cc: stone.zhou, stable
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of wangyunjian
> Sent: Tuesday, November 6, 2018 12:57 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org
> Cc: stone.zhou@huawei.com; Yunjian Wang <wangyunjian@huawei.com>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/e1000: fix uninitialized variables
>
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> This patch fixes the variable 'phy_word' may be used uninitialized.
>
> Fixes: 5b6439cf03a4ca3 ("e1000/base: support different EEARBC for i210")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 3+ messages in thread
* [dpdk-stable] [dpdk-dev] [PATCH] net/e1000: fix uninitialized variables
@ 2018-11-06 7:57 wangyunjian
2018-11-07 18:56 ` Zhang, Qi Z
0 siblings, 1 reply; 3+ messages in thread
From: wangyunjian @ 2018-11-06 7:57 UTC (permalink / raw)
To: wenzhuo.lu, dev; +Cc: stone.zhou, Yunjian Wang, stable
From: Yunjian Wang <wangyunjian@huawei.com>
This patch fixes the variable 'phy_word' may be used uninitialized.
Fixes: 5b6439cf03a4ca3 ("e1000/base: support different EEARBC for i210")
Cc: stable@dpdk.org
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
drivers/net/e1000/base/e1000_i210.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/e1000/base/e1000_i210.c b/drivers/net/e1000/base/e1000_i210.c
index 277331c..c2abb43 100644
--- a/drivers/net/e1000/base/e1000_i210.c
+++ b/drivers/net/e1000/base/e1000_i210.c
@@ -941,6 +941,7 @@ STATIC s32 e1000_pll_workaround_i210(struct e1000_hw *hw)
if (ret_val != E1000_SUCCESS)
nvm_word = E1000_INVM_DEFAULT_AL;
tmp_nvm = nvm_word | E1000_INVM_PLL_WO_VAL;
+ phy_word = E1000_PHY_PLL_UNCONF;
for (i = 0; i < E1000_MAX_PLL_TRIES; i++) {
/* check current state directly from internal PHY */
e1000_read_phy_reg_gs40g(hw, (E1000_PHY_PLL_FREQ_PAGE |
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-07 18:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-06 7:45 [dpdk-stable] [dpdk-dev] [PATCH] net/e1000: fix uninitialized variables wangyunjian
2018-11-06 7:57 wangyunjian
2018-11-07 18:56 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).