From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0056.outbound.protection.outlook.com [104.47.1.56]) by dpdk.org (Postfix) with ESMTP id 1015C4C77 for ; Fri, 9 Nov 2018 10:36:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/gL1QOdYL9Nhf0LyAJqEHjTQOOOaC2lwFTCdmtQEzys=; b=c/DCAYHXmRHZhmmlf2O4D7bDapM9dWJOa7KNyBurpssUkLKTaFof95/U7gC0Ei8N/31TqQYtYy4XiE7FfHOcHOKR+NPYXehSNT/LLtiK0WdPwiuSZvaLcP/Gg93ZSC3tVsz84wVJYRcyXQJxb9+YbkmwO8X1KTY3bqeRv9WeKIU= Received: from VI1PR0502MB3743.eurprd05.prod.outlook.com (52.134.8.154) by VI1PR0502MB3917.eurprd05.prod.outlook.com (52.134.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.31; Fri, 9 Nov 2018 09:36:14 +0000 Received: from VI1PR0502MB3743.eurprd05.prod.outlook.com ([fe80::84d3:8812:d45c:98e4]) by VI1PR0502MB3743.eurprd05.prod.outlook.com ([fe80::84d3:8812:d45c:98e4%4]) with mapi id 15.20.1294.034; Fri, 9 Nov 2018 09:36:14 +0000 From: Ophir Munk To: Ophir Munk CC: "stable@dpdk.org" Thread-Topic: [PATCH v2] app/testpmd: revert setting default RSS Thread-Index: AQHUeA+oGLzKibXEX0SctPZ1nVs6kQ== Date: Fri, 9 Nov 2018 09:36:14 +0000 Message-ID: <1541756167-16076-1-git-send-email-ophirmu@mellanox.com> References: <1541754129-26009-1-git-send-email-ophirmu@mellanox.com> In-Reply-To: <1541754129-26009-1-git-send-email-ophirmu@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0277.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::25) To VI1PR0502MB3743.eurprd05.prod.outlook.com (2603:10a6:803:11::26) authentication-results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [37.142.13.130] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0502MB3917; 6:mt2YQhEscPs2LzTiRVNaeVuHBmEtg27iuxALsb1roJrWg5ccY9QwIdGVknXDrL8Dsx3HXbw/N2W/gJZ3MFEaIyKzMIpZsnrubeppoYZ+DSTwjrBy7t4z4RleeieyM0IW6ke/YMXHf4zVA7wV/WpTEQO91x1Zj1aDpXmIG5uv38O75vFfMlehieyOK8bcZ/ZZooYVwOKXVQkLexXGMTkwyLtKugYHEvKF7e4T9yuCs+3V/hL+pT4KuY3jMlOuh6eyBmlRY5wPNk0+ulcX1wqMNG1cika26hKLc4kIRd/zHw8kaoOmmOQVWqxFWHiKaSP6L5GfB4Eb7AcpGLFDcR6ohi37GgPE0HVUWldOG2rF8Vf0nsLsdX7eJWKwBWc3e9UsLRyTDOW3C0UkaU9qmtaJtjYQ0jFaFVzJdd1l24DxzcUU3g8A57m3pbfYHOtHnNKibETWa6kp7wddxgL7qpICdQ==; 5:deCg7Bx1hO7MGfY8QyPax5t14AFJdlmO6XEu3YcTYc3I2nv/yyVweN/C/57AJc1LwS0RHHpABBz3uSzDvOnk970jr6x9vO1ZxwaPl96SMZdZ37c4NE8pUIdxV6jDdX/UQctf+welqxcy+zEE0MCuO45sIcyCBuwstNRZf1Hui/Y=; 7:qc6PC2oxWNf9GI+ynGJ+2exhBUbpGY+DfGGTw7n5o4vW+UjkZ/PucKx1uFSt2MuXlc2IGbDkp7p0mHgfCKGnHgRRjwNWX7/mT4olDVlPOZg5gpCIP7ipoQ21dQOg6vtb73funOo6GIxCHf3TOoO5cA== x-ms-office365-filtering-correlation-id: be54fd1e-cd27-432a-465d-08d64626ca46 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0502MB3917; x-ms-traffictypediagnostic: VI1PR0502MB3917: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231382)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:VI1PR0502MB3917; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0502MB3917; x-forefront-prvs: 08512C5403 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(136003)(346002)(376002)(396003)(189003)(199004)(7736002)(26005)(186003)(316002)(52116002)(14444005)(256004)(2906002)(105586002)(106356001)(86362001)(76176011)(81156014)(8936002)(8676002)(81166006)(6116002)(3846002)(305945005)(68736007)(99286004)(6506007)(386003)(7049001)(2900100001)(37006003)(102836004)(4326008)(478600001)(53936002)(446003)(5660300001)(6512007)(71190400001)(71200400001)(486006)(6862004)(2616005)(6200100001)(25786009)(97736004)(66066001)(6486002)(14454004)(6436002)(11346002)(36756003)(476003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0502MB3917; H:VI1PR0502MB3743.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: DGoqXu2YTkCkZYY9mLs8jEWn/6Roh6aMa84UdwdDMucFzP1q+EDR0ezSqYxEkC32DdeLOXppA4EbbtutKCuiQbhiWoFTQjD9B2gzYtGXydQvgOzJYeJun0vZD7QpfgsWxA4BQgcUpbdgD+ifQvo/ZIwem2eHwoxn/ZIiQtM6U7TAMo9nSG0rAMylzhejaLTE4J1lVeI6md/0zb2PTfbaoOQoUfL8iwJksoxYakDer+GL2j6yOVbvc684TJogT7vp4NC0WoxUfXOq/7rD2YpcdH84BEwu8M6Nzv1Mx3VG0w3+3/gM5MNOOxaeG3yHRXhMkaZGLQXFNF4pzKmLkmZmIxv8RwT+O46nZ+cBjMBdPIQ= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: be54fd1e-cd27-432a-465d-08d64626ca46 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2018 09:36:14.2839 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0502MB3917 Subject: [dpdk-stable] [PATCH v2] app/testpmd: revert setting default RSS X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2018 09:36:16 -0000 This reverts the patch that enables default RSS action by setting key=3DNULL and key_len=3D0. In current testpmd implementation a key pointer must exist if key_len!=3D0. For example, the following flow rule will cause a segmentation fault: flow create 0 actions rss queues 0 1 end key_len 40 / end Fixes: a4391f8bae ("app/testpmd: set default RSS key as null") Cc: stable@dpdk.org Signed-off-by: Ophir Munk --- v1: Initial version v2: Update commit message (add Cc: stable@dpdk.org) app/test-pmd/cmdline_flow.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 91e2e35..23ea7cc 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -3248,15 +3248,26 @@ static int comp_vc_action_rss_queue(struct context = *, const struct token *, .func =3D RTE_ETH_HASH_FUNCTION_DEFAULT, .level =3D 0, .types =3D rss_hf, - .key_len =3D 0, + .key_len =3D sizeof(action_rss_data->key), .queue_num =3D RTE_MIN(nb_rxq, ACTION_RSS_QUEUE_NUM), - .key =3D NULL, + .key =3D action_rss_data->key, .queue =3D action_rss_data->queue, }, + .key =3D "testpmd's default RSS hash key, " + "override it for better balancing", .queue =3D { 0 }, }; for (i =3D 0; i < action_rss_data->conf.queue_num; ++i) action_rss_data->queue[i] =3D i; + if (!port_id_is_invalid(ctx->port, DISABLED_WARN) && + ctx->port !=3D (portid_t)RTE_PORT_ALL) { + struct rte_eth_dev_info info; + + rte_eth_dev_info_get(ctx->port, &info); + action_rss_data->conf.key_len =3D + RTE_MIN(sizeof(action_rss_data->key), + info.hash_key_size); + } action->conf =3D &action_rss_data->conf; return ret; } --=20 1.8.3.1