From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <luca.boccassi@gmail.com>
Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com
[209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 291302BD5
for <stable@dpdk.org>; Mon, 19 Nov 2018 13:52:39 +0100 (CET)
Received: by mail-wr1-f65.google.com with SMTP id p4so22770738wrt.7
for <stable@dpdk.org>; Mon, 19 Nov 2018 04:52:39 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
:references:content-transfer-encoding:mime-version;
bh=OetWe2syZN2bpCVbGEym89/feSw4b5LNYip2sqs0rvs=;
b=WLFxiku+iEYNH3h3mP8yVXxSdcqQmxQ4M/7V+AoFwUfAiEUGaauRMssV/MzxjkwaMt
n9luhoW+748JeMSEMS22oy0nFpzmLku0OkPI1hKAjPNSM9xWO3Ti6dn7EhS1yuHi61np
qdfSuSdf1ks4PxDdRw1EwlHfOF3BhBhFDDB37JXUvcUY1gRAn3TXCS3OmFpRqMndzPTA
KcN4ePs6nduDujp8Uq1veLt6xGjiptge24vXHywjpWkgSpPo6/4YcqFOHynEv3XnatFR
Wu4ySizWsiw20Lfxn5fRGEkoK1rda5TqTysZXf/oP0iF2BiMJSN86ErkY8LH0sU1wXhz
SJEw==
X-Gm-Message-State: AGRZ1gLKvCQz5Hp56sFhekOOycO42rtIneDnhuf7K10vBC9cEYQSk1P5
tq8pi+g7EK4fK8logIMdApM=
X-Google-Smtp-Source: AJdET5deFm+4cIzBogflQ2gByFiPF9m41CQqYuf66WncjjskiZcth5gJPKMTU5DBSbGkHzKQPO5TIg==
X-Received: by 2002:adf:ae1a:: with SMTP id
x26-v6mr18439757wrc.189.1542631958643;
Mon, 19 Nov 2018 04:52:38 -0800 (PST)
Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556])
by smtp.gmail.com with ESMTPSA id v23-v6sm29392873wrd.92.2018.11.19.04.52.37
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Mon, 19 Nov 2018 04:52:37 -0800 (PST)
Message-ID: <1542631957.27998.1.camel@debian.org>
From: Luca Boccassi <bluca@debian.org>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>, dpdk stable <stable@dpdk.org>
Date: Mon, 19 Nov 2018 12:52:37 +0000
In-Reply-To: <20181119124825.GA6155@debian>
References: <20181108180111.25873-1-bluca@debian.org>
<20181119122538.14207-1-bluca@debian.org>
<20181119122538.14207-8-bluca@debian.org> <20181119124825.GA6155@debian>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.22.6-1+deb9u1
Mime-Version: 1.0
Subject: Re: [dpdk-stable] patch 'net/virtio: fix unchecked return value'
has been queued to LTS release 16.11.9
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Nov 2018 12:52:39 -0000
On Mon, 2018-11-19 at 20:48 +0800, Tiwei Bie wrote:
> On Mon, Nov 19, 2018 at 12:25:25PM +0000, Luca Boccassi wrote:
> > Hi,
> >=20
> > FYI, your patch has been queued to LTS release 16.11.9
> >=20
> > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable
> > yet.
> > It will be pushed if I get no objections before 11/21/18. So please
> > shout if anyone has objections.
> >=20
> > Also note that after the patch there's a diff of the upstream
> > commit vs the patch applied
> > to the branch. If the code is different (ie: not only metadata
> > diffs), due for example to
> > a change in context or macro names, please double check it.
> >=20
> > Thanks.
> >=20
> > Luca Boccassi
> >=20
> > ---
> > From 87b9d321789f9bdaa2cf11df2f7377bc1145e7fa Mon Sep 17 00:00:00
> > 2001
> > From: Tiwei Bie <tiwei.bie@intel.com>
> > Date: Wed, 7 Nov 2018 17:01:01 +0800
> > Subject: [PATCH] net/virtio: fix unchecked return value
> >=20
> > [ upstream commit ecfae1510edc1391285aa566a2d31e7eae8fc6d2 ]
> >=20
> > Coverity issue: 302861
> > Fixes: 6ba1f63b5ab0 ("virtio: support specification 1.0")
> >=20
> > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> > Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> > ---
> > =C2=A0drivers/net/virtio/virtio_pci.c | 12 +++++++++---
> > =C2=A01 file changed, 9 insertions(+), 3 deletions(-)
> >=20
> > diff --git a/drivers/net/virtio/virtio_pci.c
> > b/drivers/net/virtio/virtio_pci.c
> > index f6d697f38..13ad57dfd 100644
> > --- a/drivers/net/virtio/virtio_pci.c
> > +++ b/drivers/net/virtio/virtio_pci.c
> > @@ -690,9 +690,15 @@ virtio_read_caps(struct rte_pci_device *dev,
> > struct virtio_hw *hw)
> > =C2=A0 hw->common_cfg =3D get_cfg_addr(dev, &cap);
> > =C2=A0 break;
> > =C2=A0 case VIRTIO_PCI_CAP_NOTIFY_CFG:
> > - rte_eal_pci_read_config(dev, &hw-
> > >notify_off_multiplier,
> > - 4, pos +
> > sizeof(cap));
> > - hw->notify_base =3D get_cfg_addr(dev, &cap);
> > + ret =3D rte_eal_pci_read_config(dev,
> > + &hw-
> > >notify_off_multiplier,
> > + 4, pos + sizeof(cap));
> > + if (ret !=3D 4)
>=20
> Hi Luca,
>=20
> This patch can't be backported, because it depends on an
> API change in newer release.
>=20
> Thanks
Yes the one I made (lol!), you are right and I had already skipped
that, thanks for the reminder.
--=20
Kind regards,
Luca Boccassi