From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 1FA7F1B184 for ; Mon, 10 Dec 2018 16:11:22 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 9E4A81000AF; Mon, 10 Dec 2018 15:11:20 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 10 Dec 2018 07:11:17 -0800 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Mon, 10 Dec 2018 07:11:17 -0800 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id wBAFBFnA014768; Mon, 10 Dec 2018 15:11:15 GMT Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id D6F691616EF; Mon, 10 Dec 2018 15:11:15 +0000 (GMT) From: Andrew Rybchenko To: CC: Ivan Malov Date: Mon, 10 Dec 2018 15:10:55 +0000 Message-ID: <1544454656-5339-5-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1544454656-5339-1-git-send-email-arybchenko@solarflare.com> References: <1544454656-5339-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24274.006 X-TM-AS-Result: No-2.863900-4.000000-10 X-TMASE-MatchedRID: xDToTJ4Kd/l3daUeCOH6HRHuQ9dDJbS2ETae8Q/uL1HxxaAXDrCns2q5 xdhoCAX9vr8j/+4r28yqLOntCp/PAU/qpx4DtjGJHcQQBuf4ZFtK4f4Z+CZAZ1pbYq2f4jz+Vej /gFdIvS1Pt+xmgMK7fJRNDYlhDNjb0u5x0DU4ekFH+PTjR9EWkrbIBPlG+6fSgiL/QhKEhDijxY yRBa/qJcFwgTvxipFajoczmuoPCq2SZJSY/MSQakbcp53S8oUoTEjwx/uzag/TnEJZlCz/fr5MN 46KS0tCVlxwsR5rwmbULSaOfj6J0gT+DxdV5b85GGFN0y/7nsKF15h6/oibNbKsWJ44GuEGPNxa u39/BitFwHZmk+dWMmhnUCrcDtVn X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--2.863900-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24274.006 X-MDID: 1544454681-Q4aumsXdhRZr Subject: [dpdk-stable] [PATCH 17.11 5/6] net/sfc: allow to query RSS key and HF in isolated mode X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2018 15:11:22 -0000 From: Ivan Malov [ backported from upstream commit 453e1d4baad9262391eaef15812ade9af1f15a3f ] Isolated mode prevents global RSS from being enabled and configured. However, an application may need to query default RSS key and hash functions when a flow rule with RSS action is added which does not contain custom RSS key or hash function choice. In this case global RSS key and hash functions will be used to handle the rule, and there should be some way for the application to query these global default settings to clarify expectations on the traffic distribution. Fixes: 84a9b48128c1 ("net/sfc: support flow API isolated mode") Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index 94e7c79..f4e880d 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@ -1225,9 +1225,8 @@ struct rte_eth_rss_conf *rss_conf) { struct sfc_adapter *sa = dev->data->dev_private; - struct sfc_port *port = &sa->port; - if ((sa->rss_support != EFX_RX_SCALE_EXCLUSIVE) || port->isolated) + if (sa->rss_support != EFX_RX_SCALE_EXCLUSIVE) return -ENOTSUP; if (sa->rss_channels == 0) -- 1.8.3.1