From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 64EE11B94E; Fri, 11 Jan 2019 12:10:30 +0100 (CET) Received: by mail-wr1-f66.google.com with SMTP id v13so14741754wrw.5; Fri, 11 Jan 2019 03:10:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=jFsi/07p81/eauflGtEmKYazzxvm1rR+U6BsZ+K32es=; b=tT1Q2X9d0EPpu40f4HiCkZjJQ/LHVqy0wPtHMrmLXeKq/N8GqTbbBiTYi3kXP7w9mW PrthGU4TTpQ3OsuK0uiCRFGAWMaRZ3reZ0Uz7IsAaqST+2Q8cCLh6wvOgPWrqq6qzKt6 lRDVXR8QZCPERdIaQ4IFtwG4QAcFdiWTmi/kYcoJPAVrqL0idsOPH4sNVc8W+a6l/DAb nGWlPXxivyLfN/U/J2YmQAFVVD1t+iRI/GABxxC//oOW7WgG9gWhM0irPv8cF1cw50Lj rGk+T3MOk5EM7eigK/mod+twTbPFmh390vGeyO5nOsss8F1/rPWFSYB710YiRmQFi+Lo pKvQ== X-Gm-Message-State: AJcUukdM/SYBuFyFy6WhFMMOSnZdMabkA61Df/zrgypKU4YYZn1D+hRw 7OAAprWZ1ImAXhiaf/dTmMMXyN4gJwY= X-Google-Smtp-Source: ALg8bN5yMN4fHBvpnbXVNB7R/aApuK0n2Rz5/LiFaU3xmkT+XieUOI0eubmsoveWglOSjI0x8UxMDw== X-Received: by 2002:a5d:4fcb:: with SMTP id h11mr13356125wrw.139.1547205029978; Fri, 11 Jan 2019 03:10:29 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id o5sm30900296wmg.25.2019.01.11.03.10.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Jan 2019 03:10:28 -0800 (PST) Message-ID: <1547205028.4501.9.camel@debian.org> From: Luca Boccassi To: Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org Date: Fri, 11 Jan 2019 11:10:28 +0000 In-Reply-To: <20190107165552.GA23828@bricha3-MOBL.ger.corp.intel.com> References: <20190103175725.5836-1-bluca@debian.org> <20190103175725.5836-2-bluca@debian.org> <20190107142812.GB14912@bricha3-MOBL.ger.corp.intel.com> <1546879174.6022.24.camel@debian.org> <20190107165552.GA23828@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 2/2] build: use dependency() instead of find_library() X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 11:10:30 -0000 On Mon, 2019-01-07 at 16:55 +0000, Bruce Richardson wrote: > On Mon, Jan 07, 2019 at 04:39:34PM +0000, Luca Boccassi wrote: > > On Mon, 2019-01-07 at 14:28 +0000, Bruce Richardson wrote: > > > On Thu, Jan 03, 2019 at 06:57:25PM +0100, Luca Boccassi wrote: > > > > For libbsd, which is checked in a top level file and used to be > > > > added > > > > to the global linker flags array, add it to the ext_deps array > > > > of > > > > all top level meson files (app, test, lib, examples, drivers). > > > > The > > > > most correct change would be to let each individual > > > > library/driver/app > > > > depend on it individually if they use symbols from it, but it > > > > would > > > > diverge from the legacy Makefile's behaviour and make life a > > > > bit > > > > more > > > > difficult for contributors. > > >=20 > > > It shouldn't be necessary to add libbsd as a dependency for > > > everything. I > > > think just adding it as a dependency of EAL should work fine.=C2=A0 > >=20 > > Won't that mean that the shared libraries other than EAL will have > > undefined references? >=20 > Should not happen. AFAIK when you link against a library in meson it > will > also link against any of that libraries dependencies too. For shared > libraries meson always disallowed undefined references in the linker > commandline. [To have libs with undefined refs, e.g. plugins, you > need to > use "shared_module" rather than "shared_library" command]. Looked at this again, and rte_cmdline is using strlcpy as well, and it's built before rte_eal, so it fails: lib/76b5a35@@rte_cmdline@sta/librte_cmdline_cmdline_parse.c.o: In function = `cmdline_complete': cmdline_parse.c:(.text+0x861): undefined reference to `strlcpy' Adding it to ext_deps in both rte_cmdline and rte_eal works. Is that an acc= eptable compromise? --=20 Kind regards, Luca Boccassi