patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] net/vmxnet3: keep link state consistent
@ 2018-03-18  1:45 Chas Williams
  2018-03-20 14:12 ` Ferruh Yigit
  2018-04-20  0:10 ` [dpdk-stable] " Ferruh Yigit
  0 siblings, 2 replies; 10+ messages in thread
From: Chas Williams @ 2018-03-18  1:45 UTC (permalink / raw)
  To: dev; +Cc: skhare, Chas Williams, stable

From: Chas Williams <chas3@att.com>

The vmxnet3 never attempts link speed negotiation.  As a virtual device
the link speed is vague at best.  However, it is important for certain
applications, like bonding, to see a consistent link_status.  802.3ad
requires that only links of the same cost (link speed) be enslaved.
Keeping the link status consistent in vmxnet3 avoids races with bonding
enslavement.

Author: Thomas Monjalon <thomas@monjalon.net>
Date:   Fri Jan 5 18:38:55 2018 +0100

Fixes: 1e3a958f40b3 ("ethdev: fix link autonegotiation value")
Cc: stable@dpdk.org

Signed-off-by: Chas Williams <chas3@att.com>
---
 drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index 426008722..48a4d4f98 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -1105,7 +1105,7 @@ __vmxnet3_dev_link_update(struct rte_eth_dev *dev,
 		link.link_status = ETH_LINK_UP;
 	link.link_duplex = ETH_LINK_FULL_DUPLEX;
 	link.link_speed = ETH_SPEED_NUM_10G;
-	link.link_autoneg = ETH_LINK_AUTONEG;
+	link.link_autoneg = ETH_LINK_FIXED;
 
 	return rte_eth_linkstatus_set(dev, &link);
 }
-- 
2.13.6

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2018-04-20  0:10 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-18  1:45 [dpdk-stable] [PATCH] net/vmxnet3: keep link state consistent Chas Williams
2018-03-20 14:12 ` Ferruh Yigit
2018-03-20 14:42   ` Chas Williams
2018-04-05 10:03   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2018-04-05 15:01     ` Chas Williams
2018-04-17 19:25       ` Ferruh Yigit
2018-04-17 20:24         ` Thomas Monjalon
2018-04-18 16:23           ` Ferruh Yigit
2018-04-18 16:59           ` Yong Wang
2018-04-20  0:10 ` [dpdk-stable] " Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).