From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2890A0471 for ; Fri, 19 Jul 2019 15:04:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C0BF4374E; Fri, 19 Jul 2019 15:04:28 +0200 (CEST) Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by dpdk.org (Postfix) with ESMTP id 31D01374E for ; Fri, 19 Jul 2019 15:04:28 +0200 (CEST) Received: by mail-qt1-f196.google.com with SMTP id h21so30776611qtn.13 for ; Fri, 19 Jul 2019 06:04:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cR9QUPpObCUIjcTFpLZNZqyhd6vn3fB9n003iGquT/0=; b=zld2JgGoj+DQo+eBwK8MisNV8TlCQPkhoZh2mGExyYq9yzp7kzjP6GDFChBAlDdXED Xb04N+VNDuKl0MChTFAnmGqHyZqBY+15tCDZW/tekNbg2VTf8ul6O8YsbJ+pjMspG3lO 0MNQ4J7rTcC+wHeJnR7ZSUI1LjC1dInBRDD2e02AVv5khPoiawpyUshglYWhZwiRmoa1 QGYqsSzlZVFTjhgM+mvCIn5UjfDqcRHyWd9Y2sbX0VftHk41E4NTn5WeIPGNpJ5lRNtz 8hsroI9VWo3p9rHdMKnWOe/c1hSltgfvm/LjuCCCCEmrTw15LzzP0DwUcySstZwhlNVa zYIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cR9QUPpObCUIjcTFpLZNZqyhd6vn3fB9n003iGquT/0=; b=D9+GBWS6Q+Im55jIWC/XcF5eLMtHgeXVDgurMqkBNzk743iPJkszJ5mo7dGzV4oUWM Ta06eWmVDLLf0xCIfxNWIL4Baovt/dDdKv7VsDoDhJ6SLRD0kQD4CWLk7VlSwu8a2fzZ CZowURoY6jqNGLmQQZNrK6+DkZyUm6xP9A0YtS3UwAxhubcJ+pLXd0Zxk3aTeILfLHAG HJgayqUqhF6cQChxTMaF0cJHfEyuBmVGZ6dYWOaPOX75ubu1lavbUfR97/2yzkwL+7ze K6yqTlZz5rgJPfpsQV/9IxZZlRlo/QhnxDOtD8ncYhEkUmnD/NY1cqpbTQlvefmQnsJu 9lRQ== X-Gm-Message-State: APjAAAVt5ZG6FcuC2oy7NdsK+QEZKg3W5iMX1M+gmzGIa0BlOQh/wxtK o6uiTwk4bNWf6muKMmX/yWQ= X-Google-Smtp-Source: APXvYqxANyKOf++fKhbNZBptk82XWbcNWpmJq1uu0yNs04Jmpb/6ap5ilKSUCKHICgqjDhoBzuffng== X-Received: by 2002:ac8:3267:: with SMTP id y36mr36206007qta.293.1563541467442; Fri, 19 Jul 2019 06:04:27 -0700 (PDT) Received: from localhost.localdomain (pool-173-48-129-93.bstnma.fios.verizon.net. [173.48.129.93]) by smtp.gmail.com with ESMTPSA id z18sm14490197qka.12.2019.07.19.06.04.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 19 Jul 2019 06:04:26 -0700 (PDT) From: Ed Czeck To: czeck@ieee.org Cc: Ed Czeck , stable@dpdk.org Date: Fri, 19 Jul 2019 09:04:17 -0400 Message-Id: <1563541458-9331-1-git-send-email-ed.czeck@atomicrules.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1563312861-26219-1-git-send-email-ed.czeck@atomicrules.com> References: <1563312861-26219-1-git-send-email-ed.czeck@atomicrules.com> Subject: [dpdk-stable] [PATCH 1/2] net/ark: remove queue offset based on port id X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Queue index was incorrectly incremented with port, which caused swizzling of packet placement among queues. This manifested when the number of configured ports was >1 and < nb_queues. Fixes: c33d45af3633 ("net/ark: add Tx initial version") Cc: stable@dpdk.org Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev_rx.c | 4 +--- drivers/net/ark/ark_ethdev_tx.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net/ark/ark_ethdev_rx.c index 7de1a98..6156730 100644 --- a/drivers/net/ark/ark_ethdev_rx.c +++ b/drivers/net/ark/ark_ethdev_rx.c @@ -127,9 +127,7 @@ eth_ark_dev_rx_queue_setup(struct rte_eth_dev *dev, uint32_t i; int status; - /* Future works: divide the Q's evenly with multi-ports */ - int port = dev->data->port_id; - int qidx = port + queue_idx; + int qidx = queue_idx; /* We may already be setup, free memory prior to re-allocation */ if (dev->data->rx_queues[queue_idx] != NULL) { diff --git a/drivers/net/ark/ark_ethdev_tx.c b/drivers/net/ark/ark_ethdev_tx.c index 1967655..08bcf43 100644 --- a/drivers/net/ark/ark_ethdev_tx.c +++ b/drivers/net/ark/ark_ethdev_tx.c @@ -211,9 +211,7 @@ eth_ark_tx_queue_setup(struct rte_eth_dev *dev, struct ark_tx_queue *queue; int status; - /* Future: divide the Q's evenly with multi-ports */ - int port = dev->data->port_id; - int qidx = port + queue_idx; + int qidx = queue_idx; if (!rte_is_power_of_2(nb_desc)) { PMD_DRV_LOG(ERR, -- 2.7.4