From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com, stable@dpdk.org,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Tiwei Bie <tiwei.bie@intel.com>,
Zhihong Wang <zhihong.wang@intel.com>
Subject: [dpdk-stable] [PATCH 4/8] net/virtio: remove unused Tx error counter
Date: Thu, 25 Jul 2019 11:14:24 +0200 [thread overview]
Message-ID: <1564046068-21905-5-git-send-email-david.marchand@redhat.com> (raw)
In-Reply-To: <1564046068-21905-1-git-send-email-david.marchand@redhat.com>
This Tx counter has never been used.
Fixes: 9658d17da27b ("virtio: maintain stats per queue")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/virtio/virtio_ethdev.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index 62c8274..20840bf 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -121,7 +121,6 @@ static const struct rte_virtio_xstats_name_off rte_virtio_rxq_stat_strings[] = {
static const struct rte_virtio_xstats_name_off rte_virtio_txq_stat_strings[] = {
{"good_packets", offsetof(struct virtnet_tx, stats.packets)},
{"good_bytes", offsetof(struct virtnet_tx, stats.bytes)},
- {"errors", offsetof(struct virtnet_tx, stats.errors)},
{"multicast_packets", offsetof(struct virtnet_tx, stats.multicast)},
{"broadcast_packets", offsetof(struct virtnet_tx, stats.broadcast)},
{"undersize_packets", offsetof(struct virtnet_tx, stats.size_bins[0])},
@@ -944,7 +943,6 @@ virtio_update_stats(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
stats->opackets += txvq->stats.packets;
stats->obytes += txvq->stats.bytes;
- stats->oerrors += txvq->stats.errors;
if (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {
stats->q_opackets[i] = txvq->stats.packets;
@@ -1082,7 +1080,6 @@ virtio_dev_stats_reset(struct rte_eth_dev *dev)
txvq->stats.packets = 0;
txvq->stats.bytes = 0;
- txvq->stats.errors = 0;
txvq->stats.multicast = 0;
txvq->stats.broadcast = 0;
memset(txvq->stats.size_bins, 0,
--
1.8.3.1
next prev parent reply other threads:[~2019-07-25 9:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1564046068-21905-1-git-send-email-david.marchand@redhat.com>
2019-07-25 9:14 ` [dpdk-stable] [PATCH 1/8] net/af_packet: remove unused Rx counter David Marchand
2019-07-25 16:06 ` Ferruh Yigit
2019-07-25 9:14 ` [dpdk-stable] [PATCH 3/8] net/null: remove unused Tx error counter David Marchand
2019-07-25 16:06 ` Ferruh Yigit
2019-07-25 9:14 ` David Marchand [this message]
2019-07-26 2:39 ` [dpdk-stable] [PATCH 4/8] net/virtio: " Tiwei Bie
2019-07-25 9:14 ` [dpdk-stable] [PATCH 5/8] net/kni: do not count unsent packets as errors David Marchand
2019-07-25 16:12 ` Ferruh Yigit
2019-07-25 19:07 ` David Marchand
2019-07-26 7:24 ` David Marchand
2019-07-26 10:17 ` Ferruh Yigit
2019-07-25 9:14 ` [dpdk-stable] [PATCH 7/8] net/ring: " David Marchand
2019-07-25 16:19 ` Ferruh Yigit
2019-07-25 9:14 ` [dpdk-stable] [PATCH 8/8] net/vhost: " David Marchand
2019-07-26 2:44 ` Tiwei Bie
[not found] ` <1564136488-29065-1-git-send-email-david.marchand@redhat.com>
2019-07-26 10:21 ` [dpdk-stable] [PATCH v2 1/9] net/af_packet: remove unused Rx counter David Marchand
2019-07-26 10:21 ` [dpdk-stable] [PATCH v2 3/9] net/null: remove unused Tx error counter David Marchand
2019-07-26 10:21 ` [dpdk-stable] [PATCH v2 4/9] net/virtio: " David Marchand
2019-07-26 10:21 ` [dpdk-stable] [PATCH v2 5/9] net/kni: remove unused Rx "error" counter David Marchand
2019-07-26 13:23 ` Ferruh Yigit
2019-07-26 10:21 ` [dpdk-stable] [PATCH v2 6/9] net/kni: do not count unsent packets as errors David Marchand
2019-07-26 13:23 ` Ferruh Yigit
2019-07-26 10:21 ` [dpdk-stable] [PATCH v2 8/9] net/ring: " David Marchand
2019-07-26 13:24 ` Ferruh Yigit
2019-07-26 10:21 ` [dpdk-stable] [PATCH v2 9/9] net/vhost: " David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1564046068-21905-5-git-send-email-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).