From: Wang Ying A <ying.a.wang@intel.com>
To: qi.z.zhang@intel.com
Cc: qiming.yang@intel.com, dev@dpdk.org, ying.a.wang@intel.com,
stable@dpdk.org
Subject: [dpdk-stable] [PATCH] net/ice: fix LLDP forward
Date: Fri, 26 Jul 2019 05:00:08 +0800 [thread overview]
Message-ID: <1564088408-99709-1-git-send-email-ying.a.wang@intel.com> (raw)
The patch fix the issue that lldp packet can't be forwarded to host.
Fixes: 59d151de6673 ("net/ice: stop LLDP by default")
Cc: stable@dpdk.org
Signed-off-by: Wang Ying A <ying.a.wang@intel.com>
---
drivers/net/ice/ice_ethdev.c | 46 +++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 45 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 08fc9ec..37bea2b 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -1385,6 +1385,44 @@ static int ice_parse_devargs(struct rte_eth_dev *dev)
return ret;
}
+#define ICE_ETHERTYPE_LLDP 0x88CC
+/** ice_cfg_sw_lldp - Config switch rules for LLDP packet handling
+ * @vsi: the VSI being configured
+ * @tx: bool to determine Tx or Rx rule
+ * @create: bool to determine create or remove Rule
+ */
+static enum ice_status
+ice_cfg_sw_lldp(struct ice_vsi *vsi, bool tx, bool create)
+{
+ struct ice_hw *hw = ICE_VSI_TO_HW(vsi);
+ struct ice_fltr_list_entry *list = NULL;
+ struct LIST_HEAD_TYPE tmp_add_list;
+ enum ice_status status;
+ list = (struct ice_fltr_list_entry *)ice_malloc(hw, sizeof(*list));
+ if (!list)
+ return ICE_ERR_NO_MEMORY;
+ list->fltr_info.lkup_type = ICE_SW_LKUP_ETHERTYPE;
+ list->fltr_info.vsi_handle = vsi->idx;
+ list->fltr_info.l_data.ethertype_mac.ethertype = ICE_ETHERTYPE_LLDP;
+ if (tx) {
+ list->fltr_info.fltr_act = ICE_DROP_PACKET;
+ list->fltr_info.flag = ICE_FLTR_TX;
+ list->fltr_info.src_id = ICE_SRC_ID_VSI;
+ } else {
+ list->fltr_info.fltr_act = ICE_FWD_TO_VSI;
+ list->fltr_info.flag = ICE_FLTR_RX;
+ list->fltr_info.src_id = ICE_SRC_ID_LPORT;
+ }
+ INIT_LIST_HEAD(&tmp_add_list);
+ LIST_ADD(&list->list_entry, &tmp_add_list);
+ if (create)
+ status = ice_add_eth_mac(hw, &tmp_add_list);
+ else
+ status = ice_remove_eth_mac(hw, &tmp_add_list);
+ ice_free(hw, list);
+ return status;
+}
+
static int
ice_dev_init(struct rte_eth_dev *dev)
{
@@ -1492,7 +1530,13 @@ static int ice_parse_devargs(struct rte_eth_dev *dev)
ret = ice_aq_stop_lldp(hw, TRUE, FALSE, NULL);
if (ret != ICE_SUCCESS)
PMD_INIT_LOG(DEBUG, "lldp has already stopped\n");
-
+ ret = ice_init_dcb(hw, true);
+ if (ret != ICE_SUCCESS)
+ PMD_INIT_LOG(DEBUG, "Failed to init DCB\n");
+ /* Forward LLDP packets to default VSI */
+ ret = ice_cfg_sw_lldp(vsi, false, true);
+ if (ret != ICE_SUCCESS)
+ PMD_INIT_LOG(DEBUG, "Failed to cfg lldp\n");
/* register callback func to eal lib */
rte_intr_callback_register(intr_handle,
ice_interrupt_handler, dev);
--
1.8.3.1
next reply other threads:[~2019-07-26 5:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 21:00 Wang Ying A [this message]
2019-07-25 23:36 ` [dpdk-stable] [PATCH v2] " Wang Ying A
2019-07-26 23:03 ` Yang, Qiming
2019-07-27 3:30 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2019-07-29 0:45 ` Wang, Ying A
2019-07-28 20:41 ` [dpdk-stable] [PATCH v3] " Wang Ying A
2019-07-29 11:49 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1564088408-99709-1-git-send-email-ying.a.wang@intel.com \
--to=ying.a.wang@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).