From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com, stable@dpdk.org,
Tetsuya Mukawa <mtetsuyah@gmail.com>
Subject: [dpdk-stable] [PATCH v2 3/9] net/null: remove unused Tx error counter
Date: Fri, 26 Jul 2019 12:21:22 +0200 [thread overview]
Message-ID: <1564136488-29065-4-git-send-email-david.marchand@redhat.com> (raw)
In-Reply-To: <1564136488-29065-1-git-send-email-david.marchand@redhat.com>
This Tx counter has never been used.
Fixes: c743e50c475f ("null: new poll mode driver")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/net/null/rte_eth_null.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
index 31cbb84..b2c92ab 100644
--- a/drivers/net/null/rte_eth_null.c
+++ b/drivers/net/null/rte_eth_null.c
@@ -62,7 +62,6 @@ struct null_queue {
rte_atomic64_t rx_pkts;
rte_atomic64_t tx_pkts;
- rte_atomic64_t err_pkts;
};
struct pmd_internals {
@@ -311,7 +310,7 @@ static int
eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)
{
unsigned i, num_stats;
- unsigned long rx_total = 0, tx_total = 0, tx_err_total = 0;
+ unsigned long rx_total = 0, tx_total = 0;
const struct pmd_internals *internal;
if ((dev == NULL) || (igb_stats == NULL))
@@ -334,12 +333,10 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)
igb_stats->q_opackets[i] =
internal->tx_null_queues[i].tx_pkts.cnt;
tx_total += igb_stats->q_opackets[i];
- tx_err_total += internal->tx_null_queues[i].err_pkts.cnt;
}
igb_stats->ipackets = rx_total;
igb_stats->opackets = tx_total;
- igb_stats->oerrors = tx_err_total;
return 0;
}
@@ -356,10 +353,8 @@ eth_stats_reset(struct rte_eth_dev *dev)
internal = dev->data->dev_private;
for (i = 0; i < RTE_DIM(internal->rx_null_queues); i++)
internal->rx_null_queues[i].rx_pkts.cnt = 0;
- for (i = 0; i < RTE_DIM(internal->tx_null_queues); i++) {
+ for (i = 0; i < RTE_DIM(internal->tx_null_queues); i++)
internal->tx_null_queues[i].tx_pkts.cnt = 0;
- internal->tx_null_queues[i].err_pkts.cnt = 0;
- }
}
static void
--
1.8.3.1
next prev parent reply other threads:[~2019-07-26 10:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1564046068-21905-1-git-send-email-david.marchand@redhat.com>
2019-07-25 9:14 ` [dpdk-stable] [PATCH 1/8] net/af_packet: remove unused Rx counter David Marchand
2019-07-25 16:06 ` Ferruh Yigit
2019-07-25 9:14 ` [dpdk-stable] [PATCH 3/8] net/null: remove unused Tx error counter David Marchand
2019-07-25 16:06 ` Ferruh Yigit
2019-07-25 9:14 ` [dpdk-stable] [PATCH 4/8] net/virtio: " David Marchand
2019-07-26 2:39 ` Tiwei Bie
2019-07-25 9:14 ` [dpdk-stable] [PATCH 5/8] net/kni: do not count unsent packets as errors David Marchand
2019-07-25 16:12 ` Ferruh Yigit
2019-07-25 19:07 ` David Marchand
2019-07-26 7:24 ` David Marchand
2019-07-26 10:17 ` Ferruh Yigit
2019-07-25 9:14 ` [dpdk-stable] [PATCH 7/8] net/ring: " David Marchand
2019-07-25 16:19 ` Ferruh Yigit
2019-07-25 9:14 ` [dpdk-stable] [PATCH 8/8] net/vhost: " David Marchand
2019-07-26 2:44 ` Tiwei Bie
[not found] ` <1564136488-29065-1-git-send-email-david.marchand@redhat.com>
2019-07-26 10:21 ` [dpdk-stable] [PATCH v2 1/9] net/af_packet: remove unused Rx counter David Marchand
2019-07-26 10:21 ` David Marchand [this message]
2019-07-26 10:21 ` [dpdk-stable] [PATCH v2 4/9] net/virtio: remove unused Tx error counter David Marchand
2019-07-26 10:21 ` [dpdk-stable] [PATCH v2 5/9] net/kni: remove unused Rx "error" counter David Marchand
2019-07-26 13:23 ` Ferruh Yigit
2019-07-26 10:21 ` [dpdk-stable] [PATCH v2 6/9] net/kni: do not count unsent packets as errors David Marchand
2019-07-26 13:23 ` Ferruh Yigit
2019-07-26 10:21 ` [dpdk-stable] [PATCH v2 8/9] net/ring: " David Marchand
2019-07-26 13:24 ` Ferruh Yigit
2019-07-26 10:21 ` [dpdk-stable] [PATCH v2 9/9] net/vhost: " David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1564136488-29065-4-git-send-email-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=mtetsuyah@gmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).