From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: aconole@redhat.com, msantana@redhat.com, stable@dpdk.org
Subject: [dpdk-stable] [PATCH] test/eal: do not scan PCI devices for memory tests
Date: Thu, 1 Aug 2019 14:27:45 +0200 [thread overview]
Message-ID: <1564662465-2925-1-git-send-email-david.marchand@redhat.com> (raw)
The memory tests currently check that, for normal mode (not legacy mode),
there is no memory left behind when exiting.
The problem is that if a ethdev port is allocated when scanning pci
devices (even if the driver probe fails like when you have a virtio
management interface attached to the kernel), on exit, dpdk won't free
the associated memory since ethdev never frees the ethdev memzone.
Workaround this by disabling pci scan.
Fixes: 651cc78f83b5 ("test: fix hugepage file handling in EAL flags autotest")
Fixes: 690fd3577e90 ("test/eal: add cases for in-memory and single-file-segments")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
app/test/test_eal_flags.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index 5b2c0f5..6aaa4a3 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -1044,7 +1044,7 @@ test_file_prefix(void)
DEFAULT_MEM_SIZE, "--file-prefix=" memtest };
/* primary process with memtest1 and default mem mode */
- const char *argv1[] = {prgname, "-m",
+ const char *argv1[] = {prgname, "--no-pci", "-m",
DEFAULT_MEM_SIZE, "--file-prefix=" memtest1 };
/* primary process with memtest1 and legacy mem mode */
@@ -1058,7 +1058,7 @@ test_file_prefix(void)
"--legacy-mem" };
/* primary process with memtest2 and default mem mode */
- const char *argv4[] = {prgname, "-m",
+ const char *argv4[] = {prgname, "--no-pci", "-m",
DEFAULT_MEM_SIZE, "--file-prefix=" memtest2 };
/* primary process with --in-memory mode */
@@ -1075,7 +1075,7 @@ test_file_prefix(void)
DEFAULT_MEM_SIZE, "--in-memory", "--file-prefix", prefix };
/* primary process with memtest1 and --single-file-segments mode */
- const char * const argv8[] = {prgname, "-m",
+ const char * const argv8[] = {prgname, "--no-pci", "-m",
DEFAULT_MEM_SIZE, "--single-file-segments",
"--file-prefix=" memtest1 };
--
1.8.3.1
next reply other threads:[~2019-08-01 12:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 12:27 David Marchand [this message]
2019-08-01 12:29 ` David Marchand
2019-08-02 11:13 ` David Marchand
2019-08-02 13:37 ` Aaron Conole
2019-08-02 13:45 ` David Marchand
2019-08-02 20:57 ` Thomas Monjalon
2019-08-03 9:51 ` David Marchand
2019-08-05 10:19 ` Thomas Monjalon
2019-08-08 11:23 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1564662465-2925-1-git-send-email-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=msantana@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).