patches for DPDK stable branches
 help / color / Atom feed
From: Xiao Zhang <xiao.zhang@intel.com>
To: dev@dpdk.org
Cc: qiming.yang@intel.com, beilei.xing@intel.com,
	xiaolong.ye@intel.com, Xiao Zhang <xiao.zhang@intel.com>,
	stable@dpdk.org
Subject: [dpdk-stable] [PATCH v2 2/5] net/ice: fix dereference after null check coverity
Date: Tue,  6 Aug 2019 07:20:51 +0800
Message-ID: <1565047254-66826-3-git-send-email-xiao.zhang@intel.com> (raw)
In-Reply-To: <1565047254-66826-1-git-send-email-xiao.zhang@intel.com>

This patch fixes (dereference after null check) coverity issue.
The address of first segmented packets was not set correctly during
reassembling packets which led to this issue.

Coverity issue: 343452
Coverity issue: 343407
Fixes: c68a52b8 ("net/ice: support vector SSE in Rx")
Cc: stable@dpdk.org

Signed-off-by: Xiao Zhang <xiao.zhang@intel.com>
---
 drivers/net/ice/ice_rxtx_vec_avx2.c | 1 +
 drivers/net/ice/ice_rxtx_vec_sse.c  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/net/ice/ice_rxtx_vec_avx2.c b/drivers/net/ice/ice_rxtx_vec_avx2.c
index fac869a..5ce29c2 100644
--- a/drivers/net/ice/ice_rxtx_vec_avx2.c
+++ b/drivers/net/ice/ice_rxtx_vec_avx2.c
@@ -656,6 +656,7 @@ ice_recv_scattered_burst_vec_avx2(void *rx_queue, struct rte_mbuf **rx_pkts,
 			i++;
 		if (i == nb_bufs)
 			return nb_bufs;
+		rxq->pkt_first_seg = rx_pkts[i];
 	}
 	return i + ice_rx_reassemble_packets(rxq, &rx_pkts[i], nb_bufs - i,
 					     &split_flags[i]);
diff --git a/drivers/net/ice/ice_rxtx_vec_sse.c b/drivers/net/ice/ice_rxtx_vec_sse.c
index 049f60d..967a7b1 100644
--- a/drivers/net/ice/ice_rxtx_vec_sse.c
+++ b/drivers/net/ice/ice_rxtx_vec_sse.c
@@ -509,6 +509,7 @@ ice_recv_scattered_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
 			i++;
 		if (i == nb_bufs)
 			return nb_bufs;
+		rxq->pkt_first_seg = rx_pkts[i];
 	}
 	return i + ice_rx_reassemble_packets(rxq, &rx_pkts[i], nb_bufs - i,
 					     &split_flags[i]);
-- 
2.7.4


  parent reply index

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-04 21:00 [dpdk-stable] [PATCH 1/5] net/fm10k: " Xiao Zhang
2019-08-04 21:00 ` [dpdk-stable] [PATCH 2/5] net/iavf: " Xiao Zhang
2019-08-04 21:00 ` [dpdk-stable] [PATCH 3/5] net/i40e: " Xiao Zhang
2019-08-04 21:00 ` [dpdk-stable] [PATCH 4/5] net/ice: " Xiao Zhang
2019-08-04 21:00 ` [dpdk-stable] [PATCH 5/5] net/ixgbe: " Xiao Zhang
2019-08-05  3:35 ` [dpdk-stable] [dpdk-dev] [PATCH 1/5] net/fm10k: " Ye Xiaolong
2019-08-05 23:20 ` [dpdk-stable] [v2 0/5] " Xiao Zhang
2019-08-05 15:46   ` Ye Xiaolong
2019-08-06 11:30     ` [dpdk-stable] [dpdk-dev] " Zhang, Qi Z
2019-08-06 14:01       ` Ye Xiaolong
2019-08-06 14:13         ` Zhang, Xiao
2019-08-05 23:20   ` [dpdk-stable] [PATCH v2 1/5] net/ixgbe: " Xiao Zhang
2019-08-05 23:20   ` Xiao Zhang [this message]
2019-08-05 23:20   ` [dpdk-stable] [PATCH v2 3/5] net/i40e: " Xiao Zhang
2019-08-05 23:20   ` [dpdk-stable] [PATCH v2 4/5] net/iavf: " Xiao Zhang
2019-08-05 23:20   ` [dpdk-stable] [PATCH v2 5/5] net/fm10k: " Xiao Zhang

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1565047254-66826-3-git-send-email-xiao.zhang@intel.com \
    --to=xiao.zhang@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox