From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51335A055D for ; Fri, 19 Feb 2021 12:33:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3067440395; Fri, 19 Feb 2021 12:33:29 +0100 (CET) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by mails.dpdk.org (Postfix) with ESMTP id E115840395 for ; Fri, 19 Feb 2021 12:33:28 +0100 (CET) Received: by mail-ed1-f46.google.com with SMTP id g3so9245761edb.11 for ; Fri, 19 Feb 2021 03:33:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=jEIEIwxaDOxAYxzBJWVbUTW+3BKybmOd5qzZuOQB9Ck=; b=J5XVjd5FU1UFvo+LNWRn+66Mdy8xN2wQfSpO9fSlGoA/1gpSHPMefenJKFF04cASdO eGUwqRWfjGNSx0qF/s0gAtDjpGa/sdSZqsQbtg2yccC1ME1kwYXNwUh0m6i3bPJkV96h tael7ooW8CyXdKqUuOOBlPsFVHI3mIRPjbxBMm8pTPJC8iTZzz7nt3Eca/XPJNzatdnT lAfDkiS0luPJmk7gAw/ZKSmAMO8FHkBvsCbz0/pyo6IyifNfhCRUwVfcysvlDybuvT9k k5YdSMH2QlnK+snnqDvhqRtIyPXEw8rssB/m01y02D6D7yW0SII0fg+642hbBRnsJLE0 +ClQ== X-Gm-Message-State: AOAM531hVnU5L9meoOJoLQVrtWJSr3gKqCvq66qWXwsAgMHFnH4lhKBS ORmd4JJaUQ+Eg3IWFOxkGXc= X-Google-Smtp-Source: ABdhPJzhj6m7NCSbhOu/VFNvCOiW5dw8wwZjFj9m5lrgheHWtFRXI8HKULomXRL/wfqi7du1ndQ9Pw== X-Received: by 2002:a05:6402:2707:: with SMTP id y7mr8496418edd.5.1613734408688; Fri, 19 Feb 2021 03:33:28 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:7a8e:ed70:5c52:ea3]) by smtp.gmail.com with ESMTPSA id q20sm4366152ejs.17.2021.02.19.03.33.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Feb 2021 03:33:28 -0800 (PST) Message-ID: <1565f89657b62b8c8baa2a2c9524a0592f99fa3b.camel@debian.org> From: Luca Boccassi To: Juraj =?UTF-8?Q?Linke=C5=A1?= , "stable@dpdk.org" Cc: "jerinj@marvell.com" , "ruifeng.wang@arm.com" , "david.marchand@redhat.com" Date: Fri, 19 Feb 2021 11:33:27 +0000 In-Reply-To: <953ce5333ed145a58f26e9eaea240c50@pantheon.tech> References: <20210219105740.1567636-1-luca.boccassi@gmail.com> <953ce5333ed145a58f26e9eaea240c50@pantheon.tech> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.2 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 20.11] config/arm: replace native machine args X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Fri, 2021-02-19 at 11:06 +0000, Juraj Linke=C5=A1 wrote: > > -----Original Message----- > > From: luca.boccassi@gmail.com > > Sent: Friday, February 19, 2021 11:58 AM > > To: stable@dpdk.org > > Cc: Juraj Linke=C5=A1 ; jerinj@marvell.com; > > ruifeng.wang@arm.com; david.marchand@redhat.com > > Subject: [PATCH 20.11] config/arm: replace native machine args > >=20 > > From: Juraj Linke=C5=A1 > >=20 > > [ backported from upstream commit > > 9186e5a07f35ae74a1f7fa2d89671b5f77eae407 ] > >=20 > > There are compiler issues when building with -mcpu=3Dnative with popula= r > > compilers, such as GCC-8.4: > > In file included from ../lib/librte_eal/arm/include/rte_vect.h:11, > > from ../lib/librte_net/net_crc_neon.c:10: > > ../lib/librte_net/net_crc_neon.c: In function =E2=80=98crcr32_folding_r= ound=E2=80=99: > > /usr/lib/gcc/aarch64-linux-gnu/8/include/arm_neon.h:26094:1: error: > > inlining failed in call to always_inline =E2=80=98vmull_p64=E2=80=99: > > target specific option mismatch > > vmull_p64 (poly64_t a, poly64_t b) > > ../lib/librte_net/net_crc_neon.c:50:20: note: called from here > > uint64x2_t tmp1 =3D vreinterpretq_u64_p128(vmull_p64( > > vgetq_lane_p64(vreinterpretq_p64_u64(fold), 0), > > vgetq_lane_p64(vreinterpretq_p64_u64(precomp), 1))); > >=20 > > and clang: > > gcc -E -dM -mcpu=3D"native" - < /dev/null | grep __ARM_FEATURE_ATOMICS > > clang-9 -E -dM -mcpu=3D"native" - < /dev/null | grep __ARM_FEATURE_ATOM= ICS > > # no clang support > >=20 > > Fix this by always specifying the proper machine args and never using t= he native > > flags. > >=20 > > Fixes: 78ac8eac7e8a ("config/arm: use native machine build arguments") > >=20 > > Signed-off-by: Juraj Linke=C5=A1 > > Signed-off-by: Luca Boccassi > > --- > > This is a crude backport, but it fixes the build for arm64. It's a rele= ase blocker for > > 20.11.1, so I would appreciate a quick review. > > Thanks! >=20 > What does this fix? With or without the below change, the native machine = args are not used. The patch shoudn't actually change the configuration of = the build at all, so I'm a bit confused. It fixes the build on some build workers with thunderx hardware - without this I get failures like: arm_neon.h:26647:1: error: inlining failed in call to 'always_inline' 'vmull_p64': target specific option mismatch --=20 Kind regards, Luca Boccassi