From: Phil Yang <phil.yang@arm.com>
To: yskoh@mellanox.com, viacheslavo@mellanox.com, matan@mellanox.com,
nelio.laranjeiro@6wind.com, dev@dpdk.org
Cc: thomas@monjalon.net, jerinj@marvell.com,
Honnappa.Nagarahalli@arm.com, gavin.hu@arm.com, nd@arm.com,
stable@dpdk.org
Subject: [dpdk-stable] [PATCH 1/2] net/mlx5: fix Rx CQ doorbell synchronization on aarch64
Date: Thu, 5 Sep 2019 18:55:07 +0800 [thread overview]
Message-ID: <1567680908-31210-1-git-send-email-phil.yang@arm.com> (raw)
The Rx completion queue doorbell field needs to be updated after
the last CQE decompressed. For the weaker memory model processors,
the compiler barrier is not sufficient to guarantee the order of
these operations, so use the coherent I/O memory barrier to make
sure these fields are updated in order.
Fixes: 570acdb1da8a ("net/mlx5: add vectorized Rx/Tx burst for ARM")
Cc: stable@dpdk.org
Suggested-by: Gavin Hu <gavin.hu@arm.com>
Signed-off-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
---
drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h
index 9930286..e914d01 100644
--- a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h
+++ b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h
@@ -727,7 +727,7 @@ rxq_burst_v(struct mlx5_rxq_data *rxq, struct rte_mbuf **pkts, uint16_t pkts_n,
rxq->decompressed -= n;
}
}
- rte_compiler_barrier();
+ rte_cio_wmb();
*rxq->cq_db = rte_cpu_to_be_32(rxq->cq_ci);
return rcvd_pkt;
}
--
2.7.4
next reply other threads:[~2019-09-05 10:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 10:55 Phil Yang [this message]
2019-09-05 10:55 ` [dpdk-stable] [PATCH 2/2] net/mlx5: fix Tx " Phil Yang
2019-09-05 12:12 ` Slava Ovsiienko
2019-09-06 7:20 ` Phil Yang (Arm Technology China)
2019-09-06 12:26 ` Slava Ovsiienko
2019-09-09 10:12 ` Phil Yang (Arm Technology China)
2019-09-09 11:29 ` Slava Ovsiienko
2019-09-10 9:22 ` Phil Yang (Arm Technology China)
2019-09-10 7:22 ` [dpdk-stable] [PATCH 1/2] net/mlx5: fix Rx " Matan Azrad
2019-09-12 8:29 ` [dpdk-stable] [dpdk-dev] " Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1567680908-31210-1-git-send-email-phil.yang@arm.com \
--to=phil.yang@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=jerinj@marvell.com \
--cc=matan@mellanox.com \
--cc=nd@arm.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=viacheslavo@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).