From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47366A2EC2 for ; Thu, 5 Sep 2019 19:26:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 390C81EF4D; Thu, 5 Sep 2019 19:26:02 +0200 (CEST) Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-eopbgr790048.outbound.protection.outlook.com [40.107.79.48]) by dpdk.org (Postfix) with ESMTP id C931D1ED68 for ; Thu, 5 Sep 2019 19:26:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I+deXR8iEa6K9V3gHDZ2YofQV9k7Galc8IaKrMJV0JhMXudcXGIaqLKMAgPpch00s4QPCfgHqXkqdjzjJQbwmErZ4f/2PJZgUQ3o2Bw0xwTHy5jVAWS+Ok4uAonXqz+FL4gDlsf+qDaFREpOQALodbtWEIRYh1r4jgPCGyDlaHqRYGUlzwMxS/bLixSWDUgSq68dpKdveKx81Onzm1p7Vw1mL+4r64q4bOLQm8SI/81LlE6puPEzPvlf4M6ID8KnaBEVDlyfZ/ly2j7w9v5lIPGscay3n7RLGHCKX/ozEbhKeodNuhSuOoK1I0wsvu64kQnXOU///rsa4+Z+N6pR5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=82e7a7fzlsQlm8qhQe92DoXfdJjAfI8FRnizJh6dHsY=; b=JVmul2n9U5c+N1BcWbtSFRymf1cZ0uebxo2RvbMoCNGrcLgO87S3HJJxos5t3igK8azjFm13ybR71k+9ZP3bPohnHsxd+Dm8744Xlnw3tdGY07TLN1Or5rZ8U4uBM6St/SpmYowblIGsYeKcL//VyECUta4n4srZ+mF6r828VZ70w0Jn1B+OMiq+okueevQ4G6Z+z50qvL8RFQoyoQRr0WjLtdQuOsJXqLrxlffMBAtYRVHPYUTCrE0Jtqw6dZIQSEp9ipx4cGF43WR5n1lyr41l3oqT3Xg1LKsbA1hV567YYmqkXh0snG4dY5qP/wxaNy5V+dvxGwwYLSbFDONTZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aquantia.com; dmarc=pass action=none header.from=aquantia.com; dkim=pass header.d=aquantia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector2-AQUANTIA1COM-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=82e7a7fzlsQlm8qhQe92DoXfdJjAfI8FRnizJh6dHsY=; b=WMmGh2T1pLLOVeG1OtCVdBRLwyaKv6dwv5oZBYvIohoZ6NM46wk4mRPQJ1m/I9rPoF1VWFv/cf0hB7jV2C6JkPS7mSUU4WETZtTE4EL+WjB4lRBnBZUT6Z0/jjEJFNz4l75IeB0zTEBFL9eUH/jxnKMFIjQCQ41zFm8hwpRY76w= Received: from CY4PR1101MB2183.namprd11.prod.outlook.com (10.172.76.20) by CY4PR1101MB2198.namprd11.prod.outlook.com (10.172.78.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.17; Thu, 5 Sep 2019 17:25:59 +0000 Received: from CY4PR1101MB2183.namprd11.prod.outlook.com ([fe80::4dee:fb50:cc75:fbde]) by CY4PR1101MB2183.namprd11.prod.outlook.com ([fe80::4dee:fb50:cc75:fbde%6]) with mapi id 15.20.2199.027; Thu, 5 Sep 2019 17:25:59 +0000 From: Pavel Belous To: Pavel Belous CC: Pavel Belous , "stable@dpdk.org" , Igor Russkikh Thread-Topic: [PATCH 2/3] net/atlantic: fix reported flow control mode Thread-Index: AQHVZA77YygsnYV830eM6lUy2T4QSQ== Date: Thu, 5 Sep 2019 17:25:59 +0000 Message-ID: <1567704331-10061-3-git-send-email-Pavel.Belous@aquantia.com> References: <1567704331-10061-1-git-send-email-Pavel.Belous@aquantia.com> In-Reply-To: <1567704331-10061-1-git-send-email-Pavel.Belous@aquantia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1P190CA0010.EURP190.PROD.OUTLOOK.COM (2603:10a6:3:bc::20) To CY4PR1101MB2183.namprd11.prod.outlook.com (2603:10b6:910:18::20) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Pavel.Belous@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.7.4 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 727363ce-3892-436a-b008-08d732261e17 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:CY4PR1101MB2198; x-ms-traffictypediagnostic: CY4PR1101MB2198: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:172; x-forefront-prvs: 015114592F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39850400004)(366004)(346002)(376002)(136003)(396003)(199004)(189003)(478600001)(7736002)(8936002)(316002)(6436002)(50226002)(305945005)(36756003)(99286004)(52116002)(486006)(6200100001)(66066001)(6486002)(14454004)(54906003)(81166006)(5660300002)(37006003)(8676002)(44832011)(81156014)(386003)(6506007)(107886003)(53936002)(86362001)(3846002)(476003)(2616005)(446003)(186003)(6116002)(11346002)(26005)(76176011)(102836004)(2906002)(7049001)(71190400001)(4326008)(66446008)(25786009)(66476007)(66556008)(66946007)(6512007)(71200400001)(64756008)(6862004)(256004); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1101MB2198; H:CY4PR1101MB2183.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: s0ez+6NOTJSXrBLxDssLaCJVW5l02Hr/vBBnIUKqs2VQFouQ1jj3vwCkJgh7rqUgWs6vZCxpt/elCMOhqcI3KWa3vGlTK7TfDbATeLXm3Gc4RNLsrPWCYjf5lxFcncrUVma4zv9OH52X8le19WTLVl828rrQJnUMcUcapci5LgGQu96gKecOa2lMFasty+9+J6qYwpS4Xq8+N4XFdOXnlHFHRmKnjSgOHO8Basmiamt+UbHiswSsjsG2hXhGdgoxD3+4rA5xdz8VxNMlw5PbMd5mobaJDFMnfd8PVRxmHCJlEQFTjF2xa8FSRNUmJiHOHMxkEjsorXUjYEQ9uwRvhd388d/xIEd+supLohYC869x97uN++RE4On+fUfti2C9mFMs8qQU9jHqX21YX0jsasa6ceagvNCj8/R267Dvl+8= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 727363ce-3892-436a-b008-08d732261e17 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Sep 2019 17:25:59.4867 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cqiUpxT4wG27HXy6/b84lRUL5cRYFHUSAfD7lu73f4Q6ZaUxL6yyEzaG/4EhcDBpgIc10QpEMrZW4nPdjI1tIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2198 Subject: [dpdk-stable] [PATCH 2/3] net/atlantic: fix reported flow control mode X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" From: Pavel Belous Driver reports current flow control mode based on internal flow control settings. Currently this logic works incorrectly. Fixes: 921eb6b8ce31 ("net/atlantic: fix flow control by sync settings on Rx= ") Cc: stable@dpdk.org Signed-off-by: Pavel Belous Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_e= thdev.c index 178f7db..1b9d514 100644 --- a/drivers/net/atlantic/atl_ethdev.c +++ b/drivers/net/atlantic/atl_ethdev.c @@ -1535,11 +1535,11 @@ atl_flow_ctrl_get(struct rte_eth_dev *dev, struct r= te_eth_fc_conf *fc_conf) =20 if (fc =3D=3D AQ_NIC_FC_OFF) fc_conf->mode =3D RTE_FC_NONE; - else if (fc & (AQ_NIC_FC_RX | AQ_NIC_FC_TX)) + else if ((fc & AQ_NIC_FC_RX) && (fc & AQ_NIC_FC_TX)) fc_conf->mode =3D RTE_FC_FULL; else if (fc & AQ_NIC_FC_RX) fc_conf->mode =3D RTE_FC_RX_PAUSE; - else if (fc & AQ_NIC_FC_RX) + else if (fc & AQ_NIC_FC_TX) fc_conf->mode =3D RTE_FC_TX_PAUSE; =20 return 0; --=20 2.7.4