From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA1EDA2EDC for ; Thu, 5 Sep 2019 19:41:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8E5F11F097; Thu, 5 Sep 2019 19:41:52 +0200 (CEST) Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-eopbgr760042.outbound.protection.outlook.com [40.107.76.42]) by dpdk.org (Postfix) with ESMTP id 82CA51F080; Thu, 5 Sep 2019 19:41:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LRlSv/b9ovKR8UGun5jJD5AWBAQfTZ0ZwleL+TAa7IdWggKPhNwl90y6q94nuG4juov7TMV+RhKobCoGZ38SDldArfB1OKTaM9Eho/D+0LoD+V5BcRiUZQW81FIbGUfPufi/dzcLJE+abWN+/WfnLaqxDf6GgnKh/esLr9vMUhH9WdvDJbZKYGRg9PwlTjB24oHYh5x+T6WvDDbyQIYIdq1BaprNENtrfoG6NuS6XQivXovj00g0Yw9a9u7B+MwMXTgJQSX8kxrZZ1mgS2x7z2J+ndrZuz+fOQ+xQMyJXTGX855Nd4Kdmv0t7YXwmHjN0xGz3AjeJg2FaYljpO3n+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=82e7a7fzlsQlm8qhQe92DoXfdJjAfI8FRnizJh6dHsY=; b=k0lsfl5p9jAaMZtZ8h+B+c204yZ/JrvoH72h5IDuWL0c43FW8QHZ0NbHdBYEAcONb10iw97NTkRr6HqNF34+KacRbTtZXAXOzuJBO806qwqHHFWEHocMDhOObVwf+NCWrOYwiFORFshU/lfNS3IDBGo3U1z5I0yNQJfS1E7Gqz3Dpm81Hl/rqtvZvAvQbmDAFcLympxkyZQctuX/Lbc4g71vXbXKnvtaHcOAWIe2lsDCY7Ob75vC3j+YwRSJhzWj4fM0Q9Kop2JI4rWZYhjup4nSvvtSaIQ/zAznOXebqruBG9T2pj/yRSgnjXS7mkYywRcC14iaO8ENOD+ljZPoFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aquantia.com; dmarc=pass action=none header.from=aquantia.com; dkim=pass header.d=aquantia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector2-AQUANTIA1COM-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=82e7a7fzlsQlm8qhQe92DoXfdJjAfI8FRnizJh6dHsY=; b=FZZIAhs4S2+FH+W7Dr/Psw6gZ96toSzLcWcA7LaIyEIM91vwLedgLegu8TRC4eZ2MI90NkdRox82gJgVlpnyo1sXanoKDUeEYKXRwIR/d6v0h5t9mZyD8oNQtVyh4Dl3yAwmh+IaqCIU62a7y08pDDVwu8LxHcNy+PohOrpLcpg= Received: from CY4PR1101MB2183.namprd11.prod.outlook.com (10.172.76.20) by CY4SPR00MB057.namprd11.prod.outlook.com (10.173.60.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.14; Thu, 5 Sep 2019 17:41:47 +0000 Received: from CY4PR1101MB2183.namprd11.prod.outlook.com ([fe80::4dee:fb50:cc75:fbde]) by CY4PR1101MB2183.namprd11.prod.outlook.com ([fe80::4dee:fb50:cc75:fbde%6]) with mapi id 15.20.2199.027; Thu, 5 Sep 2019 17:41:47 +0000 From: Pavel Belous To: Ferruh Yigit CC: "dev@dpdk.org" , Igor Russkikh , Corey Melton , Pavel Belous , "stable@dpdk.org" Thread-Topic: [PATCH 2/3] net/atlantic: fix reported flow control mode Thread-Index: AQHVZBEwCq8Xk5bK4Uihj2VV9ELYhQ== Date: Thu, 5 Sep 2019 17:41:47 +0000 Message-ID: <1567705278-10558-3-git-send-email-Pavel.Belous@aquantia.com> References: <1567705278-10558-1-git-send-email-Pavel.Belous@aquantia.com> In-Reply-To: <1567705278-10558-1-git-send-email-Pavel.Belous@aquantia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1PR05CA0314.eurprd05.prod.outlook.com (2603:10a6:7:93::45) To CY4PR1101MB2183.namprd11.prod.outlook.com (2603:10b6:910:18::20) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Pavel.Belous@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.7.4 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5f98ccc7-12fa-432c-4523-08d73228530f x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:CY4SPR00MB057; x-ms-traffictypediagnostic: CY4SPR00MB057: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:172; x-forefront-prvs: 015114592F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(136003)(346002)(366004)(396003)(39850400004)(199004)(189003)(4326008)(3846002)(66446008)(86362001)(64756008)(66556008)(66476007)(8676002)(305945005)(6916009)(6116002)(2906002)(7736002)(66946007)(6512007)(6436002)(14454004)(6486002)(66066001)(81166006)(8936002)(81156014)(478600001)(50226002)(25786009)(6506007)(256004)(486006)(2616005)(476003)(71200400001)(316002)(54906003)(11346002)(71190400001)(36756003)(26005)(76176011)(446003)(386003)(44832011)(102836004)(186003)(52116002)(53936002)(99286004)(5660300002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4SPR00MB057; H:CY4PR1101MB2183.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: E4HFaK3jnzDZxzDELP33owV6AV1Niu5ONthhsmqfXsSGVYSvgP52nJ32lAxYw0u0H4YgtRtEWsdPUd5hCXvTcawaf+gxo+45TLUi+X5rINcYlZtWUqKM22SECaBoW4bkisiuAeQ3DPDxsZ1N5eL19L9AUDw3eDtx1oo8shSVkhKXJ3VDIz0k2gLhzT9KBxJeQxMQRP0zTIbCpBnezK1I6uvNZqWFUkp7JKzcDT0zckbfPZY28oUlfV9R5TgcTrsAcmWb38Bk4lX9JDFogouKgWdGTJFEaOWKMSJil/Xh0RZX6ozQ2Lbntu7qKXKLIbxAcnHcwwX/ZMfxMl2c7WUrnY8cfNXKP96TCuRp/9kz/Z8FSmldrOcPla7ssRTCIpPDYrNIlrHc/vHZgmt8o//DGuLUENOLPLofoK+ZFqDCbq8= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f98ccc7-12fa-432c-4523-08d73228530f X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Sep 2019 17:41:47.3588 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0Iuv9Wi0NkKhPYMxdqfe66bRtJhsKf09YIKdR2hgP21QpnVg7KE8aKhIiPZ3j2tKn9mcwAzSa5kWuzX6UFTs3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4SPR00MB057 Subject: [dpdk-stable] [PATCH 2/3] net/atlantic: fix reported flow control mode X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" From: Pavel Belous Driver reports current flow control mode based on internal flow control settings. Currently this logic works incorrectly. Fixes: 921eb6b8ce31 ("net/atlantic: fix flow control by sync settings on Rx= ") Cc: stable@dpdk.org Signed-off-by: Pavel Belous Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_e= thdev.c index 178f7db..1b9d514 100644 --- a/drivers/net/atlantic/atl_ethdev.c +++ b/drivers/net/atlantic/atl_ethdev.c @@ -1535,11 +1535,11 @@ atl_flow_ctrl_get(struct rte_eth_dev *dev, struct r= te_eth_fc_conf *fc_conf) =20 if (fc =3D=3D AQ_NIC_FC_OFF) fc_conf->mode =3D RTE_FC_NONE; - else if (fc & (AQ_NIC_FC_RX | AQ_NIC_FC_TX)) + else if ((fc & AQ_NIC_FC_RX) && (fc & AQ_NIC_FC_TX)) fc_conf->mode =3D RTE_FC_FULL; else if (fc & AQ_NIC_FC_RX) fc_conf->mode =3D RTE_FC_RX_PAUSE; - else if (fc & AQ_NIC_FC_RX) + else if (fc & AQ_NIC_FC_TX) fc_conf->mode =3D RTE_FC_TX_PAUSE; =20 return 0; --=20 2.7.4