* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] vhost: fix corner case for enqueue operation [not found] ` <310219be-daa2-eb06-fc02-1e76784a01f4@redhat.com> @ 2018-09-27 18:05 ` Kevin Traynor 2018-09-27 18:34 ` Maxime Coquelin 0 siblings, 1 reply; 2+ messages in thread From: Kevin Traynor @ 2018-09-27 18:05 UTC (permalink / raw) To: Maxime Coquelin, Jiayu Hu, dev; +Cc: tiwei.bie, zhihong.wang, Gavin.Hu, stable On 09/27/2018 01:37 PM, Maxime Coquelin wrote: > > > On 09/27/2018 02:24 PM, Maxime Coquelin wrote: >> >> >> On 09/17/2018 05:54 AM, Jiayu Hu wrote: >>> When perform enqueue operations on the split and packed ring, >> s/perform/performing/ >> s/ring/rings/ >>> if the reserved buffer length from the descriptor table execeeds >>> 65535, the returned length by fill_vec_buf_split/_packed() is >>> overflowed. This patch is to avoid this corner case. >> s/overflowed/overflows/ >>> >>> Fixes: f689586b ("vhost: shadow used ring update") >>> Fixes: fd68b473 ("vhost: use buffer vectors in dequeue path") >>> Fixes: 2f3225a7 ("vhost: add vector filling support for packed ring") >>> Fixes: 37f5e79a ("vhost: add shadow used ring support for packed rings") >>> Fixes: a922401f ("vhost: add Rx support for packed ring") >>> Fixes: ae999ce4 ("vhost: add Tx support for packed ring") >>> It breaks the record for number of Fixes? :-) I think relevant for stables also - any reason why not? >>> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com> >>> --- >>> lib/librte_vhost/virtio_net.c | 20 +++++++++++--------- >>> 1 file changed, 11 insertions(+), 9 deletions(-) >>> >> >> Other than that, the patch looks good to me. Thanks for fixing it. >> >> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> >> >> Maxime > > Applied to dpdk-next-virtio/master with commit message fix. > > Thanks, > Maxime ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] vhost: fix corner case for enqueue operation 2018-09-27 18:05 ` [dpdk-stable] [dpdk-dev] [PATCH v2] vhost: fix corner case for enqueue operation Kevin Traynor @ 2018-09-27 18:34 ` Maxime Coquelin 0 siblings, 0 replies; 2+ messages in thread From: Maxime Coquelin @ 2018-09-27 18:34 UTC (permalink / raw) To: Kevin Traynor, Jiayu Hu, dev; +Cc: tiwei.bie, zhihong.wang, Gavin.Hu, stable On 09/27/2018 08:05 PM, Kevin Traynor wrote: > On 09/27/2018 01:37 PM, Maxime Coquelin wrote: >> >> >> On 09/27/2018 02:24 PM, Maxime Coquelin wrote: >>> >>> >>> On 09/17/2018 05:54 AM, Jiayu Hu wrote: >>>> When perform enqueue operations on the split and packed ring, >>> s/perform/performing/ >>> s/ring/rings/ >>>> if the reserved buffer length from the descriptor table execeeds >>>> 65535, the returned length by fill_vec_buf_split/_packed() is >>>> overflowed. This patch is to avoid this corner case. >>> s/overflowed/overflows/ >>>> >>>> Fixes: f689586b ("vhost: shadow used ring update") >>>> Fixes: fd68b473 ("vhost: use buffer vectors in dequeue path") >>>> Fixes: 2f3225a7 ("vhost: add vector filling support for packed ring") >>>> Fixes: 37f5e79a ("vhost: add shadow used ring support for packed rings") >>>> Fixes: a922401f ("vhost: add Rx support for packed ring") >>>> Fixes: ae999ce4 ("vhost: add Tx support for packed ring") >>>> > > It breaks the record for number of Fixes? :-) This is exhaustive! :) > > I think relevant for stables also - any reason why not? Forgot to mention, but I added it while applying. FYI, it targets v18.08. >>>> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com> >>>> --- >>>> lib/librte_vhost/virtio_net.c | 20 +++++++++++--------- >>>> 1 file changed, 11 insertions(+), 9 deletions(-) >>>> >>> >>> Other than that, the patch looks good to me. Thanks for fixing it. >>> >>> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> >>> >>> Maxime >> >> Applied to dpdk-next-virtio/master with commit message fix. >> >> Thanks, >> Maxime > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-27 18:34 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <1536305094-126439-1-git-send-email-jiayu.hu@intel.com> [not found] ` <1537156482-46428-1-git-send-email-jiayu.hu@intel.com> [not found] ` <47f35e9f-a211-5eb5-b2e9-23145f44d1bc@redhat.com> [not found] ` <310219be-daa2-eb06-fc02-1e76784a01f4@redhat.com> 2018-09-27 18:05 ` [dpdk-stable] [dpdk-dev] [PATCH v2] vhost: fix corner case for enqueue operation Kevin Traynor 2018-09-27 18:34 ` Maxime Coquelin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).