From: Michael Baum <michaelba@nvidia.com> To: dev@dpdk.org Cc: Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, stable@dpdk.org Subject: [dpdk-stable] [PATCH 1/7] regex/mlx5: fix jump to the wrong label Date: Wed, 18 Nov 2020 17:00:05 +0000 Message-ID: <1605718811-18652-1-git-send-email-michaelba@nvidia.com> (raw) The mlx5_regex_pci_probe function allocates a mlx5_regex_priv structure using rte_zmalloc. If the allocation fails, the function jumps to the dev_error label in order to release previously allocated resources in the function. However, in the dev_error label it attempts to refer to the internal fields of the priv structure and if its allocation fails (as in this case) it is actually dereferencing to NULL. Replace the jump with an error label. Fixes: 1db6ebd4ef58 ("regex/mlx5: fix crash on initialization failure") Cc: stable@dpdk.org Signed-off-by: Michael Baum <michaelba@nvidia.com> Acked-by: Ori Kam <orika@nvidia.com> --- drivers/regex/mlx5/mlx5_regex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regex/mlx5/mlx5_regex.c b/drivers/regex/mlx5/mlx5_regex.c index 05048e7..c91c444 100644 --- a/drivers/regex/mlx5/mlx5_regex.c +++ b/drivers/regex/mlx5/mlx5_regex.c @@ -157,7 +157,7 @@ if (!priv) { DRV_LOG(ERR, "Failed to allocate private memory."); rte_errno = ENOMEM; - goto error; + goto dev_error; } priv->ctx = ctx; priv->nb_engines = 2; /* attr.regexp_num_of_engines */ -- 1.8.3.1
next reply other threads:[~2020-11-18 17:00 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-18 17:00 Michael Baum [this message] 2020-11-18 17:00 ` [dpdk-stable] [PATCH 2/7] regex/mlx5: fix iterator type in RXP engines management Michael Baum 2020-11-18 17:00 ` [dpdk-stable] [PATCH 3/7] regex/mlx5: fix unnecessary init in RXP handle Michael Baum 2020-11-18 17:00 ` [dpdk-stable] [PATCH 4/7] regex/mlx5: fix unchecked return value " Michael Baum 2020-11-18 17:00 ` [dpdk-stable] [PATCH 5/7] regex/mlx5: improve error messages in RXP rules flush Michael Baum 2020-11-18 17:00 ` [dpdk-stable] [PATCH 6/7] regex/mlx5: improve constants type in QP buffers creation Michael Baum 2020-11-22 13:58 ` Thomas Monjalon 2020-11-22 14:06 ` [dpdk-stable] [PATCH 1/7] regex/mlx5: fix jump to the wrong label Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1605718811-18652-1-git-send-email-michaelba@nvidia.com \ --to=michaelba@nvidia.com \ --cc=dev@dpdk.org \ --cc=matan@nvidia.com \ --cc=rasland@nvidia.com \ --cc=stable@dpdk.org \ --cc=viacheslavo@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git